From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x533.google.com (mail-ed1-x533.google.com [IPv6:2a00:1450:4864:20::533]) by sourceware.org (Postfix) with ESMTPS id 344903858C30 for ; Tue, 3 Oct 2023 13:22:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 344903858C30 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ed1-x533.google.com with SMTP id 4fb4d7f45d1cf-533c4d20b33so1966183a12.0 for ; Tue, 03 Oct 2023 06:22:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696339340; x=1696944140; darn=gcc.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=u/idnyo1NFqPt6OpvqDog6LSvfmaz5BA2bbnIj0ljLo=; b=Yr4A2VHQBLWQAw10OPvTe9TVmkvYdwKuWy1y2LLl3gdM6xFg4wWZ+QhsxaB6S8D7Oj FreCy3asDL0M0GA7tUyR63ne1KDQtRJ3Gm6/qnnJZChQvxgtt3jGRCftHldPdiajxuq7 8KuknFkOB19Vq1IX0fcxpIh+RRir9gT/Trl8OneqIHvZlGh6F0uZVMiOZwse+NBbJ09B dc/NqfH8IBw8ttOkFRgFiX/V9fY4iI1oaa1+LKbU5IYfhYAj3vgywmLMwjrZt5lWitN0 cS31p+d7HZ1uIFNAu1A/WiVFgdmRH4nX/EfeWbAs7arThdlnA6zxsH87PM0zv/DD8l2s YJIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696339340; x=1696944140; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=u/idnyo1NFqPt6OpvqDog6LSvfmaz5BA2bbnIj0ljLo=; b=sFKYODJK0bKo42ew/6jFxGaLpKw3X7HqHCEv2EuFWZhZy9FIX8tFlqP6mf/c/yb+eK M2/KvNuscdMIB17tq5mr7oQ859Zpco/ZBoJI/J2uaW5P+5vFZxakvMBa3bz+Vu8XTJZZ aP7iLxXPmGIcBhxBC0xbpf7CqqfJq7yf4Swij4ynz2RMn7gqGbCScdI/t+Wsa1RPONVi DTsNnBU7g0AQjR0iFVNMQ+xRN311IcjR1TaTIdX9yv4CqobVALnJAkyEPT+zri9TIJdI GvIABBE6sX/4uMB1rXAVs8Vcd2W5IEdo6UEAsLxR/RwgKxg86+EDuXPCKDvsqkFBV3vH L0mg== X-Gm-Message-State: AOJu0YxZ3u1p6YWhtpDEGnZhEMwBA0Nmai9IXeUw+eLEQwZIJ/lHriRd eV9rh8WliCQJLnpMPidG+zV3BqUzf/aoLwLV5WfnYJIS X-Google-Smtp-Source: AGHT+IGNKBNluRKcUCbuPBxwDKlNk1f24yujfAIqJ6gtHm4g1b/vOz3pjZAR0hbBr1HSPzokOdjxTjiU5SB3JiAEm94= X-Received: by 2002:a05:6402:34d6:b0:525:4d74:be8c with SMTP id w22-20020a05640234d600b005254d74be8cmr2424677edc.14.1696339339521; Tue, 03 Oct 2023 06:22:19 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: David Edelsohn Date: Tue, 3 Oct 2023 09:22:07 -0400 Message-ID: Subject: Re: [PATCH v3] RISC-V:Optimize the MASK opt generation To: Kito Cheng Cc: Jeff Law , wangfeng@eswincomputing.com, GCC Patches Content-Type: multipart/alternative; boundary="000000000000c034160606cfc75d" X-Spam-Status: No, score=-0.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,FREEMAIL_REPLY,HTML_MESSAGE,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --000000000000c034160606cfc75d Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable The patch works on AIX. I have Gawk installed, but it is a very old release before multi-dimensional array support was added. Thanks, David On Mon, Oct 2, 2023 at 10:38=E2=80=AFPM Kito Cheng w= rote: > Proposed fix, and verified with "mawk" and "gawk -P" (gawk with posix > mode) on my linux also some other report it work on freebsd, just wait > review :) > > https://gcc.gnu.org/pipermail/gcc-patches/2023-October/631785.html > > On Tue, Oct 3, 2023 at 2:07=E2=80=AFAM Jeff Law w= rote: > > > > > > > > On 10/2/23 12:03, David Edelsohn wrote: > > > On Mon, Oct 2, 2023 at 1:59=E2=80=AFPM Jeff Law > > > wrote: > > > > > > > > > > > > On 10/2/23 11:20, David Edelsohn wrote: > > > > Wang, > > > > > > > > The AWK portions of this patch broke bootstrap on AIX. > > > > > > > > Also, the AWK portions are common code, not RISC-V specific. I > > > don't > > > > see anywhere that the common portions of the patch were > reviewed or > > > > approved by anyone with authority to approve the changes to the > > > AWK files. > > > > > > > > This patch should not have been committed without approval by a > > > reviewer > > > > with authority for that portion of the compiler and should have > been > > > > tested on targets other than RISC-V if common parts of the > > > compiler were > > > > changed. > > > I acked the generic bits. So the lack of testing on another > target is > > > on me. > > > > > > > > > Hi, Jeff > > > > > > Sorry. I didn't see a comment from a global reviewer in the V3 thread. > > NP. > > > > > > > > I am using Gawk on AIX. After the change, I see a parse error from > > > gawk. I'm rebuilding with a checkout just before the change to confi= rm > > > that it was the source of the error, and it seems to be past that > > > failure location. I didn't keep the exact error. Once I get past th= is > > > build cycle, I'll reproduce it. > > I think there's already a patch circulating which fixes this. It broke > > at least one other platform. Hopefully it'll all be sorted out today. > > > > > > jeff > --000000000000c034160606cfc75d--