From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 36106 invoked by alias); 3 Aug 2015 20:27:21 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 36077 invoked by uid 89); 3 Aug 2015 20:27:20 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-ig0-f173.google.com Received: from mail-ig0-f173.google.com (HELO mail-ig0-f173.google.com) (209.85.213.173) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Mon, 03 Aug 2015 20:27:19 +0000 Received: by iggf3 with SMTP id f3so63417332igg.1 for ; Mon, 03 Aug 2015 13:27:17 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.50.108.98 with SMTP id hj2mr52972igb.52.1438633637285; Mon, 03 Aug 2015 13:27:17 -0700 (PDT) Received: by 10.36.133.5 with HTTP; Mon, 3 Aug 2015 13:27:17 -0700 (PDT) In-Reply-To: <1438630768.5030.8.camel@otta> References: <1438630768.5030.8.camel@otta> Date: Mon, 03 Aug 2015 20:27:00 -0000 Message-ID: Subject: Re: [PATCH, rs6000] Fix source operand contraints for tabort. pattern From: David Edelsohn To: Peter Bergner Cc: GCC Patches , Tulio Magno Quites Machado Filho , "Paul E. Murphy" Content-Type: text/plain; charset=UTF-8 X-SW-Source: 2015-08/txt/msg00120.txt.bz2 On Mon, Aug 3, 2015 at 3:39 PM, Peter Bergner wrote: > This patch fixes an oversight in the tabort. pattern (only generated via > the __builtin_tabort (cause) builtin), which currently allows using r0. > The problem is that if r0 is used, the "cause" argument value passed in > by the user will be ignored, since using r0 means the value zero and not > the contents of r0 (similar to base registers in loads/stores, addi, etc.). > This patch restricts the tabort. pattern to only use base registers. > > This has passed bootstrapping and regtesting on trunk. Ok for mainline? > > I'd like to also backport this to the release branches. Is this ok for > them once bootstrapping and regtesting are complete on them? > > Peter > > gcc/ > * config/rs6000/htm.md (tabort.): Restrict the source operand to > using a base register. > > gcc/testsuite/ > * gcc.target/powerpc/htm-tabort-no-r0.c: New test. Okay. Thanks, David