public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: David Edelsohn <dje.gcc@gmail.com>
To: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [RS6000 1/7] Hide insns not needing to be public
Date: Thu, 25 Jun 2015 03:12:00 -0000	[thread overview]
Message-ID: <CAGWvnynJsGPAvF4vvOi-ja7=hOEaJ8Z9B2vw_e-j=yXzng3w=g@mail.gmail.com> (raw)
In-Reply-To: <20150624005012.GV1723@bubble.grove.modra.org>

On Tue, Jun 23, 2015 at 8:50 PM, Alan Modra <amodra@gmail.com> wrote:
>         * config/rs6000/rs6000.md (addsi3_high, bswaphi2_internal,
>         ashldi3_internal5, ashldi3_internal8): Prefix with '*'.

This patch is okay.

The rotate changes need to be discussed and coordinated with Segher.

The cost changes are okay in theory, but really should be applied in
conjunction with the rtx_cost improvements that you are discussing
with Jeff.

Thanks, David

  reply	other threads:[~2015-06-25  0:29 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-24  0:50 [RS6000 0/7] rtx_cost patches Alan Modra
2015-06-24  0:51 ` [RS6000 1/7] Hide insns not needing to be public Alan Modra
2015-06-25  3:12   ` David Edelsohn [this message]
2015-06-24  0:52 ` [RS6000 2/7] Tidy rotates Alan Modra
2015-06-24  0:53 ` [RS6000 3/7] rtx_costs for ROTATE/ASHIFT inside AND Alan Modra
2015-06-24  0:54 ` [RS6000 5/7] Split mask64_2_operand rotates early Alan Modra
2015-06-24  0:54 ` [RS6000 4/7] rldic in rotate and mask patterns Alan Modra
2015-06-24  0:55 ` [RS6000 6/7] Cost multi-insn constants Alan Modra
2015-06-24  1:02 ` [RS6000 7/7] Address cost Alan Modra
2015-07-08 16:53   ` Segher Boessenkool

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAGWvnynJsGPAvF4vvOi-ja7=hOEaJ8Z9B2vw_e-j=yXzng3w=g@mail.gmail.com' \
    --to=dje.gcc@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).