* [PATCH] rs6000.c missing target hook
@ 2012-05-22 14:15 David Edelsohn
2012-05-22 17:32 ` Mike Stump
0 siblings, 1 reply; 3+ messages in thread
From: David Edelsohn @ 2012-05-22 14:15 UTC (permalink / raw)
To: GCC Patches
During one of the target hook conversions,
rs6000_aix_asm_output_dwarf_table_ref() retained a use of
TARGET_STRIP_NAME_ENCODING macro instead of the target hook, which
broke when Alan cleaned up rs6000.c. Fixed thusly.
- David
* config/rs6000/rs6000.c (rs6000_aix_asm_output_dwarf_table_ref): Use
strip_name_encoding target hook.
Index: rs6000.c
===================================================================
--- rs6000.c (revision 187756)
+++ rs6000.c (working copy)
@@ -18392,7 +18392,7 @@
rs6000_aix_asm_output_dwarf_table_ref (char * frame_table_label)
{
fprintf (asm_out_file, "\t.ref %s\n",
- TARGET_STRIP_NAME_ENCODING (frame_table_label));
+ (* targetm.strip_name_encoding) (frame_table_label));
}
/* This ties together stack memory (MEM with an alias set of frame_alias_set)
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] rs6000.c missing target hook
2012-05-22 14:15 [PATCH] rs6000.c missing target hook David Edelsohn
@ 2012-05-22 17:32 ` Mike Stump
2012-05-22 23:57 ` David Edelsohn
0 siblings, 1 reply; 3+ messages in thread
From: Mike Stump @ 2012-05-22 17:32 UTC (permalink / raw)
To: David Edelsohn; +Cc: GCC Patches
On May 22, 2012, at 7:15 AM, David Edelsohn wrote:
> * config/rs6000/rs6000.c (rs6000_aix_asm_output_dwarf_table_ref): Use
> strip_name_encoding target hook.
>
> Index: rs6000.c
> ===================================================================
> --- rs6000.c (revision 187756)
> +++ rs6000.c (working copy)
> @@ -18392,7 +18392,7 @@
> rs6000_aix_asm_output_dwarf_table_ref (char * frame_table_label)
> {
> fprintf (asm_out_file, "\t.ref %s\n",
> - TARGET_STRIP_NAME_ENCODING (frame_table_label));
> + (* targetm.strip_name_encoding) (frame_table_label));
Any reason to not remove (* and )?
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] rs6000.c missing target hook
2012-05-22 17:32 ` Mike Stump
@ 2012-05-22 23:57 ` David Edelsohn
0 siblings, 0 replies; 3+ messages in thread
From: David Edelsohn @ 2012-05-22 23:57 UTC (permalink / raw)
To: Mike Stump; +Cc: GCC Patches
On Tue, May 22, 2012 at 1:31 PM, Mike Stump <mikestump@comcast.net> wrote:
>> fprintf (asm_out_file, "\t.ref %s\n",
>> - TARGET_STRIP_NAME_ENCODING (frame_table_label));
>> + (* targetm.strip_name_encoding) (frame_table_label));
>
> Any reason to not remove (* and )?
I wanted to be consistent with the rest of the file, which uses that style.
- David
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-05-22 23:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-05-22 14:15 [PATCH] rs6000.c missing target hook David Edelsohn
2012-05-22 17:32 ` Mike Stump
2012-05-22 23:57 ` David Edelsohn
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).