From: David Edelsohn <dje.gcc@gmail.com>
To: Vladimir Makarov <vmakarov@redhat.com>,
Aldy Hernandez <aldyh@redhat.com>,
Steven Bosscher <stevenb.gcc@gmail.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PR rtl-optimization/55604]: fix ICE in remove_some_program_points_and_update_live_ranges
Date: Wed, 05 Dec 2012 19:36:00 -0000 [thread overview]
Message-ID: <CAGWvnynUY-1WTO4t8+Er-jUo31-V1CGs6qT4zEM1Z_9eq70v+A@mail.gmail.com> (raw)
On 12-12-05 1:13 PM, Aldy Hernandez wrote:
>> This is a division by zero ICE.
>> In the testcase in the PR, both `n' and `lra_live_max_point' are zero. I have opted to inhibit the dump when lra_live_max_point is zero, but I can just as easily avoiding printing the percentage in this case.
> Interesting. I never thought that is possible.
>> Let me know what you prefer.
>> OK for trunk?
> Yes, it is ok if you add the testcase for GCC testsuite. It would be nice if you add analogous code for ira-lives.c::remove_some_program_points_and_update_live_ranges too.
I agree with Steven, this patch seems to be fixing the symptom, not
the problem. Please re-consider if Steven's patch is a better
solution.
Thanks, David
next reply other threads:[~2012-12-05 19:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-05 19:36 David Edelsohn [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-12-05 18:13 Aldy Hernandez
2012-12-05 18:25 ` Aldy Hernandez
2012-12-05 18:26 ` Steven Bosscher
2012-12-05 18:48 ` Vladimir Makarov
2012-12-05 19:11 ` Steven Bosscher
2012-12-05 19:15 ` Steven Bosscher
2012-12-05 19:33 ` Vladimir Makarov
2012-12-05 20:47 ` Aldy Hernandez
2012-12-05 23:58 ` Steven Bosscher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGWvnynUY-1WTO4t8+Er-jUo31-V1CGs6qT4zEM1Z_9eq70v+A@mail.gmail.com \
--to=dje.gcc@gmail.com \
--cc=aldyh@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=stevenb.gcc@gmail.com \
--cc=vmakarov@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).