From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-453874-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 100733 invoked by alias); 17 May 2017 13:41:53 -0000
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
Received: (qmail 100658 invoked by uid 89); 17 May 2017 13:41:48 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=Hx-languages-length:532, H*i:sk:B37989F
X-HELO: mail-qt0-f170.google.com
Received: from mail-qt0-f170.google.com (HELO mail-qt0-f170.google.com) (209.85.216.170) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 17 May 2017 13:41:46 +0000
Received: by mail-qt0-f170.google.com with SMTP id c13so9475816qtc.1        for <gcc-patches@gcc.gnu.org>; Wed, 17 May 2017 06:41:49 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;        d=1e100.net; s=20161025;        h=x-gm-message-state:mime-version:in-reply-to:references:from:date         :message-id:subject:to:cc;        bh=B1T9cMqYu+j4Dt/2FYfnZhyfKitVBBRhjiy+qJWMwuU=;        b=XS4PVr3K1tnw5EcSlHOSQNV28bXKDsQ3pp3JZ7KvryxpYhWbQ7D0OL72yS8Y/+s1eE         GtK5q6NLliqMJd/bXhYDbX1Ni/kk1GIHMttNjvUTd4hhqzv8Gt0WtmOXs5ZVkTD+C4M5         24i+Qzw1BHJ7990Hw85RTyZmU2YdXEBlGWS995fmM+nS9IkMXMZUpv3d6g30LuraCRsZ         g6EFkgDW6kYzTo2yUtNMf3LMT6IVLe/3QLs4Jy2bHYiEzFv1J+XOzpE7d5P1xfUd3Rtu         j2Ff+5VkP3vCJhkRh/5BYMsKcOMd/AOfyfFi6CY4fQjQy5FwacXHCsiTX1it8v4tvVDB         1TSQ==
X-Gm-Message-State: AODbwcAG3jNdkitwWbUqF+lhW+h8kEmb104YLVfKQ3qeR22MWXKjusBO	4DnZU61st26IJTtMEYhAPubj1OmU8w==
X-Received: by 10.200.34.98 with SMTP id p31mr3042734qtp.2.1495028508257; Wed, 17 May 2017 06:41:48 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.12.185.172 with HTTP; Wed, 17 May 2017 06:41:47 -0700 (PDT)
In-Reply-To: <B37989F2852398498001550C29155BE5CD3EAA@FRCRPVV9EX3MSX.ww931.my-it-solutions.net>
References: <CAGWvnykvG9EPpknB-SozMknjN5f+BCh3aBoPzpj6vyebG-ruVw@mail.gmail.com> <B37989F2852398498001550C29155BE5CD3A8C@FRCRPVV9EX3MSX.ww931.my-it-solutions.net> <CAGWvny=USjCFdQLWgqjiwnkV60YZ_cqJ3SPxp5dhphatYXi40w@mail.gmail.com> <B37989F2852398498001550C29155BE5CD3E92@FRCRPVV9EX3MSX.ww931.my-it-solutions.net> <B37989F2852398498001550C29155BE5CD3EAA@FRCRPVV9EX3MSX.ww931.my-it-solutions.net>
From: David Edelsohn <dje.gcc@gmail.com>
Date: Wed, 17 May 2017 13:46:00 -0000
Message-ID: <CAGWvnyngA86+j4zGx+4z2iXMybj+hnYxtz7ai9+LUdVscJaPHg@mail.gmail.com>
Subject: Re: [PATCH,AIX] Enable FFI Go Closure on AIX
To: "REIX, Tony" <tony.reix@atos.net>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>, 	"SARTER, MATTHIEU (ext)" <matthieu.sarter.external@atos.net>
Content-Type: text/plain; charset="UTF-8"
X-SW-Source: 2017-05/txt/msg01384.txt.bz2

On Wed, May 17, 2017 at 9:11 AM, REIX, Tony <tony.reix@atos.net> wrote:
> Patch has been submitted to libffi github : https://github.com/libffi/libffi/pull/308 .

Good.

There still was no ChangeLog included with the patch.

Also, the new functions in the patch are not consistent with the
insertion of the word "go".  Sometimes it is near the end, like
ffi_call_go_AIX, and sometimes it is near the beginning, like
ffi_go_closure_DARWIN.  The naming should be consistent.

Thanks, David