public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: David Edelsohn <dje.gcc@gmail.com>
To: wangfeng@eswincomputing.com
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH v3] RISC-V:Optimize the MASK opt generation
Date: Mon, 2 Oct 2023 13:20:34 -0400	[thread overview]
Message-ID: <CAGWvnyngc83bjaKXXDfOqp7H+sYW-0Qcf9TDCkCyBkWZ6aS5QA@mail.gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 516 bytes --]

Wang,

The AWK portions of this patch broke bootstrap on AIX.

Also, the AWK portions are common code, not RISC-V specific.  I don't see
anywhere that the common portions of the patch were reviewed or approved by
anyone with authority to approve the changes to the AWK files.

This patch should not have been committed without approval by a reviewer
with authority for that portion of the compiler and should have been tested
on targets other than RISC-V if common parts of the compiler were changed.

Thanks, David

             reply	other threads:[~2023-10-02 17:20 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-02 17:20 David Edelsohn [this message]
2023-10-02 17:58 ` Jeff Law
2023-10-02 18:03   ` David Edelsohn
2023-10-02 18:06     ` Jeff Law
2023-10-03  2:38       ` Kito Cheng
2023-10-03 13:22         ` David Edelsohn
2023-10-03 16:55         ` Jeff Law
2023-10-07  1:00         ` Feng Wang
  -- strict thread matches above, loose matches on Subject: below --
2023-09-06  2:02 Feng Wang
2023-09-06  3:42 ` Kito Cheng
2023-09-07  0:48 ` Tsukasa OI

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAGWvnyngc83bjaKXXDfOqp7H+sYW-0Qcf9TDCkCyBkWZ6aS5QA@mail.gmail.com \
    --to=dje.gcc@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=wangfeng@eswincomputing.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).