From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-413284-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 114348 invoked by alias); 9 Nov 2015 16:14:35 -0000
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
Received: (qmail 114335 invoked by uid 89); 9 Nov 2015 16:14:34 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.2 required=5.0 tests=AWL,BAYES_20,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2
X-HELO: mail-lb0-f182.google.com
Received: from mail-lb0-f182.google.com (HELO mail-lb0-f182.google.com) (209.85.217.182) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Mon, 09 Nov 2015 16:14:33 +0000
Received: by lbblt2 with SMTP id lt2so83272965lbb.3        for <gcc-patches@gcc.gnu.org>; Mon, 09 Nov 2015 08:14:30 -0800 (PST)
MIME-Version: 1.0
X-Received: by 10.112.13.98 with SMTP id g2mr13928651lbc.18.1447085670045; Mon, 09 Nov 2015 08:14:30 -0800 (PST)
Received: by 10.114.71.114 with HTTP; Mon, 9 Nov 2015 08:14:29 -0800 (PST)
In-Reply-To: <20151109003616.GB17170@ibm-tiger.the-meissners.org>
References: <20151103202911.GA5304@ibm-tiger.the-meissners.org>	<20151109003616.GB17170@ibm-tiger.the-meissners.org>
Date: Mon, 09 Nov 2015 16:14:00 -0000
Message-ID: <CAGWvnyni0G_R9YfuQXysB0o1JvVc7EKP=p_4hzDp9czEkffdhw@mail.gmail.com>
Subject: Re: [PATCH], Add power9 support to GCC, patch #2 (add modulus instructions)
From: David Edelsohn <dje.gcc@gmail.com>
To: Michael Meissner <meissner@linux.vnet.ibm.com>, GCC Patches <gcc-patches@gcc.gnu.org>
Content-Type: text/plain; charset=UTF-8
X-SW-Source: 2015-11/txt/msg01000.txt.bz2

On Sun, Nov 8, 2015 at 4:36 PM, Michael Meissner
<meissner@linux.vnet.ibm.com> wrote:
> This is patch #2.  It adds support for the new modulus instructions that are
> being added in ISA 3.0 (power9):
>
> I have built this patch (along with patches #3 and #4) with a bootstrap build
> on a power8 little endian system.  There were no regressions in the test
> suite.  Is this patch ok to install in the trunk once patch #1 has been
> installed.
>
> [gcc]
> 2015-11-08  Michael Meissner  <meissner@linux.vnet.ibm.com>
>
>         * config/rs6000/rs6000.c (rs6000_rtx_costs): Update costs for
>         modulus instructions if we have hardware support.
>
>         * config/rs6000/rs6000.md (mod<mode>3): Add support for ISA 3.0
>         modulus instructions.
>         (umod<mode>3): Likewise.
>         (divmod peephole): Likewise.
>         (udivmod peephole): Likewise.
>
> [gcc/testsuite]
> 2015-11-08  Michael Meissner  <meissner@linux.vnet.ibm.com>
>
>         * lib/target-supports.exp (check_p9vector_hw_available): Add
>         checks for power9 availability.
>         (check_effective_target_powerpc_p9vector_ok): Likewise.
>         (check_vect_support_and_set_flags): Likewise.
>
>         * gcc.target/powerpc/mod-1.c: New test.
>         * gcc.target/powerpc/mod-2.c: Likewise.

This is okay, but let's wait for revised #3 since you tested 2, 3, 4 together.

Thanks, David