From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ua1-x933.google.com (mail-ua1-x933.google.com [IPv6:2607:f8b0:4864:20::933]) by sourceware.org (Postfix) with ESMTPS id 091CE3858C3A; Thu, 4 Nov 2021 01:59:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 091CE3858C3A Received: by mail-ua1-x933.google.com with SMTP id i6so8033939uae.6; Wed, 03 Nov 2021 18:59:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0xaS8Q8tj/79Rc5b6yE58TrRw4P6tcsVtMih+XC5d8w=; b=eNnh17kEmkDnT7zKqrfJRdSg1sfkKAksy0j0lMTR7ofi5M787gOoNOJ2MW4IywKvxo Th5gA+1897hyutWIjT53pSK0p25tbrUQGMiqCbRETuDZG4t1/PSm/n51wFcEOrIqagi5 eH70ObLCAUIMesL/HCw11SSWmD3gQDMZMrFwh1mFZFjBNIjgEY4wj1PRcZ9e4uFGN013 5UV6eVR5xSb349ytkGOZwp/uXK4wRt6fkMle7wXu7JQDJZKSVCuMUid/3Lfysy2sao6r sHsU5przev3LM21UWuIsaEM/v+oLNB00GxNLH06eMO9Vx2AmkNkaUhauJAhtW4YD5bpL ZQgw== X-Gm-Message-State: AOAM533pCH8tEo1+uc8kLNmF7LqYSa/ZPFk5gl3VKyOwIYxZk8AWf1Te vt7ylx8Yae5I6i7Ks4uwkl1MRViIYD44twc+Rn/92gUV X-Google-Smtp-Source: ABdhPJyjeKpJ2RlmHlkVHRQdhTYyBd7MzUK342NoBaSYCEEZoxi06/N+FP8AaYTX4sa6hONkcNweHMzg68cvBqXf+uE= X-Received: by 2002:a05:6102:a18:: with SMTP id t24mr44146580vsa.37.1635991159514; Wed, 03 Nov 2021 18:59:19 -0700 (PDT) MIME-Version: 1.0 References: <20211103133142.3797621-1-luoxhu@linux.ibm.com> In-Reply-To: From: David Edelsohn Date: Wed, 3 Nov 2021 21:59:08 -0400 Message-ID: Subject: Re: [PATCH] rs6000: Fix incorrect fusion constraint [PR102991] To: Xionghu Luo Cc: GCC Patches , Segher Boessenkool , Bill Schmidt , guojiufu , linkw@gcc.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Nov 2021 01:59:21 -0000 On Wed, Nov 3, 2021 at 9:46 PM Xionghu Luo wrote: > > On 2021/11/3 23:13, David Edelsohn wrote: > > Did you manually change fusion.md or did you regenerate it after > > fixing genfusion.pl? > > > > If you regenerated it, the ChangeLog entry should be "Regenerated" and > > the "Fix incorrect clobber constraint." should refer to the > > genfusion.pl change. > > > > I want to ensure that genfusion.pl generates the correct constraint > > the next time it is used. > > > > Aaron mentioned he disabled the auto generation here[1], but before > than that, Segher suggested to enable it in stage1. > > [1] https://gcc.gnu.org/pipermail/gcc-patches/2021-February/564652.html > [2] https://gcc.gnu.org/pipermail/gcc-patches/2021-January/564244.html > > > Thus re-enable it with the followed v2 patch(Confirmed the fusion.md is > exactly same with v1 patch.) > > > [PATCH v2] rs6000: Fix incorrect fusion constraint [PR102991] > > > gcc/ChangeLog: > > * config/rs6000/fusion.md: Regenerate. > * config/rs6000/genfusion.pl: Fix incorrect clobber constraint. > * config/rs6000/t-rs6000: Uncomment regeneration of fusion.md. I believe that there is some confusion about my request. I am not requesting that the patch enable genfusion.pl . The Makefile fragment rule to generate fusion.md is disabled for a reason and normally should not be enabled. But fusion.md should be generated by genfusion.pl when there is a change, and any changes should be made in genfusion.pl. In other words, change genfusion.pl, temporarily enable the Makefile fragment rule, generate fusion.md, disable genfusion.pl. My request was an effort to ensure that genfusion.pl correctly regenerates the new, corrected fusion.md file. I don't want a manual change to fusion.md that differs from the automatically generated file. Only the updated fusion.md and genfusion.pl should be checked in. Has Aaron reviewed and confirmed the change to genfusion.pl? Thanks, David