From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x52e.google.com (mail-ed1-x52e.google.com [IPv6:2a00:1450:4864:20::52e]) by sourceware.org (Postfix) with ESMTPS id CB0D53857724 for ; Wed, 18 Oct 2023 14:44:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CB0D53857724 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org CB0D53857724 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::52e ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697640288; cv=none; b=VTzb1Pv8E4BPTdMyu1HCGvMH+noSxJARtBeBOP9R/5uomE0USPgi0FNxhnGvfVVksxlXGfO01bTiXaOmBvODoSGRfMdgmzlIU+pZFKDGm3bihJlG5qeBL7gl37+QZIwusti+varRz3IZfNCGdazOASAiQHUAnJjz70wNPPKxYNc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697640288; c=relaxed/simple; bh=oQ+q4glG66lHIKoyvSnC9tMOX8AOS94UuxNZbR+Mvgc=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=jwZefaTBP2pz7heobc+lxhamvZKzlKMLZ++apNJ/I3Cd5h36VKuX7EDG6nHQt+vNYL1AFzD/H1u5DQ8Rx30tM4bAeEHJ024J8phrTo3nHN4OdechDbIBbs0ftdJI7G89bPB7uIr7TNOUVH0UwgghV4ug7qKGJYKmgxlXMAiZjKs= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ed1-x52e.google.com with SMTP id 4fb4d7f45d1cf-522bd411679so11524930a12.0 for ; Wed, 18 Oct 2023 07:44:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697640284; x=1698245084; darn=gcc.gnu.org; h=cc:to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=71Tjbh50Eaxrn9KSv4JbNVkd9LKK/41Z6jvAGdfKb8k=; b=kfp1sVkWglPNyza+sAFDtTR0aoNsy2x1+v1Bb2UkRDjSsGeAH2ZAHfAwpgWgmqe6B+ YPckPWzturf040vWofvqSCnVmFxFLY7DMdZa+o3idbBFxup63NQpxyAabeIXFB2Uzfa4 lXZbf5Dh++ZO/FbMcyTJ+XZlx8rUMWp3vcO8AKwTvUJxsxTNA+0aiyKKie5iOk6e5Yt+ ac/rHxp8f6A5C9A8jHyr8u7uNatSxDQZL/47aqOKFFCW8HH8iXcPQyBh/Y+TYnWK/0qy kGIx4lVRAr1A+tUVnLJBRQmIeq+xf9VNSTihQFkD51ogYdG0m61J48eEZPFiG6p0IhZ3 RViA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697640284; x=1698245084; h=cc:to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=71Tjbh50Eaxrn9KSv4JbNVkd9LKK/41Z6jvAGdfKb8k=; b=EhGLCPsCMndC7Id+yCYHdIsYAYg+A3sSQG12BwvdwdBXJxeE4lnYMFw+wgp5xgl3nh g7R3jyWXHpxoFCWr5IwGx3ACl6CpPBBnjmoWQmFzMJIffvjT4h8k9dYWMwZS0eHTfF41 oSz7JXbBrzMuGc2BpA8R/C8KsHLzh/KBJ9QtBF//cTzac6M/OfYBZYCvbu3oYvZae47Q kgIFfvq7arSbtTZQ/0Myr55Z/ls2j0FeVhd6yz+HfTqGVNm3tHWMsBhn0UjyXDp3HuHY 19dOM+dWzgTY4xtQHvEKiNcXHrnGMdpUILAnTsgX33yNslQWE7wwbbith24wbggGLm65 oNWA== X-Gm-Message-State: AOJu0Yy2aM9G4RWvc6dq53F36X8rrtQRM5MJuccL+Qp7f8FEAvazPsg2 2AOCPkFHkDXUvobjEskr56797D2l9VveDk+F2cQ= X-Google-Smtp-Source: AGHT+IFPzKTKzSAYPVxejrHGDKtKIBFFEzZqmkyvS7yanZec/qVdbgkYlKjSrSiefYrnIOMXjKMX2eLMMB5Rm5UBVlA= X-Received: by 2002:a17:907:9348:b0:9bf:63b2:b6ee with SMTP id bv8-20020a170907934800b009bf63b2b6eemr4428448ejc.29.1697640284421; Wed, 18 Oct 2023 07:44:44 -0700 (PDT) MIME-Version: 1.0 From: David Edelsohn Date: Wed, 18 Oct 2023 10:44:32 -0400 Message-ID: Subject: Re: [PATCH v2] swap: Fix incorrect lane extraction by vec_extract() [PR106770] To: Surya Kumari Jangala , Segher Boessenkool Cc: GCC Patches Content-Type: multipart/alternative; boundary="0000000000001c03de0607feae53" X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --0000000000001c03de0607feae53 Content-Type: text/plain; charset="UTF-8" [Resending from correct email.] Hi, Surya Thanks for working on this issue and creating a patch. It helps if you explicitly send patches to Segher and me, and copy gcc-patches. +/* Return true if insn is a non-permuting load/store. */ +static bool +non_permuting_mem_insn (swap_web_entry *insn_entry, unsigned int i) +{ + return (insn_entry[i].special_handling == SH_NOSWAP_LD || + insn_entry[i].special_handling == SH_NOSWAP_ST); +} The logical operator || should be at the beginning of the line, not the end. That also ensures correct formatting and indentation. The || should be under the "i" of insn on the line above. It also generally simplifies review to have the ChangeLog in the same order as changes in the file. The order of the files relative to the patch may not be the same, but the ChangeLog entries should be in sequential order relative to the file. This patch is okay with the logical operator formatting change. Thanks, David --0000000000001c03de0607feae53--