From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 63495 invoked by alias); 28 Apr 2015 17:17:01 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 63449 invoked by uid 89); 28 Apr 2015 17:17:01 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-ie0-f180.google.com Received: from mail-ie0-f180.google.com (HELO mail-ie0-f180.google.com) (209.85.223.180) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Tue, 28 Apr 2015 17:16:56 +0000 Received: by iejt8 with SMTP id t8so23526544iej.2 for ; Tue, 28 Apr 2015 10:16:54 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.43.97.130 with SMTP id ck2mr19410080icc.91.1430241414516; Tue, 28 Apr 2015 10:16:54 -0700 (PDT) Received: by 10.36.108.21 with HTTP; Tue, 28 Apr 2015 10:16:54 -0700 (PDT) In-Reply-To: References: Date: Tue, 28 Apr 2015 17:33:00 -0000 Message-ID: Subject: Re: [PATCH] Fix size & type for cold partition names (hot-cold function partitioning) From: David Edelsohn To: Caroline Tice Cc: Jeffrey Law , GCC Patches Content-Type: text/plain; charset=ISO-8859-1 X-SW-Source: 2015-04/txt/msg01777.txt.bz2 I just committed the patch for Dominique. - David On Tue, Apr 28, 2015 at 1:12 PM, Caroline Tice wrote: > Yes, this is already mentioned in PR 65910 > (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65910). > > There is a patch mentioned in that PR that both appears to fix the > problem and appears to have been approved. I thought the author of > the patch would commit it, but that does not appear to have happened > yet. Should I go ahead and commit that patch, or should I wait for > the author to do that? > > -- Caroline Tice > cmtice@google.clom > > > On Tue, Apr 28, 2015 at 10:10 AM, David Edelsohn wrote: >> Caroline, >> >> Your patch has broken bootstrap on AIX and probably other platforms. >> >> /nasfarm/edelsohn/src/src/gcc/varasm.c: In function 'void >> assemble_end_function(tree, const char*)': >> /nasfarm/edelsohn/src/src/gcc/varasm.c:1870:12: error: >> 'ASM_DECLARE_FUNCTION_SIZE' was not declared in this scope >> decl); >> ^ >> >> You added a reference to ASM_DECLARE_FUNCTION_SIZE without guarding >> it, as was done only 10 lines higher in the same function. The macro >> is not declared for all targets. >> >> Also, the ChangeLog entry has numerous typos. >> >> Please fix ASAP. >> >> Thanks, David