public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: David Edelsohn <dje.gcc@gmail.com>
To: Alan Modra <amodra@gmail.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [RS6000] Weak functions may not be file local
Date: Tue, 01 Sep 2015 14:06:00 -0000	[thread overview]
Message-ID: <CAGWvnynnXVy3QZXsWx2zefvQY25i3UeEHtdqMRw=UV+5KSsDnQ@mail.gmail.com> (raw)
In-Reply-To: <20150901075113.GQ24814@bubble.grove.modra.org>

On Tue, Sep 1, 2015 at 3:51 AM, Alan Modra <amodra@gmail.com> wrote:
> A weak symbol defined in the current object file may not turn out to
> be the definition used at link time, if other copies of the symbol
> exist.  This means they can't be considered file local;  Calls to
> weak functions need a nop so that the linker can replace it with a toc
> restoring insn if the function uses a different toc pointer to its
> caller (for linker grouping of TOC into multiple sections).
>
> Bootstrapped and regression tested powerpc64-linux.  OK for active
> branches?
>
>         PR target/67417
>         * config/rs6000/predicates.md (current_file_function_operand): Don't
>         return true for weak symbols.
>         * config/rs6000/rs6000.c (rs6000_function_ok_for_sibcall): Likewise.

Okay.

Thanks, David

      reply	other threads:[~2015-09-01 14:06 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-01  7:51 Alan Modra
2015-09-01 14:06 ` David Edelsohn [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAGWvnynnXVy3QZXsWx2zefvQY25i3UeEHtdqMRw=UV+5KSsDnQ@mail.gmail.com' \
    --to=dje.gcc@gmail.com \
    --cc=amodra@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).