public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: David Edelsohn <dje.gcc@gmail.com>
To: Jonathan Wakely <jwakely@redhat.com>
Cc: "Arsen Arsenović" <arsen@aarsen.me>,
	"GCC Patches" <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH v2 1/2] libstdc++: Implement more maintainable <version> header
Date: Wed, 16 Aug 2023 18:36:00 -0400	[thread overview]
Message-ID: <CAGWvnynxS_6h72--qim-eJizAxPofweKT2ZTC9cRP2HX=GcncQ@mail.gmail.com> (raw)
In-Reply-To: <CACb0b4=UeH2wcf3OLFf2h1GR-PanL5wH8wUVpOpsi+e1-qKCVQ@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1116 bytes --]

Was the dependency added to the dependencies in contrib/gcc_update?
Otherwise the timestamp can get out of sync in a Git checkout.

Thanks, David


On Wed, Aug 16, 2023 at 6:20 PM Jonathan Wakely <jwakely@redhat.com> wrote:

> On Wed, 16 Aug 2023 at 22:56, Jonathan Wakely <jwakely@redhat.com> wrote:
> >
> > On Wed, 16 Aug 2023 at 22:39, David Edelsohn <dje.gcc@gmail.com> wrote:
> > >
> > > Hi, Arsen
> > >
> > > This patch broke bootstrap because it has introduced a new GCC build
> requirement for autogen that is not a previous requirement to build GCC.
> Previously the repository has included post-processed files.
> >
> > The repo does include the generated bits/version.h file. autogen
> > should only be needed if you modify version.dep
>
> And I've just checked again with an x86_64-pc-linux-gnu bootstrap on a
> box without autogen, and it worked.
>
> >
> > >
> > > +# AutoGen <bits/version.h>.
> > > +.PHONY: update-version
> > > +update-version:
> > > + cd ${bits_srcdir} && \
> > > + autogen version.def
> > > +
> > >
> > >
> > > Thanks, David
> > >
> > >
>
>

  reply	other threads:[~2023-08-16 22:36 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-16 21:38 David Edelsohn
2023-08-16 21:56 ` Jonathan Wakely
2023-08-16 22:20   ` Jonathan Wakely
2023-08-16 22:36     ` David Edelsohn [this message]
2023-08-16 22:38       ` Andrew Pinski
  -- strict thread matches above, loose matches on Subject: below --
2023-08-13 19:35 Arsen Arsenović
2023-08-14 15:18 ` Arsen Arsenović
2023-08-16 11:15 ` Jonathan Wakely

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAGWvnynxS_6h72--qim-eJizAxPofweKT2ZTC9cRP2HX=GcncQ@mail.gmail.com' \
    --to=dje.gcc@gmail.com \
    --cc=arsen@aarsen.me \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jwakely@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).