* Re: [PATCH 1/2] PowerPC testsuite clean up
@ 2013-02-06 22:19 David Edelsohn
2013-02-08 22:06 ` Peter Bergner
0 siblings, 1 reply; 8+ messages in thread
From: David Edelsohn @ 2013-02-06 22:19 UTC (permalink / raw)
To: Sebastian Huber, Peter Bergner; +Cc: GCC Patches, Mike Stump
Because Peter Bergner most recently worked on embedded PPC targets, I
had asked him to double-check the patch before approving it.
Hopefully he will give me some feedback soon.
Thanks, David
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] PowerPC testsuite clean up
2013-02-06 22:19 [PATCH 1/2] PowerPC testsuite clean up David Edelsohn
@ 2013-02-08 22:06 ` Peter Bergner
2013-02-09 0:07 ` David Edelsohn
0 siblings, 1 reply; 8+ messages in thread
From: Peter Bergner @ 2013-02-08 22:06 UTC (permalink / raw)
To: David Edelsohn; +Cc: Sebastian Huber, GCC Patches, Mike Stump
On Wed, 2013-02-06 at 17:19 -0500, David Edelsohn wrote:
> Because Peter Bergner most recently worked on embedded PPC targets, I
> had asked him to double-check the patch before approving it.
> Hopefully he will give me some feedback soon.
I've had a look at the patch and it looks good to me.
I also gave it a spin through a powerpc64-linux build and
testsuite run just to make sure nothing unexpectedly popped
out and nothing did. So I'm fine with the patch.
Peter
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] PowerPC testsuite clean up
2013-02-08 22:06 ` Peter Bergner
@ 2013-02-09 0:07 ` David Edelsohn
2013-02-11 7:56 ` Sebastian Huber
0 siblings, 1 reply; 8+ messages in thread
From: David Edelsohn @ 2013-02-09 0:07 UTC (permalink / raw)
To: Peter Bergner, Sebastian Huber; +Cc: GCC Patches, Mike Stump
On Fri, Feb 8, 2013 at 5:05 PM, Peter Bergner <bergner@vnet.ibm.com> wrote:
> On Wed, 2013-02-06 at 17:19 -0500, David Edelsohn wrote:
>> Because Peter Bergner most recently worked on embedded PPC targets, I
>> had asked him to double-check the patch before approving it.
>> Hopefully he will give me some feedback soon.
>
> I've had a look at the patch and it looks good to me.
> I also gave it a spin through a powerpc64-linux build and
> testsuite run just to make sure nothing unexpectedly popped
> out and nothing did. So I'm fine with the patch.
Sebastian,
The patches are okay.
Are you able to check them in?
Thanks, David
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] PowerPC testsuite clean up
2013-02-09 0:07 ` David Edelsohn
@ 2013-02-11 7:56 ` Sebastian Huber
0 siblings, 0 replies; 8+ messages in thread
From: Sebastian Huber @ 2013-02-11 7:56 UTC (permalink / raw)
To: David Edelsohn; +Cc: Peter Bergner, GCC Patches, Mike Stump
On 02/09/2013 01:07 AM, David Edelsohn wrote:
> On Fri, Feb 8, 2013 at 5:05 PM, Peter Bergner <bergner@vnet.ibm.com> wrote:
>> On Wed, 2013-02-06 at 17:19 -0500, David Edelsohn wrote:
>>> Because Peter Bergner most recently worked on embedded PPC targets, I
>>> had asked him to double-check the patch before approving it.
>>> Hopefully he will give me some feedback soon.
>>
>> I've had a look at the patch and it looks good to me.
>> I also gave it a spin through a powerpc64-linux build and
>> testsuite run just to make sure nothing unexpectedly popped
>> out and nothing did. So I'm fine with the patch.
>
> Sebastian,
>
> The patches are okay.
Thanks a lot for your reviews.
>
> Are you able to check them in?
I don't have commit access, but my company and I have signed the copyright
assignments regarding GCC with the FSF.
--
Sebastian Huber, embedded brains GmbH
Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone : +49 89 189 47 41-16
Fax : +49 89 189 47 41-09
E-Mail : sebastian.huber@embedded-brains.de
PGP : Public key available on request.
Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 1/2] PowerPC testsuite clean up
@ 2013-01-29 14:40 Sebastian Huber
2013-02-06 9:20 ` Sebastian Huber
0 siblings, 1 reply; 8+ messages in thread
From: Sebastian Huber @ 2013-01-29 14:40 UTC (permalink / raw)
To: gcc-patches; +Cc: Sebastian Huber
2013-01-18 Sebastian Huber <sebastian.huber@embedded-brains.de>
* lib/target-supports.exp
(check_effective_target_powerpc_eabi_ok): New.
* gcc.target/powerpc/ppc-eabi.c: Use require effective target
powerpc_eabi_ok.
* gcc.target/powerpc/ppc-sdata-1.c: Likewise.
* gcc.target/powerpc/spe-small-data-2.c: Likewise.
* gcc.target/powerpc/ppc-sdata-2.c: Add powerpc-*-rtems*.
* gcc.target/powerpc/pr51623.c: Likewise.
* gcc.target/powerpc/ppc-stackalign-1.c: Likewise.
* gcc.target/powerpc/ppc-ldstruct.c: Likewise.
* gcc.target/powerpc/spe-small-data-2.c: Do not run, compile
only.
---
gcc/testsuite/gcc.target/powerpc/ppc-eabi.c | 3 ++-
gcc/testsuite/gcc.target/powerpc/ppc-ldstruct.c | 2 +-
gcc/testsuite/gcc.target/powerpc/ppc-sdata-1.c | 3 ++-
gcc/testsuite/gcc.target/powerpc/ppc-sdata-2.c | 2 +-
.../gcc.target/powerpc/ppc-stackalign-1.c | 2 +-
gcc/testsuite/gcc.target/powerpc/pr51623.c | 2 +-
.../gcc.target/powerpc/spe-small-data-2.c | 3 ++-
gcc/testsuite/lib/target-supports.exp | 12 ++++++++++++
8 files changed, 22 insertions(+), 7 deletions(-)
diff --git a/gcc/testsuite/gcc.target/powerpc/ppc-eabi.c b/gcc/testsuite/gcc.target/powerpc/ppc-eabi.c
index 47ba1a7..cd15586 100644
--- a/gcc/testsuite/gcc.target/powerpc/ppc-eabi.c
+++ b/gcc/testsuite/gcc.target/powerpc/ppc-eabi.c
@@ -1,4 +1,5 @@
/* PR target/16952 */
-/* { dg-do compile { target { powerpc*-*-linux* && ilp32 } } } */
+/* { dg-do compile } */
+/* { dg-require-effective-target powerpc_eabi_ok } */
/* { dg-options "-meabi -mrelocatable" } */
char *s = "boo";
diff --git a/gcc/testsuite/gcc.target/powerpc/ppc-ldstruct.c b/gcc/testsuite/gcc.target/powerpc/ppc-ldstruct.c
index da6001f..ffb4264 100644
--- a/gcc/testsuite/gcc.target/powerpc/ppc-ldstruct.c
+++ b/gcc/testsuite/gcc.target/powerpc/ppc-ldstruct.c
@@ -1,4 +1,4 @@
-/* { dg-do run { target powerpc*-*-eabi* powerpc*-*-elf* powerpc*-*-linux* } } */
+/* { dg-do run { target powerpc*-*-eabi* powerpc*-*-elf* powerpc*-*-linux* powerpc*-*-rtems* } } */
/* { dg-options "-O -mlong-double-128" } */
#include <stdlib.h>
diff --git a/gcc/testsuite/gcc.target/powerpc/ppc-sdata-1.c b/gcc/testsuite/gcc.target/powerpc/ppc-sdata-1.c
index 5f39d86..efd5a5e 100644
--- a/gcc/testsuite/gcc.target/powerpc/ppc-sdata-1.c
+++ b/gcc/testsuite/gcc.target/powerpc/ppc-sdata-1.c
@@ -1,5 +1,6 @@
-/* { dg-do compile { target { { powerpc*-*-linux* && ilp32 } || { powerpc-*-eabi* } } } } */
+/* { dg-do compile } */
/* { dg-options "-O2 -fno-common -G 8 -meabi -msdata=eabi" } */
+/* { dg-require-effective-target powerpc_eabi_ok } */
/* { dg-require-effective-target nonpic } */
/* { dg-final { scan-assembler "\\.section\[ \t\]\\.sdata," } } */
/* { dg-final { scan-assembler "\\.section\[ \t\]\\.sdata2," } } */
diff --git a/gcc/testsuite/gcc.target/powerpc/ppc-sdata-2.c b/gcc/testsuite/gcc.target/powerpc/ppc-sdata-2.c
index f102b1d..570c81f 100644
--- a/gcc/testsuite/gcc.target/powerpc/ppc-sdata-2.c
+++ b/gcc/testsuite/gcc.target/powerpc/ppc-sdata-2.c
@@ -1,4 +1,4 @@
-/* { dg-do compile { target { { powerpc*-*-linux* && ilp32 } || { powerpc-*-eabi* } } } } */
+/* { dg-do compile { target { { powerpc*-*-linux* && ilp32 } || { powerpc-*-eabi* powerpc-*-rtems* } } } } */
/* { dg-options "-O2 -fno-common -G 8 -msdata=sysv" } */
/* { dg-require-effective-target nonpic } */
/* { dg-final { scan-assembler "\\.section\[ \t\]\\.sdata," } } */
diff --git a/gcc/testsuite/gcc.target/powerpc/ppc-stackalign-1.c b/gcc/testsuite/gcc.target/powerpc/ppc-stackalign-1.c
index 465fc41..59bd39f 100644
--- a/gcc/testsuite/gcc.target/powerpc/ppc-stackalign-1.c
+++ b/gcc/testsuite/gcc.target/powerpc/ppc-stackalign-1.c
@@ -1,4 +1,4 @@
-/* { dg-do run { target powerpc*-*-linux* powerpc*-*-eabi* } } */
+/* { dg-do run { target powerpc*-*-linux* powerpc*-*-eabi* powerpc-*-rtems* } } */
/* { dg-options {} } */
/* Test stack pointer alignment against variable alloca. */
diff --git a/gcc/testsuite/gcc.target/powerpc/pr51623.c b/gcc/testsuite/gcc.target/powerpc/pr51623.c
index 37b7d65..2ac118c 100644
--- a/gcc/testsuite/gcc.target/powerpc/pr51623.c
+++ b/gcc/testsuite/gcc.target/powerpc/pr51623.c
@@ -1,5 +1,5 @@
/* PR target/51623 */
-/* { dg-do compile { target { { powerpc*-*-linux* && ilp32 } || { powerpc-*-eabi* } } } } */
+/* { dg-do compile { target { { powerpc*-*-linux* && ilp32 } || { powerpc-*-eabi* powerpc-*-rtems* } } } } */
/* { dg-options "-mrelocatable -ffreestanding" } */
/* This generated an error, since the compiler was calling
diff --git a/gcc/testsuite/gcc.target/powerpc/spe-small-data-2.c b/gcc/testsuite/gcc.target/powerpc/spe-small-data-2.c
index 2a466e3..5354e49 100644
--- a/gcc/testsuite/gcc.target/powerpc/spe-small-data-2.c
+++ b/gcc/testsuite/gcc.target/powerpc/spe-small-data-2.c
@@ -1,5 +1,6 @@
/* Verify that we don't ICE trying to put float data in .sdata2. */
-/* { dg-do run { target { powerpc*-*-linux* && powerpc_spe } } } */
+/* { dg-do compile } */
+/* { dg-require-effective-target powerpc_eabi_ok } */
/* { dg-options "-msdata=eabi -mcall-eabi -G 8" } */
double x;
diff --git a/gcc/testsuite/lib/target-supports.exp b/gcc/testsuite/lib/target-supports.exp
index 8b2fa29..5c3d9cc 100644
--- a/gcc/testsuite/lib/target-supports.exp
+++ b/gcc/testsuite/lib/target-supports.exp
@@ -2605,6 +2605,18 @@ proc check_effective_target_arm_prefer_ldrd_strd { } {
} "-O2 -mthumb" ]
}
+# Return 1 if this is a PowerPC target supporting -meabi.
+
+proc check_effective_target_powerpc_eabi_ok { } {
+ if { [istarget powerpc*-*-*] } {
+ return [check_no_compiler_messages powerpc_eabi_ok object {
+ int dummy;
+ } "-meabi"]
+ } else {
+ return 0
+ }
+}
+
# Return 1 if this is a PowerPC target with floating-point registers.
proc check_effective_target_powerpc_fprs { } {
--
1.7.7
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] PowerPC testsuite clean up
2013-01-29 14:40 Sebastian Huber
@ 2013-02-06 9:20 ` Sebastian Huber
2013-02-06 20:44 ` Mike Stump
2013-02-06 20:53 ` Mike Stump
0 siblings, 2 replies; 8+ messages in thread
From: Sebastian Huber @ 2013-02-06 9:20 UTC (permalink / raw)
To: gcc-patches
Would someone mind having a look at this.
On 01/29/2013 03:38 PM, Sebastian Huber wrote:
> 2013-01-18 Sebastian Huber <sebastian.huber@embedded-brains.de>
>
> * lib/target-supports.exp
> (check_effective_target_powerpc_eabi_ok): New.
> * gcc.target/powerpc/ppc-eabi.c: Use require effective target
> powerpc_eabi_ok.
> * gcc.target/powerpc/ppc-sdata-1.c: Likewise.
> * gcc.target/powerpc/spe-small-data-2.c: Likewise.
> * gcc.target/powerpc/ppc-sdata-2.c: Add powerpc-*-rtems*.
> * gcc.target/powerpc/pr51623.c: Likewise.
> * gcc.target/powerpc/ppc-stackalign-1.c: Likewise.
> * gcc.target/powerpc/ppc-ldstruct.c: Likewise.
> * gcc.target/powerpc/spe-small-data-2.c: Do not run, compile
> only.
--
Sebastian Huber, embedded brains GmbH
Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone : +49 89 189 47 41-16
Fax : +49 89 189 47 41-09
E-Mail : sebastian.huber@embedded-brains.de
PGP : Public key available on request.
Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] PowerPC testsuite clean up
2013-02-06 9:20 ` Sebastian Huber
@ 2013-02-06 20:44 ` Mike Stump
2013-02-06 20:53 ` Mike Stump
1 sibling, 0 replies; 8+ messages in thread
From: Mike Stump @ 2013-02-06 20:44 UTC (permalink / raw)
To: Sebastian Huber; +Cc: gcc-patches
On Feb 6, 2013, at 1:20 AM, Sebastian Huber <sebastian.huber@embedded-brains.de> wrote:
> Would someone mind having a look at this.
GIven where we are in the release cycle, I'd prefer a ppc person to double check (by reviewing and approving). I don't see reason why it cannot be approved...
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] PowerPC testsuite clean up
2013-02-06 9:20 ` Sebastian Huber
2013-02-06 20:44 ` Mike Stump
@ 2013-02-06 20:53 ` Mike Stump
1 sibling, 0 replies; 8+ messages in thread
From: Mike Stump @ 2013-02-06 20:53 UTC (permalink / raw)
To: Sebastian Huber; +Cc: gcc-patches
On Feb 6, 2013, at 1:20 AM, Sebastian Huber <sebastian.huber@embedded-brains.de> wrote:
> Would someone mind having a look at this.
GIven where we are in the release cycle, I'd prefer a ppc person to double check (by reviewing and approving). I don't see reason why it cannot be approved…
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2013-02-11 7:56 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-02-06 22:19 [PATCH 1/2] PowerPC testsuite clean up David Edelsohn
2013-02-08 22:06 ` Peter Bergner
2013-02-09 0:07 ` David Edelsohn
2013-02-11 7:56 ` Sebastian Huber
-- strict thread matches above, loose matches on Subject: below --
2013-01-29 14:40 Sebastian Huber
2013-02-06 9:20 ` Sebastian Huber
2013-02-06 20:44 ` Mike Stump
2013-02-06 20:53 ` Mike Stump
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).