From: David Edelsohn <dje.gcc@gmail.com>
To: Michael Meissner <meissner@linux.ibm.com>,
GCC Patches <gcc-patches@gcc.gnu.org>,
Segher Boessenkool <segher@kernel.crashing.org>,
David Edelsohn <dje.gcc@gmail.com>,
Bill Schmidt <wschmidt@linux.ibm.com>,
Peter Bergner <bergner@linux.ibm.com>,
Will Schmidt <will_schmidt@vnet.ibm.com>
Subject: Re: [PATCH] Move xx* builtins to vsx.md.
Date: Wed, 18 Aug 2021 16:42:42 -0400 [thread overview]
Message-ID: <CAGWvnynz0p79udAsKwT8v0_yDs2qxWKV3qZYVwwrBkVzJGQgZA@mail.gmail.com> (raw)
In-Reply-To: <YRXy+PcqEiVKChb2@toto.the-meissners.org>
On Fri, Aug 13, 2021 at 12:20 AM Michael Meissner
<meissner@linux.ibm.com> wrote:
>
> Move xx* builtins to vsx.md.
>
> I originally posted this patch in May. It needed a slight tune up as the
> souces have changed, so I'm reposting it now.
>
> I noticed that the xx built-in functions (xxspltiw, xxspltidp, xxsplti32dx,
> xxeval, xxblend, and xxpermx) were all defined in altivec.md. However, since
> the XX instructions can take both traditional floating point and Altivec
> registers, these built-in functions should be in vsx.md.
>
> This patch just moves the insns from altivec.md to vsx.md.
>
> I also moved the VM3 mode iterator and VM3_char mode attribute from altivec.md
> to vsx.md, since the only use of these were for the XXBLEND insns.
>
> I have built little endian power9 compilers, little endian power10 compilers,
> and big endian power8 compilers with this patch applied, and there were no
> regressions. Can I apply this patch to the master branch?
>
> Note this patch assumes the previous patch:
>
> Fix xxeval predicates (PR 99921).
>
> has been applied.
>
> 2021-08-12 Michael Meissner <meissner@linux.ibm.com>
>
> gcc/
> * config/rs6000/altivec.md (UNSPEC_XXEVAL): Move to vsx.md.
> (UNSPEC_XXSPLTIW): Move to vsx.md.
> (UNSPEC_XXSPLTID): Move to vsx.md.
> (UNSPEC_XXSPLTI32DX): Move to vsx.md.
> (UNSPEC_XXBLEND): Move to vsx.md.
> (UNSPEC_XXPERMX): Move to vsx.md.
> (VM3): Move to vsx.md.
> (VM3_char): Move to vsx.md.
> (xxspltiw_v4si): Move to vsx.md.
> (xxspltiw_v4sf): Move to vsx.md.
> (xxspltiw_v4sf_inst): Move to vsx.md.
> (xxspltidp_v2df): Move to vsx.md.
> (xxspltidp_v2df_inst): Move to vsx.md.
> (xxsplti32dx_v4si_inst): Move to vsx.md.
> (xxsplti32dx_v4sf): Move to vsx.md.
> (xxsplti32dx_v4sf_inst): Move to vsx.md.
> (xxblend_<mode>): Move to vsx.md.
> (xxpermx): Move to vsx.md.
> (xxpermx_inst): Move to vsx.md.
> * config/rs6000/vsx.md (UNSPEC_XXEVAL): Move from altivec.md.
> (UNSPEC_XXSPLTIW): Move from altivec.md.
> (UNSPEC_XXSPLTID): Move from altivec.md.
> (UNSPEC_XXSPLTI32DX): Move from altivec.md.
> (UNSPEC_XXBLEND): Move from altivec.md.
> (UNSPEC_XXPERMX): Move from altivec.md.
> (VM3): Move from altivec.md.
> (VM3_char): Move from altivec.md.
> (xxspltiw_v4si): Move from altivec.md.
> (xxspltiw_v4sf): Move from altivec.md.
> (xxspltiw_v4sf_inst): Move from altivec.md.
> (xxspltidp_v2df): Move from altivec.md.
> (xxspltidp_v2df_inst): Move from altivec.md.
> (xxsplti32dx_v4si_inst): Move from altivec.md.
> (xxsplti32dx_v4sf): Move from altivec.md.
> (xxsplti32dx_v4sf_inst): Move from altivec.md.
> (xxblend_<mode>): Move from altivec.md.
> (xxpermx): Move from altivec.md.
> (xxpermx_inst): Move from altivec.md
Okay.
I wanted to give Segher a chance to comment on the structure.
You could have used "Same" or "Likewise" in the ChangeLog, but that's fine.
Thanks, David
next prev parent reply other threads:[~2021-08-18 20:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-13 4:20 Michael Meissner
2021-08-18 20:01 ` Bill Schmidt
2021-08-18 20:42 ` David Edelsohn [this message]
2021-08-18 23:11 ` Segher Boessenkool
2021-08-19 22:10 ` Michael Meissner
2021-08-19 22:18 ` Segher Boessenkool
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGWvnynz0p79udAsKwT8v0_yDs2qxWKV3qZYVwwrBkVzJGQgZA@mail.gmail.com \
--to=dje.gcc@gmail.com \
--cc=bergner@linux.ibm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=meissner@linux.ibm.com \
--cc=segher@kernel.crashing.org \
--cc=will_schmidt@vnet.ibm.com \
--cc=wschmidt@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).