From: Yeting Kuo <fakepaper56@gmail.com>
To: Kito Cheng <kito.cheng@gmail.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: RISC-V: fix a typo in riscv.h
Date: Mon, 14 Sep 2020 19:06:26 +0800 [thread overview]
Message-ID: <CAGhUdNiMpvedJGpT2=bLvj8tmJENLm-QU4o9txB9NSDNgzL-Uw@mail.gmail.com> (raw)
In-Reply-To: <CA+yXCZB4BBO8f1Na_zaDPee03r3321ZOr70kk2PyFj6ZcP8GoA@mail.gmail.com>
Hi Kito,
> > Could you provide a test case for that?
>
I add the test case and update the git message.
RISC-V: fix a typo in riscv.h
The missing parentheses would make shorten-memrefs pass give a
wrong base when the offset of load/store is not multiple of 4.
2020-09-14 Yeting Kuo <fakepaper56@gmail.com>
gcc/ChangeLog:
* config/riscv/riscv.h
gcc/testsuite/ChangeLog:
* gcc.target/riscv/shorten-memrefs-8.c: New test.
diff --git a/gcc/config/riscv/riscv.h b/gcc/config/riscv/riscv.h
index 9f67d82e74e..b7b4a1c88a5 100644
--- a/gcc/config/riscv/riscv.h
+++ b/gcc/config/riscv/riscv.h
@@ -941,7 +941,7 @@ extern unsigned riscv_stack_boundary;
/* This is the maximum value that can be represented in a compressed
load/store
offset (an unsigned 5-bit value scaled by 4). */
-#define CSW_MAX_OFFSET ((4LL << C_S_BITS) - 1) & ~3
+#define CSW_MAX_OFFSET (((4LL << C_S_BITS) - 1) & ~3)
/* Called from RISCV_REORG, this is defined in riscv-sr.c. */
diff --git a/gcc/testsuite/gcc.target/riscv/shorten-memrefs-8.c
b/gcc/testsuite/gcc.target/riscv/shorten-memrefs-8.c
new file mode 100644
index 00000000000..f7428bd86cb
--- /dev/null
+++ b/gcc/testsuite/gcc.target/riscv/shorten-memrefs-8.c
@@ -0,0 +1,26 @@
+/* { dg-options "-Os -march=rv32imc -mabi=ilp32" } */
+
+/* shorten_memrefs should use a correct base address*/
+
+void
+store (char *p, int k)
+{
+ *(int *)(p + 17) = k;
+ *(int *)(p + 21) = k;
+ *(int *)(p + 25) = k;
+ *(int *)(p + 29) = k;
+}
+
+int
+load (char *p)
+{
+ int a = 0;
+ a += *(int *)(p + 17);
+ a += *(int *)(p + 21);
+ a += *(int *)(p + 25);
+ a += *(int *)(p + 29);
+ return a;
+}
+
+/* { dg-final { scan-assembler "store:\n\taddi\ta\[0-7\],a\[0-7\],1" } } */
+/* { dg-final { scan-assembler "load:\n\taddi\ta\[0-7\],a\[0-7\],1" } } */
Thanks,
Yeting
next prev parent reply other threads:[~2020-09-14 11:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-14 7:15 Yeting Kuo
2020-09-14 7:19 ` Kito Cheng
2020-09-14 11:06 ` Yeting Kuo [this message]
2020-09-17 21:30 ` Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGhUdNiMpvedJGpT2=bLvj8tmJENLm-QU4o9txB9NSDNgzL-Uw@mail.gmail.com' \
--to=fakepaper56@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=kito.cheng@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).