From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6618 invoked by alias); 19 Dec 2012 23:59:53 -0000 Received: (qmail 6601 invoked by uid 22791); 19 Dec 2012 23:59:52 -0000 X-SWARE-Spam-Status: No, hits=-4.8 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE X-Spam-Check-By: sourceware.org Received: from mail-vb0-f52.google.com (HELO mail-vb0-f52.google.com) (209.85.212.52) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 19 Dec 2012 23:59:48 +0000 Received: by mail-vb0-f52.google.com with SMTP id ez10so2993246vbb.25 for ; Wed, 19 Dec 2012 15:59:47 -0800 (PST) MIME-Version: 1.0 Received: by 10.52.97.104 with SMTP id dz8mr10184175vdb.21.1355961587854; Wed, 19 Dec 2012 15:59:47 -0800 (PST) Received: by 10.220.241.212 with HTTP; Wed, 19 Dec 2012 15:59:47 -0800 (PST) In-Reply-To: <50D24DEB.9090802@net-b.de> References: <50D24DEB.9090802@net-b.de> Date: Wed, 19 Dec 2012 23:59:00 -0000 Message-ID: Subject: Re: [Patch, Fortran] PR54818 - Fix ICE with TRANSFER to char From: Paul Richard Thomas To: Tobias Burnus Cc: gcc patches , gfortran Content-Type: text/plain; charset=ISO-8859-1 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2012-12/txt/msg01216.txt.bz2 Dear Tobias, OK for trunk, apart from: s/the string length if of type gfc_charlen_type_node/the string length is of type gfc_charlen_type_node/ Thanks for the patch Paul On 20 December 2012 00:29, Tobias Burnus wrote: > TRANSFER(..., "string") created on x86-64 an integer(8) string length; that > lead to a tree-checking ICE but also might pass the wrong type in 'call > sub(transfer(233," ")'. > > Build and regtested on x86-64-gnu-linux. > OK for the trunk? > > Tobias -- The knack of flying is learning how to throw yourself at the ground and miss. --Hitchhikers Guide to the Galaxy