* [Patch, fortran] PR67779 - Strange ordering with strings in extended object
@ 2016-01-10 13:03 Paul Richard Thomas
2016-01-10 13:14 ` Paul Richard Thomas
0 siblings, 1 reply; 2+ messages in thread
From: Paul Richard Thomas @ 2016-01-10 13:03 UTC (permalink / raw)
To: Arjen Markus, fortran, gcc-patches
Dear All,
I had already posted a patch for the above, which sets the offset
correctly in the caller to gfc_conv_expr_descriptor. However, I was so
concerned that the latter was not doing the job properly that I
decided to investigate further. The result was that I found a
completely trivial omission in the condition for the calculation of
'base', which meant that the wrong branch was taken and the offset
incorrectly calculated.
Committed as 'obvious' (well... it took a while but is obvious now I
see it!) in revision 232200.
Thanks for the report, Arjen.
Paul
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [Patch, fortran] PR67779 - Strange ordering with strings in extended object
2016-01-10 13:03 [Patch, fortran] PR67779 - Strange ordering with strings in extended object Paul Richard Thomas
@ 2016-01-10 13:14 ` Paul Richard Thomas
0 siblings, 0 replies; 2+ messages in thread
From: Paul Richard Thomas @ 2016-01-10 13:14 UTC (permalink / raw)
To: Arjen Markus, fortran, gcc-patches
Dear All,
The patch applies cleanly to 5-branch and fixes the problem. I will
commit it later on today, at the same time as the first batch of
deferred character fixes unless there are any objections.
Cheers
Paul
On 10 January 2016 at 14:02, Paul Richard Thomas
<paul.richard.thomas@gmail.com> wrote:
> Dear All,
>
> I had already posted a patch for the above, which sets the offset
> correctly in the caller to gfc_conv_expr_descriptor. However, I was so
> concerned that the latter was not doing the job properly that I
> decided to investigate further. The result was that I found a
> completely trivial omission in the condition for the calculation of
> 'base', which meant that the wrong branch was taken and the offset
> incorrectly calculated.
>
> Committed as 'obvious' (well... it took a while but is obvious now I
> see it!) in revision 232200.
>
> Thanks for the report, Arjen.
>
> Paul
--
The difference between genius and stupidity is; genius has its limits.
Albert Einstein
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-01-10 13:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-01-10 13:03 [Patch, fortran] PR67779 - Strange ordering with strings in extended object Paul Richard Thomas
2016-01-10 13:14 ` Paul Richard Thomas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).