From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x629.google.com (mail-pl1-x629.google.com [IPv6:2607:f8b0:4864:20::629]) by sourceware.org (Postfix) with ESMTPS id 362143858D35; Sun, 19 Mar 2023 12:04:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 362143858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pl1-x629.google.com with SMTP id o2so2354114plg.4; Sun, 19 Mar 2023 05:04:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679227476; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=tCWyHYyHi44U2IzIUStdlrJBMpFqgYMStf1v9rHv9MU=; b=UxNzuBZjTCBiihTTqZO2JOEQCyYlMvE+WTUpcs/wGuMJpa6v+w10TrnIjl0N+w3ZoP bN5lBIjpcETqBeREenCT0ppM8LohQUEn/qjNHC2ngOeSU3K20d33OvYso5hMylWp9d/w k0FiYv359vWw4sU4ofL/SN7X6B39IfiHvolzrM6zM3jP9EXxrnT1TM/1TKR2T7BjxmYA /2xDqnA2GPZl7bjH+frDvP3/e96SrqvNzILEtxQDTI5r9OTsXJm4S80coKL2wQlMEjqc lMymdnSMv8wDtgy5AH6CVhDbNQ4pqf6Dg6BC9keEFFt4BKz+ZujTaPHVoFDJRUyK3Ztu KMNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679227476; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=tCWyHYyHi44U2IzIUStdlrJBMpFqgYMStf1v9rHv9MU=; b=QlkuO6ilOXaRWV1Jb9MmZd3uxAdP6fwJ3e4Bc1iMxdD6fO7tjzCjY37tzJOtL+8NN6 SF3kcQ+YKO+wthTNKEpYSJ+jGILyD+zrYWYQ/6VBEbvdc61Au81+T6IlyfhssY/VJLMy MVH5DCxykGysDwO794LCcVm8OBELaRDOo1khyHD9zmk22XrizZ/0D0Cmj+zWAcOswVor 8mtu5SAIx45APfhtm+LpALmFZP+PqKOxIDvuvdAFqjinL8mL/drX0GmGXEiaojwDW4mW TCjNqugNLUcTLU4MY6NxdpDIKMonhwG7yq4QGCmn4rb4PxKQLusOzbZzfLH2MEtnNzn7 HVQA== X-Gm-Message-State: AO0yUKU8EV5HV9GnnGFyjlMWvipRVWXWD7mNSWptTvnJCKRBezZZHFWl UjCcWO/7petZuI5aKkkbCq1eAq3472McXJt4IWad+/GMaZM= X-Google-Smtp-Source: AK7set/066SQktFuHVBCGqL/2PiL+65PmM4dWZOFynq7J54FjurJYrSzjrfbs23Bbt3z4MY2+02E+TjiArOFyl+M/AI= X-Received: by 2002:a17:90a:d596:b0:23d:2000:ccd6 with SMTP id v22-20020a17090ad59600b0023d2000ccd6mr3718347pju.2.1679227476520; Sun, 19 Mar 2023 05:04:36 -0700 (PDT) MIME-Version: 1.0 From: Paul Richard Thomas Date: Sun, 19 Mar 2023 12:04:25 +0000 Message-ID: Subject: [Patch, fortran] PR87127 - External function not recognised from within an associate block To: "fortran@gcc.gnu.org" , gcc-patches Content-Type: multipart/mixed; boundary="0000000000003c578105f73f9d8e" X-Spam-Status: No, score=-7.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --0000000000003c578105f73f9d8e Content-Type: multipart/alternative; boundary="0000000000003c577f05f73f9d8c" --0000000000003c577f05f73f9d8c Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi All, I committed this to 8-branch on 2019-04-24 but not to 9-branch. I have no record of why I did this. The patch now requires an additional line, && sym->ns->proc_name->attr.proc !=3D PROC_MODULE to prevent the error message in pr88376.f90 from changing to the less helpful Error: Specification function =E2=80=98n=E2=80=99 at (1) must be PURE I propose to commit to mainline and backport to 12-branch unless there are objections in the next 24 hours. Cheers Paul Fortran: Recognise external function from within an associate block that has not been declared as external [PR87127] 2023-03-19 Paul Thomas gcc/fortran PR fortran/87127 * resolve.cc (check_host_association): If an external function is typed but not declared explicitly to be external, change the old symbol from a variable to an external function. gcc/testsuite/ PR fortran/87127 * gfortran.dg/external_procedures_4.f90: New test. --0000000000003c577f05f73f9d8c-- --0000000000003c578105f73f9d8e Content-Type: text/x-patch; charset="US-ASCII"; name="submit.diff" Content-Disposition: attachment; filename="submit.diff" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lffcbmkk0 ZGlmZiAtLWdpdCBhL2djYy9mb3J0cmFuL3Jlc29sdmUuY2MgYi9nY2MvZm9y dHJhbi9yZXNvbHZlLmNjCmluZGV4IGJhNjAzYjRjNDA3Li5hOTQ3ZjkwOGVj ZSAxMDA2NDQKLS0tIGEvZ2NjL2ZvcnRyYW4vcmVzb2x2ZS5jYworKysgYi9n Y2MvZm9ydHJhbi9yZXNvbHZlLmNjCkBAIC02MDc5LDExICs2MDc5LDE0IEBA IHJlc29sdmVfcHJvY2VkdXJlOgogCiAKIC8qIENoZWNrcyB0byBzZWUgdGhh dCB0aGUgY29ycmVjdCBzeW1ib2wgaGFzIGJlZW4gaG9zdCBhc3NvY2lhdGVk LgotICAgVGhlIG9ubHkgc2l0dWF0aW9uIHdoZXJlIHRoaXMgYXJpc2VzIGlz IHRoYXQgaW4gd2hpY2ggYSB0d2ljZQotICAgY29udGFpbmVkIGZ1bmN0aW9u IGlzIHBhcnNlZCBhZnRlciB0aGUgaG9zdCBhc3NvY2lhdGlvbiBpcyBtYWRl LgotICAgVGhlcmVmb3JlLCBvbiBkZXRlY3RpbmcgdGhpcywgY2hhbmdlIHRo ZSBzeW1ib2wgaW4gdGhlIGV4cHJlc3Npb24KLSAgIGFuZCBjb252ZXJ0IHRo ZSBhcnJheSByZWZlcmVuY2UgaW50byBhbiBhY3R1YWwgYXJnbGlzdCBpZiB0 aGUgb2xkCi0gICBzeW1ib2wgaXMgYSB2YXJpYWJsZS4gICovCisgICBUaGUg b25seSBzaXR1YXRpb25zIHdoZXJlIHRoaXMgYXJpc2VzIGFyZToKKwkoaSkg IFRoYXQgaW4gd2hpY2ggYSB0d2ljZSBjb250YWluZWQgZnVuY3Rpb24gaXMg cGFyc2VkIGFmdGVyCisJICAgICB0aGUgaG9zdCBhc3NvY2lhdGlvbiBpcyBt YWRlLiBPbiBkZXRlY3RpbmcgdGhpcywgY2hhbmdlCisJICAgICB0aGUgc3lt Ym9sIGluIHRoZSBleHByZXNzaW9uIGFuZCBjb252ZXJ0IHRoZSBhcnJheSBy ZWZlcmVuY2UKKwkgICAgIGludG8gYW4gYWN0dWFsIGFyZ2xpc3QgaWYgdGhl IG9sZCBzeW1ib2wgaXMgYSB2YXJpYWJsZTsgb3IKKwkoaWkpIFRoYXQgaW4g d2hpY2ggYW4gZXh0ZXJuYWwgZnVuY3Rpb24gaXMgdHlwZWQgYnV0IG5vdCBk ZWNsYXJlZAorCSAgICAgZXhwbGNpdGx5IHRvIGJlIGV4dGVybmFsLiBIZXJl LCB0aGUgb2xkIHN5bWJvbCBpcyBjaGFuZ2VkCisJICAgICBmcm9tIGEgdmFy aWFibGUgdG8gYW4gZXh0ZXJuYWwgZnVuY3Rpb24uICAqLwogc3RhdGljIGJv b2wKIGNoZWNrX2hvc3RfYXNzb2NpYXRpb24gKGdmY19leHByICplKQogewpA QCAtNjE4NSw2ICs2MTg4LDI3IEBAIGNoZWNrX2hvc3RfYXNzb2NpYXRpb24g KGdmY19leHByICplKQogCSAgZ2ZjX3Jlc29sdmVfZXhwciAoZSk7CiAJICBz eW0tPnJlZnMrKzsKIAl9CisgICAgICAvKiBUaGlzIGNhc2UgY29ycmVzcG9u ZHMgdG8gYSBjYWxsLCBmcm9tIGEgYmxvY2sgb3IgYSBjb250YWluZWQKKwkg cHJvY2VkdXJlLCB0byBhbiBleHRlcm5hbCBmdW5jdGlvbiwgd2hpY2ggaGFz IG5vdCBiZWVuIGRlY2xhcmVkCisJIGFzIGJlaW5nIGV4dGVybmFsIGluIHRo ZSBtYWluIHByb2dyYW0gYnV0IGhhcyBiZWVuIHR5cGVkLiAgKi8KKyAgICAg IGVsc2UgaWYgKHN5bSAmJiBvbGRfc3ltICE9IHN5bQorCSAgICAgICAmJiAh ZS0+cmVmCisJICAgICAgICYmIHN5bS0+dHMudHlwZSA9PSBCVF9VTktOT1dO CisJICAgICAgICYmIG9sZF9zeW0tPnRzLnR5cGUgIT0gQlRfVU5LTk9XTgor CSAgICAgICAmJiBzeW0tPmF0dHIuZmxhdm9yID09IEZMX1BST0NFRFVSRQor CSAgICAgICAmJiBvbGRfc3ltLT5hdHRyLmZsYXZvciA9PSBGTF9WQVJJQUJM RQorCSAgICAgICAmJiBzeW0tPm5zLT5wYXJlbnQgPT0gb2xkX3N5bS0+bnMK KwkgICAgICAgJiYgc3ltLT5ucy0+cHJvY19uYW1lCisJICAgICAgICYmIHN5 bS0+bnMtPnByb2NfbmFtZS0+YXR0ci5wcm9jICE9IFBST0NfTU9EVUxFCisJ ICAgICAgICYmIChzeW0tPm5zLT5wcm9jX25hbWUtPmF0dHIuZmxhdm9yID09 IEZMX0xBQkVMCisJCSAgIHx8IHN5bS0+bnMtPnByb2NfbmFtZS0+YXR0ci5m bGF2b3IgPT0gRkxfUFJPQ0VEVVJFKSkKKwl7CisJICBvbGRfc3ltLT5hdHRy LmZsYXZvciA9IEZMX1BST0NFRFVSRTsKKwkgIG9sZF9zeW0tPmF0dHIuZXh0 ZXJuYWwgPSAxOworCSAgb2xkX3N5bS0+YXR0ci5mdW5jdGlvbiA9IDE7CisJ ICBvbGRfc3ltLT5yZXN1bHQgPSBvbGRfc3ltOworCSAgZ2ZjX3Jlc29sdmVf ZXhwciAoZSk7CisJfQogICAgIH0KICAgLyogVGhpcyBtaWdodCBoYXZlIGNo YW5nZWQhICAqLwogICByZXR1cm4gZS0+ZXhwcl90eXBlID09IEVYUFJfRlVO Q1RJT047Cg== --0000000000003c578105f73f9d8e Content-Type: text/x-fortran; charset="US-ASCII"; name="external_procedures_4.f90" Content-Disposition: attachment; filename="external_procedures_4.f90" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lffcct5u1 ISB7IGRnLWRvIHJ1biB9CiEKISBUZXN0IHRoZSBmaXggZm9yIFBSODcxMjcg aW4gd2hpY2ggdGhlIHJlZmVyZW5jZXMgdG8gZXhmdW5jIGNhdXNlCiEgdGhl IGVycm9yICJleGZ1bmMgYXQgKDEpIGlzIG5vdCBhIGZ1bmN0aW9uIi4KIQoh IENvbnRyaWJ1dGVkIGJ5IEdlcmhhcmQgU3RlaW5tZXR6ICA8Z3NjZnFAdC1v bmxpbmUuZGU+CiEKZnVuY3Rpb24gZXhmdW5jKGkpCiAgaW1wbGljaXQgbm9u ZQogIGludGVnZXIgOjogZXhmdW5jLGkKICBleGZ1bmMgPSAyKmkKZW5kIGZ1 bmN0aW9uCgohIGNvbnRlbnRzIG9mIHRlc3QuZjkwCnByb2dyYW0gdGVzdAog IGltcGxpY2l0IG5vbmUKICBpbnRlZ2VyIDo6IGV4ZnVuYyxpCiAgaW50ZWdl cixwYXJhbWV0ZXIgOjogYXJyYXkoMik9WzYsN10KICBhc3NvY2lhdGUoaT0+ YXJyYXkoMikpICAgICAgICAgICAgISBPcmlnaW5hbCBidWcKICAgIGlmIChl eGZ1bmMoaSkgLm5lLiAyKmkpIHN0b3AgMQogIGVuZCBhc3NvY2lhdGUKICBp ID0gOTkKICBjYWxsIGZvbwpjb250YWlucwogIHN1YnJvdXRpbmUgZm9vKCkg ICAgICAgICAgICAgICAgICAhIENvbW1lbnQgIzMKICAgIGlmIChleGZ1bmMo aSkgLm5lLiAyKmkpIHN0b3AgMgogIGVuZCBzdWJyb3V0aW5lIGZvbwplbmQg cHJvZ3JhbQo= --0000000000003c578105f73f9d8e--