From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 119470 invoked by alias); 20 Mar 2017 09:35:13 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 119446 invoked by uid 89); 20 Mar 2017 09:35:12 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.3 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=H*f:sk:CAGkQGi, H*f:sk:a1f779f, H*f:sk:wjDZXCD, Hx-languages-length:1940 X-Spam-User: qpsmtpd, 2 recipients X-HELO: mail-yw0-f173.google.com Received: from mail-yw0-f173.google.com (HELO mail-yw0-f173.google.com) (209.85.161.173) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 20 Mar 2017 09:35:11 +0000 Received: by mail-yw0-f173.google.com with SMTP id o4so86001263ywd.3; Mon, 20 Mar 2017 02:35:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=kAqULaPCZzfqXaIVoFhsxDTybdectFxcX4dOQRqdsXU=; b=sMDd29Q9HLzNyTiNX0ZvZhZW52r25tIxhwtsEPuJBkUK0YiHzoEuQwAIjpOA/JDT4m K3g0ji1ay6sR19ccUkGHtnKJyaM+6HV4KcFcndb50CwlHywXVbFCxGSJwkhV4l3gmjwi jIJ9l06gQc2zBNeIxmChSFFHjvsR6BcXr/fzn8FsvNpO6P8Czcj/FkRsgGXICxCtuzsO B22RkxTuGGZujD2i8tW3IeCil5ypUwlOE3D0rvqeWy2lB3PynF+ur4Uv+CcQVvE9i/iT zEoanaObc/SrYv+PzK2DjPMoD+Ocn0xTstSnLznhlw6LxvcULhyI+3HI5hmOLz8CAMkq ufsg== X-Gm-Message-State: AFeK/H3tL9O/0BRk83i1/BbqOYXfpZebvsJrooWKJjAIS+AFJf4EVdCXrAZ1Yyqdn8GMBBA3S5Y5iXx+8254sw== X-Received: by 10.13.204.131 with SMTP id o125mr13288371ywd.317.1490002510491; Mon, 20 Mar 2017 02:35:10 -0700 (PDT) MIME-Version: 1.0 Received: by 10.129.7.83 with HTTP; Mon, 20 Mar 2017 02:35:10 -0700 (PDT) In-Reply-To: <06176ef6-0a55-bb29-3ee9-f76698843389@student.ethz.ch> References: <06176ef6-0a55-bb29-3ee9-f76698843389@student.ethz.ch> From: Paul Richard Thomas Date: Mon, 20 Mar 2017 09:35:00 -0000 Message-ID: Subject: Re: [Patch, fortran] PR39239 EQUIVALENCE and BIND(C) To: Nicolas Koenig Cc: "fortran@gcc.gnu.org" , gcc-patches Content-Type: text/plain; charset=UTF-8 X-SW-Source: 2017-03/txt/msg01009.txt.bz2 Dear Nicolas, This is OK for trunk. Thanks for the patch. Paul On 19 March 2017 at 14:34, Nicolas Koenig wrote: > Hello Paul, > > there isn't really a reason for that except for not knowing where to put the > error. Attached are the new patch & test case. > > The paperwork is done and I have commit rights. > > Thanks for the kind welcome! > > Nicolas > > Regression tested for x86_64-pc-linux-gnu. > > 2017-03-12 Nicolas Koenig > > PR fortran/39239 > * symbol.c (check_conflict): report an error if an EQUIVALENCE variable > is BIND(C). > > 2017-03-12 Nicolas Koenig > > PR fortran/39239 > * gfortran.dg/equiv_constraint_bind_c.f90: New test. > > > On 03/19/2017 01:02 PM, Paul Richard Thomas wrote: >> >> Hi Nicolas, >> >> Is there some reason that you didn't use symbol.c(check_conflict)? The >> conflict check could be added at line 547. If this results in >> repetitions of the error message, then your patch is OK. Otherwise, I >> would pop it in there. >> >> Do you have commit rights? ie. have you done the FSF paperwork? >> >> Welcome aboard! >> >> Paul >> >> On 19 March 2017 at 00:15, Nicolas Koenig >> wrote: >>> >>> Hello everyone, >>> >>> I submitted this patch a week ago, but I think it got lost. It adds an >>> error >>> if BIND(C) is used with EQUIVALENCE. >>> >>> Nicolas >>> >>> Regression tested for x86_64-pc-linux-gnu. >>> >>> 2017-03-18 Nicolas Koenig >>> >>> PR fortran/39239 >>> * resolve.c (resolve_equivalence): report an error if an >>> equivalence variable is BIND(C). >>> >>> 2017-03-18 Nicolas Koenig >>> >>> PR fortran/39239 >>> * gfortran.dg/equiv_constraint_bind_c.f90: New test. >>> >> >> > -- "If you can't explain it simply, you don't understand it well enough" - Albert Einstein