From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20145 invoked by alias); 10 Apr 2015 11:17:14 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 19698 invoked by uid 89); 10 Apr 2015 11:17:13 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.0 required=5.0 tests=AWL,BAYES_20,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: mail-wg0-f45.google.com Received: from mail-wg0-f45.google.com (HELO mail-wg0-f45.google.com) (74.125.82.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Fri, 10 Apr 2015 11:17:12 +0000 Received: by wgyo15 with SMTP id o15so14450408wgy.2; Fri, 10 Apr 2015 04:17:09 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.194.175.137 with SMTP id ca9mr2011017wjc.67.1428664629849; Fri, 10 Apr 2015 04:17:09 -0700 (PDT) Received: by 10.180.77.5 with HTTP; Fri, 10 Apr 2015 04:17:09 -0700 (PDT) In-Reply-To: <5527747D.6030908@net-b.de> References: <5527747D.6030908@net-b.de> Date: Fri, 10 Apr 2015 11:17:00 -0000 Message-ID: Subject: Re: [Patch, Fortran] Fix (serious) issue with Coarray's (UN)LOCK From: Paul Richard Thomas To: Tobias Burnus Cc: gfortran , gcc-patches , Alessandro Fanfarillo Content-Type: text/plain; charset=ISO-8859-1 X-SW-Source: 2015-04/txt/msg00449.txt.bz2 Hi Tobias, OK for trunk. Thanks for the patch Paul On 10 April 2015 at 08:58, Tobias Burnus wrote: > This patch does two things: > > a) It finally implements locking/unlocking with -fcoarray=lib. Before it was > effectively a no op operation always succeeding. - The implementation only > works for "normal" locking variables - and neither for CLASS, type extension > or lock components of derived types. > > b) It adds a compile-time error for the cases not supported, avoiding race > conditions due to an only apparently working locking (as it would be the > case with the implementation before the patch). > > Build and regtested on x86-64-gnu-linux. > OK for the GCC 5 trunk? > > Tobias -- Outside of a dog, a book is a man's best friend. Inside of a dog it's too dark to read. Groucho Marx