From: Paul Richard Thomas <paul.richard.thomas@gmail.com>
To: Thomas Koenig <tkoenig@netcologne.de>
Cc: "fortran@gcc.gnu.org" <fortran@gcc.gnu.org>,
gcc-patches <gcc-patches@gcc.gnu.org>,
Richard Guenther <rguenther@suse.de>,
Jakub Jelinek <jakub@redhat.com>,
stefan.mauerberger@gmail.com,
Dominique Dhumieres <dominiq@lps.ens.fr>
Subject: Re: [Patch, fortran] PR56008 (and PR47517) [F03] wrong code with lhs-realloc on assignment with derived types having allocatable components
Date: Mon, 04 Feb 2013 22:35:00 -0000 [thread overview]
Message-ID: <CAGkQGiJfPZU_T_FGim55onRRTWN1y4Byh3rhXMFh14THM9cJ6Q@mail.gmail.com> (raw)
In-Reply-To: <5106EB0F.7010601@netcologne.de>
Committed revision 195741.
Thanks for the review.
Paul
On 28 January 2013 22:18, Thomas Koenig <tkoenig@netcologne.de> wrote:
> Hi Paul,
>
>
>> This patch is sufficiently straightforward that the ChangeLog entry
>> describes it completely. The fix for both bugs lay in the
>> nullification of the allocatable components of the newly (re)allocated
>> array.
>
>
> I think this fix is OK for trunk, for the reasons you mentioned. I also
> think it is straightforward enough (bordering on the obvious, but only
> after having read it :-) that it does not carry too much risk of a
> regression.
>
> So yes, OK from my side, unless somebody speaks up really quickly.
>
> Thomas
--
The knack of flying is learning how to throw yourself at the ground and miss.
--Hitchhikers Guide to the Galaxy
prev parent reply other threads:[~2013-02-04 22:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-22 22:40 Paul Richard Thomas
2013-01-23 10:06 ` Tobias Burnus
2013-01-28 20:56 ` Paul Richard Thomas
2013-01-28 21:18 ` Thomas Koenig
2013-02-04 22:35 ` Paul Richard Thomas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGkQGiJfPZU_T_FGim55onRRTWN1y4Byh3rhXMFh14THM9cJ6Q@mail.gmail.com \
--to=paul.richard.thomas@gmail.com \
--cc=dominiq@lps.ens.fr \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=rguenther@suse.de \
--cc=stefan.mauerberger@gmail.com \
--cc=tkoenig@netcologne.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).