From: Paul Richard Thomas <paul.richard.thomas@gmail.com>
To: Steve Kargl <sgk@troutmask.apl.washington.edu>
Cc: "fortran@gcc.gnu.org" <fortran@gcc.gnu.org>,
gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] PR fortran/82049 -- resolve a charlen if possible
Date: Wed, 07 Feb 2018 08:10:00 -0000 [thread overview]
Message-ID: <CAGkQGiJqUMJKdR=8iTTUtJ5_GF=1jNkrnz4vsNqQ_0_RrQJcgg@mail.gmail.com> (raw)
In-Reply-To: <20180207021706.GA39844@troutmask.apl.washington.edu>
Hi Steve,
That's OK for trunk and, if you are possessed of the intestinal
fortitude, 6- and 7-branches.
Thanks
Paul
On 7 February 2018 at 02:17, Steve Kargl
<sgk@troutmask.apl.washington.edu> wrote:
> The attached patch fixes PR fortran/82049. Prior to this
> patch, gfortran was fouling up the resolution of the charlen
> expression in the testcase. The immediately tries to resolve
> the length while parsing the type-spec.
>
> While here, I've introduced an optimization that causes
> gfc_match_type_spec() to return early if the gfortran isn't
> going to be getting a type-spec. This is done be peeking
> at the next character, if it is in [a-z], the we don't have
> a type spec. OK to commit?
>
>
> 2018-02-06 Steven G. Kargl <kargl@gcc.gnu.org>
>
> PR fortran/82049
> * match.c (gfc_match_type_spec): If the charlen is non-NULL, then
> try to resolve it. While here return early if possible.
>
> 2018-02-06 Steven G. Kargl <kargl@gcc.gnu.org>
>
> PR fortran/82049
> * gfortran.dg/assumed_charlen_parameter.f90: New test.
>
>
> --
> Steve
--
"If you can't explain it simply, you don't understand it well enough"
- Albert Einstein
next prev parent reply other threads:[~2018-02-07 8:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-07 2:17 Steve Kargl
2018-02-07 8:10 ` Paul Richard Thomas [this message]
2018-02-07 21:02 ` Steve Kargl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGkQGiJqUMJKdR=8iTTUtJ5_GF=1jNkrnz4vsNqQ_0_RrQJcgg@mail.gmail.com' \
--to=paul.richard.thomas@gmail.com \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=sgk@troutmask.apl.washington.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).