From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6446 invoked by alias); 21 Jul 2015 21:11:02 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 6424 invoked by uid 89); 21 Jul 2015 21:11:01 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.6 required=5.0 tests=AWL,BAYES_05,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: mail-wi0-f180.google.com Received: from mail-wi0-f180.google.com (HELO mail-wi0-f180.google.com) (209.85.212.180) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Tue, 21 Jul 2015 21:11:00 +0000 Received: by wibud3 with SMTP id ud3so143641987wib.0; Tue, 21 Jul 2015 14:10:57 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.194.158.42 with SMTP id wr10mr69196431wjb.81.1437513057362; Tue, 21 Jul 2015 14:10:57 -0700 (PDT) Received: by 10.180.11.10 with HTTP; Tue, 21 Jul 2015 14:10:57 -0700 (PDT) In-Reply-To: <55AE40B2.5070307@sfr.fr> References: <55AE40B2.5070307@sfr.fr> Date: Tue, 21 Jul 2015 22:53:00 -0000 Message-ID: Subject: Re: [Patch, fortran] PR66929 fix iso_varying_string ICE From: Paul Richard Thomas To: Mikael Morin Cc: gcc-patches , gfortran Content-Type: text/plain; charset=UTF-8 X-SW-Source: 2015-07/txt/msg01799.txt.bz2 Hi Mikael, This looks fine to me - OK for trunk. Thanks for the patch Paul On 21 July 2015 at 14:53, Mikael Morin wrote: > Hello, > > The fix for PR61831 committed recently [1] introduced/uncovered a NULLL > pointer dereference with iso_varying_string, because a generic symbol (which > has a NULL result) is used as procedure symbol, instead of the specific one. > Fixed by using esym if it's available. > > Regression-tested on x86_64-linux. OK for trunk? > > Mikael > > [1]: https://gcc.gnu.org/ml/gcc-patches/2015-06/msg01389.html > -- Outside of a dog, a book is a man's best friend. Inside of a dog it's too dark to read. Groucho Marx