From: Paul Richard Thomas <paul.richard.thomas@gmail.com>
To: Steve Kargl <sgk@troutmask.apl.washington.edu>
Cc: Mikael Morin <mikael.morin@sfr.fr>,
Andre Vehreschild <vehre@gmx.de>,
"fortran@gcc.gnu.org" <fortran@gcc.gnu.org>,
gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [Patch, fortran] PR65792 - allocation of scalar elemental function with structure constructor fails
Date: Mon, 27 Apr 2015 20:42:00 -0000 [thread overview]
Message-ID: <CAGkQGiK0puVoALMW36TzdoWPE=zw8fNOEu2uzeAEO6CJe2SUoA@mail.gmail.com> (raw)
In-Reply-To: <20150426185319.GA29878@troutmask.apl.washington.edu>
Dear Steve,
Thanks for the review. I THINK that I know what I meant in the comment
:-) I will commit tomorrow night.
Cheers
Paul
On 26 April 2015 at 20:53, Steve Kargl <sgk@troutmask.apl.washington.edu> wrote:
> On Sun, Apr 26, 2015 at 08:35:06PM +0200, Paul Richard Thomas wrote:
>>
>> --- 7062,7091 ----
>> {
>> if (expr->expr_type != EXPR_STRUCTURE)
>> {
>> + tree dealloc = NULL_TREE;
>> gfc_init_se (&se, NULL);
>> gfc_conv_expr (&se, expr);
>> gfc_add_block_to_block (&block, &se.pre);
>> + /* Prevent repeat evaluations in gfc_copy_alloc_comp by fixing the
>> + expression in a temporary variable and deallocate is allocatable
>> + components the copy to the result. */
>
> Can you take a second shot at this comment? The "and ..." portions
> seems to be a little muddled.
>
> OK with after comment fix.
>
> --
> Steve
--
Outside of a dog, a book is a man's best friend. Inside of a dog it's
too dark to read.
Groucho Marx
next prev parent reply other threads:[~2015-04-27 20:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-26 18:35 Paul Richard Thomas
2015-04-26 18:53 ` Steve Kargl
2015-04-27 20:42 ` Paul Richard Thomas [this message]
2015-05-01 18:25 ` Paul Richard Thomas
2015-05-09 13:13 ` Mikael Morin
2015-05-15 17:02 ` *ping* " Mikael Morin
2015-05-15 18:07 ` Paul Richard Thomas
2015-05-16 9:39 ` Paul Richard Thomas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGkQGiK0puVoALMW36TzdoWPE=zw8fNOEu2uzeAEO6CJe2SUoA@mail.gmail.com' \
--to=paul.richard.thomas@gmail.com \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=mikael.morin@sfr.fr \
--cc=sgk@troutmask.apl.washington.edu \
--cc=vehre@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).