From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14573 invoked by alias); 27 Apr 2015 20:42:44 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 14552 invoked by uid 89); 27 Apr 2015 20:42:43 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.1 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: mail-wi0-f180.google.com Received: from mail-wi0-f180.google.com (HELO mail-wi0-f180.google.com) (209.85.212.180) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Mon, 27 Apr 2015 20:42:42 +0000 Received: by widdi4 with SMTP id di4so5111007wid.0; Mon, 27 Apr 2015 13:42:39 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.194.59.79 with SMTP id x15mr25312706wjq.81.1430167359191; Mon, 27 Apr 2015 13:42:39 -0700 (PDT) Received: by 10.180.82.133 with HTTP; Mon, 27 Apr 2015 13:42:39 -0700 (PDT) In-Reply-To: <20150426185319.GA29878@troutmask.apl.washington.edu> References: <20150426185319.GA29878@troutmask.apl.washington.edu> Date: Mon, 27 Apr 2015 20:42:00 -0000 Message-ID: Subject: Re: [Patch, fortran] PR65792 - allocation of scalar elemental function with structure constructor fails From: Paul Richard Thomas To: Steve Kargl Cc: Mikael Morin , Andre Vehreschild , "fortran@gcc.gnu.org" , gcc-patches Content-Type: text/plain; charset=ISO-8859-1 X-SW-Source: 2015-04/txt/msg01680.txt.bz2 Dear Steve, Thanks for the review. I THINK that I know what I meant in the comment :-) I will commit tomorrow night. Cheers Paul On 26 April 2015 at 20:53, Steve Kargl wrote: > On Sun, Apr 26, 2015 at 08:35:06PM +0200, Paul Richard Thomas wrote: >> >> --- 7062,7091 ---- >> { >> if (expr->expr_type != EXPR_STRUCTURE) >> { >> + tree dealloc = NULL_TREE; >> gfc_init_se (&se, NULL); >> gfc_conv_expr (&se, expr); >> gfc_add_block_to_block (&block, &se.pre); >> + /* Prevent repeat evaluations in gfc_copy_alloc_comp by fixing the >> + expression in a temporary variable and deallocate is allocatable >> + components the copy to the result. */ > > Can you take a second shot at this comment? The "and ..." portions > seems to be a little muddled. > > OK with after comment fix. > > -- > Steve -- Outside of a dog, a book is a man's best friend. Inside of a dog it's too dark to read. Groucho Marx