public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Paul Richard Thomas <paul.richard.thomas@gmail.com>
To: "fortran@gcc.gnu.org" <fortran@gcc.gnu.org>,
	gcc-patches <gcc-patches@gcc.gnu.org>
Subject: [Patch, fortran] PR108961 - Segfault when associating to pointer from C_F_POINTER
Date: Tue, 20 Jun 2023 17:19:07 +0100	[thread overview]
Message-ID: <CAGkQGiKCiHkaBpuXXPD7_cG8O-P+tWju=CFCw9eiwLCZLvnOtw@mail.gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 321 bytes --]

Dear All,

This patch is verging on obvious. The PR was originally, incorrectly
blocking PR87477 and the testcase has remained in my 'associate'
directory. I thought that it is time to get shot of it!

Is there a better way to detect a type(c_ptr) formal argument?

Subject to advice on the question, OK for trunk?

Paul

[-- Attachment #2: submit.diff --]
[-- Type: text/x-patch, Size: 541 bytes --]

diff --git a/gcc/fortran/trans-expr.cc b/gcc/fortran/trans-expr.cc
index 45a984b6bdb..0823efd5abc 100644
--- a/gcc/fortran/trans-expr.cc
+++ b/gcc/fortran/trans-expr.cc
@@ -7353,6 +7353,8 @@ gfc_conv_procedure_call (gfc_se * se, gfc_symbol * sym,
 	 need the length.  */
       if (parmse.string_length != NULL_TREE
 	  && !sym->attr.is_bind_c
+	  && !(fsym && fsym->ts.type == BT_DERIVED
+	       && !strcmp (fsym->ts.u.derived->name, "c_ptr"))
 	  && !(fsym && UNLIMITED_POLY (fsym)))
 	vec_safe_push (stringargs, parmse.string_length);
 

[-- Attachment #3: Change.Logs --]
[-- Type: application/octet-stream, Size: 337 bytes --]

Fortran: Seg fault passing string to type cptr dummy [PR108961].

2023-06-20  Paul Thomas  <pault@gcc.gnu.org>

gcc/fortran
	PR fortran/108961
	* trans-expr.cc (gfc_conv_procedure_call): The hidden string
	length must not be passed to a formal arg of type(cptr).

gcc/testsuite/
	PR fortran/108961
	* gfortran.dg/pr108961.f90: New test.

[-- Attachment #4: pr108961.f90 --]
[-- Type: text/x-fortran, Size: 901 bytes --]

! { dg-do run }
!
! Contributed by Jeffrey Hill  <jeffrey.p.hill@nasa.gov>
!
module associate_ptr
    use iso_c_binding
contains
    subroutine c_f_strpointer(cptr, ptr2)
        type(c_ptr), target, intent(in) :: cptr
        character(kind=c_char,len=4), pointer :: ptr1
        character(kind=c_char,len=:), pointer, intent(out) :: ptr2
        call c_f_pointer(cptr, ptr1)
        if (ptr1 .ne. 'abcd') stop 1
        ptr2 => ptr1                              ! Failed here
    end subroutine
end module

program test_associate_ptr
    use associate_ptr
    character(kind=c_char, len=1), target :: char_array(7)
    character(kind=c_char,len=:), pointer :: ptr2
    char_array = ['a', 'b', 'c', 'd', c_null_char, 'e', 'f']
! The first argument was providing a constant hidden string length => segfault
    call c_f_strpointer(c_loc(char_array), ptr2)
    if (ptr2 .ne. 'abcd') stop 2
end program

             reply	other threads:[~2023-06-20 16:19 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-20 16:19 Paul Richard Thomas [this message]
2023-06-20 16:30 ` Tobias Burnus
2023-06-20 20:47   ` Mikael Morin
2023-06-21 16:08     ` Paul Richard Thomas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAGkQGiKCiHkaBpuXXPD7_cG8O-P+tWju=CFCw9eiwLCZLvnOtw@mail.gmail.com' \
    --to=paul.richard.thomas@gmail.com \
    --cc=fortran@gcc.gnu.org \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).