public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Paul Richard Thomas <paul.richard.thomas@gmail.com>
To: Janus Weil <janus@gcc.gnu.org>
Cc: Tobias Burnus <burnus@net-b.de>, gfortran <fortran@gcc.gnu.org>,
		gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [Patch, Fortran, OOP] PR 64230: [4.9/5 Regression] Invalid memory reference in a compiler-generated finalizer for allocatable component
Date: Mon, 26 Jan 2015 22:20:00 -0000	[thread overview]
Message-ID: <CAGkQGiKNCnC+bBO8PoMsFGUJ8JFJRsTw+MQ-mAWdx6vm7pwmVg@mail.gmail.com> (raw)
In-Reply-To: <CAKwh3qgVrQNLq4arih9zmRPkrg0VhpVAbiFgpP793AE29Mp4pw@mail.gmail.com>

Hi Janus,

The testcase has a dependence on libubsan.so, which my LD_LIBRARY_PATH
does not seem to be able to resolve. It therefore fails in the
regression test. When I point to ~/lib64, I get the message:

/svn/trunk/gcc/testsuite/gfortran.dg/class_allocate_18.f90:8: runtime
error: signed integer overflow: 214358001592 * 214358001560 cannot be
represented in type 'integer(kind=8)'

Cheers

Paul

On 26 January 2015 at 15:57, Janus Weil <janus@gcc.gnu.org> wrote:
> 2015-01-24 18:18 GMT+01:00 Tobias Burnus <burnus@net-b.de>:
>>> this is a second patch dealing with finalization-related regressions,
>>> [...]
>>> This patch fixes an invalid memory reference inside the finalizer
>>> routine (at runtime), which apparently was caused by dereferencing a
>>> pointer without checking if it's NULL. I simply insert a call to
>>> ASSOCIATED.
>>> [...]
>>>
>>> This one regtests cleanly on x86_64-unknown-linux-gnu. Ok for trunk and
>>> 4.9?
>>
>>
>> OK. Thanks for the patch!
>
> Thanks for the review, Tobias. Committed to trunk as r220125. Will
> backport to 4.9 soon.
>
> Cheers,
> Janus



-- 
Outside of a dog, a book is a man's best friend. Inside of a dog it's
too dark to read.

Groucho Marx

  reply	other threads:[~2015-01-26 21:48 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-19 15:05 Janus Weil
2015-01-24 10:49 ` Janus Weil
2015-01-24 20:12 ` Tobias Burnus
2015-01-26 17:05   ` Janus Weil
2015-01-26 22:20     ` Paul Richard Thomas [this message]
2015-01-26 23:57       ` Janus Weil
2015-01-27  8:10         ` Paul Richard Thomas
2015-01-27  9:47 ` Andreas Schwab
2015-01-27 10:48   ` Jakub Jelinek
2015-01-27 19:21     ` Janus Weil
2015-01-27 19:27       ` Jakub Jelinek
2015-01-27 20:36         ` Janus Weil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAGkQGiKNCnC+bBO8PoMsFGUJ8JFJRsTw+MQ-mAWdx6vm7pwmVg@mail.gmail.com \
    --to=paul.richard.thomas@gmail.com \
    --cc=burnus@net-b.de \
    --cc=fortran@gcc.gnu.org \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=janus@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).