Re: [Patch, fortran] PR66079 - [6 Regression] memory leak with source allocation in internal subprogram

[Paul Richard Thomas <paul.richard.thomas@gmail.com>]

Dear Andre and Mikael,

Thanks for the reviews and the discussion about the name of the
temporary. I went for "source" in the end. The "expr3" was merely
meant to align with the expression....

Following Andre's suggestion, I left his additions to another time;
especially since the patch was heading towards bit-rot because I have
been so long in getting back to it.

Committed to trunk as revision 224383.


Cheers

Paul

On 25 May 2015 at 19:33, Mikael Morin <mikael.morin@sfr.fr> wrote:
> Le 25/05/2015 09:30, Paul Richard Thomas a écrit :
>> Dear All,
>>
>> Lets see if I can get it right this time :-)
>>
>> Note that I have changed the name of the temporary variable in
>> trans_allocate from 'atmp' to 'expr3' so that it is not confused with
>> array temporaries.
> I agree with Andre willing to use a more explicit name ("source"), and I
> suggest pushing it yet further; something like "alloc_source_tmp".
> We should never have named things "expr3" all over the place,  but
> that's another matter.
>
>> Bootstrapped and regtested on a current trunk - OK for trunk?
>>
> Yes, looks good. Thanks.
>
> Mikael



-- 
Outside of a dog, a book is a man's best friend. Inside of a dog it's
too dark to read.

Groucho Marx