From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 36640 invoked by alias); 11 Jun 2015 15:55:27 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 36617 invoked by uid 89); 11 Jun 2015 15:55:27 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=0.2 required=5.0 tests=AWL,BAYES_50,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: mail-wi0-f193.google.com Received: from mail-wi0-f193.google.com (HELO mail-wi0-f193.google.com) (209.85.212.193) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Thu, 11 Jun 2015 15:55:25 +0000 Received: by wivr20 with SMTP id r20so4080239wiv.3; Thu, 11 Jun 2015 08:55:23 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.180.105.227 with SMTP id gp3mr20772497wib.56.1434038122843; Thu, 11 Jun 2015 08:55:22 -0700 (PDT) Received: by 10.180.11.10 with HTTP; Thu, 11 Jun 2015 08:55:22 -0700 (PDT) In-Reply-To: <55635CD8.5070005@sfr.fr> References: <20150523195252.22647b46@vepi2> <55635CD8.5070005@sfr.fr> Date: Thu, 11 Jun 2015 16:00:00 -0000 Message-ID: Subject: Re: [Patch, fortran] PR66079 - [6 Regression] memory leak with source allocation in internal subprogram From: Paul Richard Thomas To: Mikael Morin Cc: Andre Vehreschild , "fortran@gcc.gnu.org" , gcc-patches , Damian Rouson Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-SW-Source: 2015-06/txt/msg00860.txt.bz2 Dear Andre and Mikael, Thanks for the reviews and the discussion about the name of the temporary. I went for "source" in the end. The "expr3" was merely meant to align with the expression.... Following Andre's suggestion, I left his additions to another time; especially since the patch was heading towards bit-rot because I have been so long in getting back to it. Committed to trunk as revision 224383. Cheers Paul On 25 May 2015 at 19:33, Mikael Morin wrote: > Le 25/05/2015 09:30, Paul Richard Thomas a =C3=A9crit : >> Dear All, >> >> Lets see if I can get it right this time :-) >> >> Note that I have changed the name of the temporary variable in >> trans_allocate from 'atmp' to 'expr3' so that it is not confused with >> array temporaries. > I agree with Andre willing to use a more explicit name ("source"), and I > suggest pushing it yet further; something like "alloc_source_tmp". > We should never have named things "expr3" all over the place, but > that's another matter. > >> Bootstrapped and regtested on a current trunk - OK for trunk? >> > Yes, looks good. Thanks. > > Mikael --=20 Outside of a dog, a book is a man's best friend. Inside of a dog it's too dark to read. Groucho Marx