From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x52b.google.com (mail-pg1-x52b.google.com [IPv6:2607:f8b0:4864:20::52b]) by sourceware.org (Postfix) with ESMTPS id 020C8385840D; Wed, 24 Apr 2024 06:05:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 020C8385840D Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 020C8385840D Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::52b ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713938724; cv=none; b=Z+D87UuNgI7XpF/0rsk5kLEJBLtUOL0SmyZDCnQ1qMTVGycASXZAm1owRojQKJ8HZwFb4RYdD/WP7y3gd4RkjWqM58a43iIuCsIw5su0wsTHRlmbK5CnA9HMa3pgOZz0EttoeN3mVufUmMD+jg3Ma3u3Wtl4ikeVy810ykw0G40= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713938724; c=relaxed/simple; bh=hkuPqWYs5zrITB0etAIWxe4iw7j6PtCryS2Cvo+YNWw=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=xhIUi3m4Hnadl0JfpAFk0Fra9XVC8bfW+0IIUGzdNZu0NXVZfdLB/isePTD4yjQN7pfPmXHwQMGX9JKYZhNo/V8xvVpNJwh3IbK+Cg7K5JhIBEqKGAw3i5SIEsdhbblunDfxvQGariYR7D+eoy4Xq5ju1zyw6wZJ9RL2X32yz0A= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pg1-x52b.google.com with SMTP id 41be03b00d2f7-5e152c757a5so3630872a12.2; Tue, 23 Apr 2024 23:05:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713938719; x=1714543519; darn=gcc.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=BKpYEwVd7A41Fq1HI0Owy2idWM2Y4VIDvjolYhFYNzs=; b=Ph9csoEMvoShCza6sQnprDsw5LroIJs9OdlOPesDsKeoKCjEkpZb/c7NizZngx802p 1OBUiTyx3uzZDwRiOAa4y0dFhdnq3+MJ/YRyHwQ0fnhGfIz/acfgG9wsQQxt+AQ2tGRr StMT1Ov0Ghgquz8H++gsgAZNhP8djliazfkGYXlWt8NIhRX8Lt2PUYwwIVOjHQFswgh+ NwJ/Njlb4clBATsuJAPlCQTxeqqS22Ch7IACChEzMI0W8/ed76MxxRBhfCoyXCeTDJ4M S6ut+I02EQgoc+FB3Pve7YUZqR5iA+GZkWVPxciFsMDeA1W0FmAhliO8y4p/jC4Eq0qL x75Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713938719; x=1714543519; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=BKpYEwVd7A41Fq1HI0Owy2idWM2Y4VIDvjolYhFYNzs=; b=f3aa2WVnGL3hAm4SXBP4Mot2XSEw7b3KQve5rObNA2gl3+YhNGYB8WlP9DZKB/GDjT dM2gisOLyjAzjVlqTKPXfzfNe5NfZyVig6x92OJM9tn6Pa3wBJsg2UZstezZ++of9g2o MUMHCJZ4z4OAtE9L1cDnDjhWmerfVYvON9DPp4xvHEkO3W10FjHc55thO9sgisVJMaZj TdRvITqtZoEEuq1j5kAqbzZh4Ljnl0N3dnoYXF+EDv6KU5wp0/9WJp3QR2jh7WEt9eoa T8IMngqojxxajTZchLZ+Z6X4BdxB0TNH3xTmrpbgMUQgspAlVwua/LNX8FzbYlSWnls1 LXMw== X-Forwarded-Encrypted: i=1; AJvYcCWHIg6bjPLvrNJawcO5rSHxlDjmsbX0sCGqwDcc42eyaQNi6FegYGmCnv17xfxd79hvdh1lt74bjNg4JM8lJ3eYaa+CIhSO1w== X-Gm-Message-State: AOJu0YyiUQTkEPcpIzuwJLRFVy7QFlxinhh50nz5kNsSWs6hD7sKBwqF a/y5iUfjqmZnHF4J3lMtM5pYsDxOYyRS+9sz0b5q9QU8dLBzeXkgToKsxgc9VLjyHI66kxy6YRU hT2IyVbh/iGQlHQwtKFEcdqWA9M57MuUp X-Google-Smtp-Source: AGHT+IGjJlPMZWySN179h82V/0RQJotGiESXZQ79Z/RVGRis6/edYH496/eqmbQmJ+l+x9AmtavDlvEP8/ZwJoRb0Ck= X-Received: by 2002:a17:90a:c691:b0:2a9:1b6f:36a4 with SMTP id n17-20020a17090ac69100b002a91b6f36a4mr1122949pjt.49.1713938719414; Tue, 23 Apr 2024 23:05:19 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Paul Richard Thomas Date: Wed, 24 Apr 2024 07:05:07 +0100 Message-ID: Subject: Re: [Patch, fortran] PR89462 - [11/12/13/14 Regression] gfortran loops in code generation To: "fortran@gcc.gnu.org" , gcc-patches Cc: Harald Anlauf Content-Type: multipart/mixed; boundary="00000000000089b3b90616d174ee" X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --00000000000089b3b90616d174ee Content-Type: multipart/alternative; boundary="00000000000089b3b80616d174ec" --00000000000089b3b80616d174ec Content-Type: text/plain; charset="UTF-8" Hi, The linaro pre-commit error testing picked up errors for arm and aarch since they set the option -pedantic-errors. /home/tcwg-build/workspace/tcwg_gnu_4/abe/snapshots/gcc.git~master/gcc/testsuite/gfortran.dg/pr89462.f90:6:14: Warning: Obsolescent feature: Old-style character length at (1) /home/tcwg-build/workspace/tcwg_gnu_4/abe/snapshots/gcc.git~master/gcc/testsuite/gfortran.dg/pr89462.f90:7:17: Warning: Obsolescent feature: Old-style character length at (1) I have added the option to the testcase together with the corresponding warnings as in the attached. I will wait for 24 hours more. Paul On Tue, 23 Apr 2024 at 16:25, Paul Richard Thomas < paul.richard.thomas@gmail.com> wrote: > Hi All, > > Jakub pinpointed the source of this bug in comment 6 of the PR. The rest > was 'obvious' :-) > > I plan to push the patch to mainline in the next 24 hours unless there are > opinions to the contrary. Backporting is proposed to occur a couple of > weeks later. > > Best regards > > Paul > > Fortran: Generate new charlens for shared symbol typespecs [PR89462] > > 2024-04-23 Paul Thomas > Jakub Jelinek > > gcc/fortran > PR fortran/89462 > * decl.cc (build_sym): Add an extra argument 'elem'. If 'elem' > is greater than 1, gfc_new_charlen is called to generate a new > charlen, registered in the symbol namespace. > (variable_decl, enumerator_decl): Set the new argument in the > calls to build_sym. > > gcc/testsuite/ > PR fortran/89462 > * gfortran.dg/pr89462.f90: New test. > > --00000000000089b3b80616d174ec-- --00000000000089b3b90616d174ee Content-Type: text/x-patch; charset="US-ASCII"; name="submit.diff" Content-Disposition: attachment; filename="submit.diff" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lvdervvs0 ZGlmZiAtLWdpdCBhL2djYy9mb3J0cmFuL2RlY2wuY2MgYi9nY2MvZm9ydHJh bi9kZWNsLmNjCmluZGV4IGE3NTc2ZjRiYzQwLi5iODMwOGFlZWU1NSAxMDA2 NDQKLS0tIGEvZ2NjL2ZvcnRyYW4vZGVjbC5jYworKysgYi9nY2MvZm9ydHJh bi9kZWNsLmNjCkBAIC0xNzEzLDcgKzE3MTMsNyBAQCBnZmNfdmVyaWZ5X2Nf aW50ZXJvcF9wYXJhbSAoZ2ZjX3N5bWJvbCAqc3ltKQogLyogRnVuY3Rpb24g Y2FsbGVkIGJ5IHZhcmlhYmxlX2RlY2woKSB0aGF0IGFkZHMgYSBuYW1lIHRv IHRoZSBzeW1ib2wgdGFibGUuICAqLwogCiBzdGF0aWMgYm9vbAotYnVpbGRf c3ltIChjb25zdCBjaGFyICpuYW1lLCBnZmNfY2hhcmxlbiAqY2wsIGJvb2wg Y2xfZGVmZXJyZWQsCitidWlsZF9zeW0gKGNvbnN0IGNoYXIgKm5hbWUsIGlu dCBlbGVtLCBnZmNfY2hhcmxlbiAqY2wsIGJvb2wgY2xfZGVmZXJyZWQsCiAJ ICAgZ2ZjX2FycmF5X3NwZWMgKiphcywgbG9jdXMgKnZhcl9sb2N1cykKIHsK ICAgc3ltYm9sX2F0dHJpYnV0ZSBhdHRyOwpAQCAtMTc3OCw3ICsxNzc4LDEw IEBAIGJ1aWxkX3N5bSAoY29uc3QgY2hhciAqbmFtZSwgZ2ZjX2NoYXJsZW4g KmNsLCBib29sIGNsX2RlZmVycmVkLAogCiAgIGlmIChzeW0tPnRzLnR5cGUg PT0gQlRfQ0hBUkFDVEVSKQogICAgIHsKLSAgICAgIHN5bS0+dHMudS5jbCA9 IGNsOworICAgICAgaWYgKGVsZW0gPiAxKQorCXN5bS0+dHMudS5jbCA9IGdm Y19uZXdfY2hhcmxlbiAoc3ltLT5ucywgY2wpOworICAgICAgZWxzZQorCXN5 bS0+dHMudS5jbCA9IGNsOwogICAgICAgc3ltLT50cy5kZWZlcnJlZCA9IGNs X2RlZmVycmVkOwogICAgIH0KIApAQCAtMjk2MCw3ICsyOTYzLDcgQEAgdmFy aWFibGVfZGVjbCAoaW50IGVsZW0pCiAgICAgIGNyZWF0ZSBhIHN5bWJvbCBm b3IgdGhvc2UgeWV0LiAgSWYgd2UgZmFpbCB0byBjcmVhdGUgdGhlIHN5bWJv bCwKICAgICAgYmFpbCBvdXQuICAqLwogICBpZiAoIWdmY19jb21wX3N0cnVj dCAoZ2ZjX2N1cnJlbnRfc3RhdGUgKCkpCi0gICAgICAmJiAhYnVpbGRfc3lt IChuYW1lLCBjbCwgY2xfZGVmZXJyZWQsICZhcywgJnZhcl9sb2N1cykpCisg ICAgICAmJiAhYnVpbGRfc3ltIChuYW1lLCBlbGVtLCBjbCwgY2xfZGVmZXJy ZWQsICZhcywgJnZhcl9sb2N1cykpCiAgICAgewogICAgICAgbSA9IE1BVENI X0VSUk9SOwogICAgICAgZ290byBjbGVhbnVwOwpAQCAtMTA5MzgsNyArMTA5 NDEsNyBAQCBlbnVtZXJhdG9yX2RlY2wgKHZvaWQpCiAgIC8qIE9LLCB3ZSd2 ZSBzdWNjZXNzZnVsbHkgbWF0Y2hlZCB0aGUgZGVjbGFyYXRpb24uICBOb3cg cHV0IHRoZQogICAgICBzeW1ib2wgaW4gdGhlIGN1cnJlbnQgbmFtZXNwYWNl LiBJZiB3ZSBmYWlsIHRvIGNyZWF0ZSB0aGUgc3ltYm9sLAogICAgICBiYWls IG91dC4gICovCi0gIGlmICghYnVpbGRfc3ltIChuYW1lLCBOVUxMLCBmYWxz ZSwgJmFzLCAmdmFyX2xvY3VzKSkKKyAgaWYgKCFidWlsZF9zeW0gKG5hbWUs IDEsIE5VTEwsIGZhbHNlLCAmYXMsICZ2YXJfbG9jdXMpKQogICAgIHsKICAg ICAgIG0gPSBNQVRDSF9FUlJPUjsKICAgICAgIGdvdG8gY2xlYW51cDsKZGlm ZiAtLWdpdCBhL2djYy9mb3J0cmFuL3RyYW5zLWFycmF5LmNjIGIvZ2NjL2Zv cnRyYW4vdHJhbnMtYXJyYXkuY2MKaW5kZXggMzBiODQ3NjIzNDYuLjMyMmZm NTUyODEzIDEwMDY0NAotLS0gYS9nY2MvZm9ydHJhbi90cmFucy1hcnJheS5j YworKysgYi9nY2MvZm9ydHJhbi90cmFucy1hcnJheS5jYwpAQCAtMTE3NTYs OCArMTE3NTYsMTYgQEAgZ2ZjX3dhbGtfdmFyaWFibGVfZXhwciAoZ2ZjX3Nz ICogc3MsIGdmY19leHByICogZXhwcikKICAgZ2ZjX2ZpeF9jbGFzc19yZWZz IChleHByKTsKIAogICBmb3IgKHJlZiA9IGV4cHItPnJlZjsgcmVmOyByZWYg PSByZWYtPm5leHQpCi0gICAgaWYgKHJlZi0+dHlwZSA9PSBSRUZfQVJSQVkg JiYgcmVmLT51LmFyLnR5cGUgIT0gQVJfRUxFTUVOVCkKLSAgICAgIGJyZWFr OworICAgIHsKKyAgICAgIGlmIChyZWYtPnR5cGUgPT0gUkVGX0NPTVBPTkVO VAorCSAgJiYgcmVmLT51LmMuY29tcG9uZW50LT5hdHRyLmZ1bmN0aW9uKQor CXsKKwkgIHJlZiA9IE5VTEw7CisJICBicmVhazsKKwl9CisgICAgICBpZiAo cmVmLT50eXBlID09IFJFRl9BUlJBWSAmJiByZWYtPnUuYXIudHlwZSAhPSBB Ul9FTEVNRU5UKQorICAgICAgICAgIGJyZWFrOworICAgIH0KIAogICByZXR1 cm4gZ2ZjX3dhbGtfYXJyYXlfcmVmIChzcywgZXhwciwgcmVmKTsKIH0KZGlm ZiAtLWdpdCBhL2djYy90ZXN0c3VpdGUvZ2ZvcnRyYW4uZGcvcHI4OTQ2Mi5m OTAgYi9nY2MvdGVzdHN1aXRlL2dmb3J0cmFuLmRnL3ByODk0NjIuZjkwCm5l dyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwLi5iMmE0OTEy ZmNjOAotLS0gL2Rldi9udWxsCisrKyBiL2djYy90ZXN0c3VpdGUvZ2ZvcnRy YW4uZGcvcHI4OTQ2Mi5mOTAKQEAgLTAsMCArMSwxMyBAQAorISB7IGRnLWRv IGNvbXBpbGUgfQorISB7IGRnLW9wdGlvbnMgIi1wZWRhbnRpYy1lcnJvcnMi IH0KKyEgVGVzdCB0aGUgZml4IGZvciBQUjg5NDYyIGluIHdoaWNoIHRoZSBz aGFyZWQgJ2NsJyBmaWVsZCBvZiB0aGUgdHlwZXNwZWMKKyEgc2hhcmVkIGJl dHdlZW4gJ3Rlc3QnLCAnVFInIGFuZCAnYVRQJyBjYXVzZWQgdGhlIGNvbXBp bGVyIHRvIGdvIGludG8gYW4KKyEgaW5maW5pdGUgbG9vcC4KKyEgQ29udHJp YnV0ZWQgYnkgU2VyZ2VpIFRyb2ZpbW92aWNoICA8c2x5aWNoQGdtYWlsLmNv bT4KKyAgQ0hBUkFDVEVSKjEgRlVOQ1RJT04gdGVzdChIKSAhIHsgZGctd2Fy bmluZyAiT2xkLXN0eWxlIGNoYXJhY3RlciBsZW5ndGgiIH0KKyAgICAgQ0hB UkFDVEVSKjEgdGVzdDIsVFIsYVRQICAhIHsgZGctd2FybmluZyAiT2xkLXN0 eWxlIGNoYXJhY3RlciBsZW5ndGgiIH0KKyAgICAgRU5UUlkgdGVzdDIoTCkK KyAgICAgQ0FMTCB0dGVzdDMoYVRQKQorICAgICB0ZXN0ID0gVFIKKyAgICAg UkVUVVJOCisgIEVORAo= --00000000000089b3b90616d174ee--