From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12251 invoked by alias); 23 Aug 2014 16:59:19 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 12233 invoked by uid 89); 23 Aug 2014 16:59:18 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: mail-wi0-f175.google.com Received: from mail-wi0-f175.google.com (HELO mail-wi0-f175.google.com) (209.85.212.175) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Sat, 23 Aug 2014 16:59:17 +0000 Received: by mail-wi0-f175.google.com with SMTP id ho1so879949wib.14 for ; Sat, 23 Aug 2014 09:59:14 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.180.80.165 with SMTP id s5mr4755811wix.61.1408813154057; Sat, 23 Aug 2014 09:59:14 -0700 (PDT) Received: by 10.216.188.71 with HTTP; Sat, 23 Aug 2014 09:59:14 -0700 (PDT) In-Reply-To: References: Date: Sat, 23 Aug 2014 16:59:00 -0000 Message-ID: Subject: Re: [patch] PR fortran/61669 From: Paul Richard Thomas To: Steven Bosscher Cc: "fortran@gcc.gnu.org" , GCC Patches Content-Type: text/plain; charset=UTF-8 X-SW-Source: 2014-08/txt/msg02256.txt.bz2 Dear Steven, I am constantly amazed that data statement bugs keep turning up:-) Anyway, your fix is fine for trunk and, if you feel so inclined, 4.8 and 4.9. Thanks Paul On 23 August 2014 16:52, Steven Bosscher wrote: > Hello, > > This bug is an error recovery issue. A data declaration is parsed and > accepted, and added to gfc_current_ns->data, but the statement is > rejected. The rejected data decl is not rolled back, causing memory > corruption later on. > > Proposed fix is to roll back DATA for rejected statements. > > Bootstrapped&tested on powerpc64-unknown-linux-gnu. OK for trunk? > > Ciao! > Steven -- The knack of flying is learning how to throw yourself at the ground and miss. --Hitchhikers Guide to the Galaxy