Re: [Patch][Fortran] Fix error cleanup of select rank (PR93522)

[Paul Richard Thomas <paul.richard.thomas@gmail.com>]

Hi Tobias,

I would say that if any patch were obvious, that one is :-) OK.

Thanks

Paul


On Mon, 30 Mar 2020 at 09:16, Tobias Burnus <tobias@codesourcery.com> wrote:

> Early *ping*.
>
> Tobias
>
> On 3/27/20 11:06 AM, Tobias Burnus wrote:
>
> > Hi all,
> >
> > here, the reject_statement cleanup and the freeing of the
> > namespace both remove the symbol. Solution: Remove it first,
> > then clean the namespace – then the reject_statement has no
> > (deleted) statement to cleanup.
> >
> > As select rank is new, that's again a GCC-10 only
> > regression (of invalid code).
> >
> > OK?
> >
> > Tobias
> >
> > PS: valgrind shows
> > ==71237==    definitely lost: 0 bytes in 0 blocks
> > ==71237==    indirectly lost: 0 bytes in 0 blocks
> > ==71237==      possibly lost: 0 bytes in 0 blocks
> > I did ignore:
> > ==52255==    still reachable: 500,682 bytes in 2,181 blocks
> > which is the same also with 'select... end select' commented.
> >
> -----------------
> Mentor Graphics (Deutschland) GmbH, Arnulfstraße 201, 80634 München /
> Germany
> Registergericht München HRB 106955, Geschäftsführer: Thomas Heurung,
> Alexander Walter
>


-- 
"If you can't explain it simply, you don't understand it well enough" -
Albert Einstein