public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Paul Richard Thomas <paul.richard.thomas@gmail.com>
To: Steve Kargl <sgk@troutmask.apl.washington.edu>
Cc: "fortran@gcc.gnu.org" <fortran@gcc.gnu.org>,
	gcc-patches <gcc-patches@gcc.gnu.org>,
		Damian Rouson <damian@sourceryinstitute.org>
Subject: Re: [Patch, fortran} pr68196 [4.9/5 Regression] ICE on function result with procedure pointer component
Date: Fri, 18 Dec 2015 09:41:00 -0000	[thread overview]
Message-ID: <CAGkQGiKkr6ssynsvmjFZ5wusDCOMaZRGnTDx25isxQNjJEBoxQ@mail.gmail.com> (raw)

Dear Steve,

Thanks - committed as revision 231807. I will have a poke around to
see if there are any more similar opportunities for infinite recursion
in trans-array.c (structure_alloc_comps). This turned out to be the
most difficult part of the patch for recursive allocatable components
(on hold until 7 branch) for rather obvious reasons; the solution
there is rather different since it is required that recursion occurs
on deallocation and this necessitates an explicit call to the
finalizer in structure_alloc_comps, instead of a call to itself.

Cheers

Paul

On 18 December 2015 at 04:56, Steve Kargl
<sgk@troutmask.apl.washington.edu> wrote:
> On Thu, Dec 17, 2015 at 11:12:17PM +0100, Paul Richard Thomas wrote:
>>
>> Some problems have come up that are not dissimilar to the original
>> bug, involving infinite recursion with procedure components, with the
>> same type as the containing type. The fix is verging on the trivial.
>> However, given that I found two further bugs in fixing the one
>> reported, I worry that there are more lurking nearby.
>>
>> Bootstraps and regtests on x86_64 - OK for trunk and, in a couple of
>> weeks 5 and 4.9 branches?
>>
>
> OK.
>
> Do you have a testcase that should also be committed?
>
> --
> Steve

             reply	other threads:[~2015-12-18  9:41 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-18  9:41 Paul Richard Thomas [this message]
  -- strict thread matches above, loose matches on Subject: below --
2015-12-17 22:12 Paul Richard Thomas
2015-12-18  3:56 ` Steve Kargl
2015-12-18  9:28   ` Paul Richard Thomas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAGkQGiKkr6ssynsvmjFZ5wusDCOMaZRGnTDx25isxQNjJEBoxQ@mail.gmail.com \
    --to=paul.richard.thomas@gmail.com \
    --cc=damian@sourceryinstitute.org \
    --cc=fortran@gcc.gnu.org \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=sgk@troutmask.apl.washington.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).