From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24005 invoked by alias); 1 Nov 2011 21:08:06 -0000 Received: (qmail 23982 invoked by uid 22791); 1 Nov 2011 21:08:05 -0000 X-SWARE-Spam-Status: No, hits=-2.2 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from mail-ey0-f175.google.com (HELO mail-ey0-f175.google.com) (209.85.215.175) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 01 Nov 2011 21:07:50 +0000 Received: by eyd9 with SMTP id 9so7608713eyd.20 for ; Tue, 01 Nov 2011 14:07:49 -0700 (PDT) MIME-Version: 1.0 Received: by 10.14.9.204 with SMTP id 52mr120081eet.162.1320181668961; Tue, 01 Nov 2011 14:07:48 -0700 (PDT) Received: by 10.14.37.68 with HTTP; Tue, 1 Nov 2011 14:07:48 -0700 (PDT) In-Reply-To: <20111027232818.18581.901@gimli.local> References: <20111027232818.18581.901@gimli.local> Date: Tue, 01 Nov 2011 21:33:00 -0000 Message-ID: Subject: Re: [Patch, fortran] [00/66] PR fortran/43829 Inline sum and product (AKA scalarization of reductions) From: Paul Richard Thomas To: Mikael Morin Cc: gfortran , GCC patches Content-Type: text/plain; charset=ISO-8859-1 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-11/txt/msg00090.txt.bz2 Dear Mikael, > PS: I hereby confess my failure to not split the patch too much. :-( I hereby confess my failure to find anything to which I could gripe, let alone object! The patch can only be described as a tour de force. Not only is there a lot of it - 6160 lines with context on - but it is well commented and well structured. I cannot see any whitespace out of place or even minor transgressions in respect of gnu coding style. Bah humbug! On top of all that, it even does what is promised! Also, other testers have run it through various benchmarks, as recent threads attest. The only, slight worry that I have is that it is going to make Richi's middle end scalarization nearly impossible to use for gfortran. However, the enhanced capability that this patch brings makes it a worthy addition to gfortran. I bootstrapped and regtested on FC9/x86_64, just for the record. OK for trunk. Many, many thanks for the patch. Paul