From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x52d.google.com (mail-pg1-x52d.google.com [IPv6:2607:f8b0:4864:20::52d]) by sourceware.org (Postfix) with ESMTPS id 8B4073858CD1; Tue, 19 Mar 2024 17:25:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8B4073858CD1 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 8B4073858CD1 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::52d ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710869124; cv=none; b=RWPDpyAwE72pKvB8MoJ2IJDC6AzJFR/PPwcKYLJsrpj/ZM+lyrPhTknRG8KV6AEOq1ChHIntZSaKl3WS0UsNZJCvfyefT0WkRlUVg2MNCe0Lxfi8Sph7z1gZXantxLEQ76kEeUztMgSm8Nqf6lLQWgKuAmm033Tg9PTupAJLp8I= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710869124; c=relaxed/simple; bh=3tTjQmEO2B+89/j8GBr0V4a580iVWhGXLXoWq9hZupU=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=MVGw9Sk4R8tIraPT6mD0U4X8U8mYaLXV0FXqRIWSLNFC0ZQxD28N/6wvRFjnjF0JlI+ZmMFFIxrvvpG0m4KBlrnlRPJsMjSkBXOqfmdpZ1p7+FLdkN9mm65U1P5R9AnL2BUKQgCk2DK9zQk59F7kPx7cV/MU2cbAryARJbbj+Eg= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pg1-x52d.google.com with SMTP id 41be03b00d2f7-5bdbe2de25fso4427087a12.3; Tue, 19 Mar 2024 10:25:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1710869120; x=1711473920; darn=gcc.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=wj6bQPJbo33xXj17dgDHrg4uAk1AxVW9YJNfkZZysgA=; b=EgYteC+deihc6330qSiB2Y+4F8Jn4Aw1WV8BTY2BAxSpO0tYJfOicVJUGijVEDmFbu /yjSEIReQzfa61QDsuNFrCZ5qL14lLNu1hBb4gH6XjYlnTwK197nh6NtsjK1Boi/NSQw BxcvtgPtyBdcAWnRfoUcC/zgWs6OiJLaRzgjYnwXb6X/zCwNjnmCZVYaoywwFjQY3wZY EUVm5K31GGnXiMcjh9/dQTSaS8iktZBTQ9GN2DqWd1z4zXVfIdmlNMVGmNQF4IxCFsK4 kaH8cCqN/iUc45GIJgf82ReqANcMOCfyqxVUQwaXsz2keXZ23vPy8JxAvyS0WgpylBSN FTOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710869120; x=1711473920; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=wj6bQPJbo33xXj17dgDHrg4uAk1AxVW9YJNfkZZysgA=; b=WkL3qL/Z7vmEMsecQyomMFgvdKVoHtRcxDkkSJlFHNfxQ8tFAzUQTq8R9XinLNDxZG iGebJ3YgAkIGQbNQcbmLpVnQg7V8lmEs29TctcImT8UnUNzMQQ/TFlIsM496D7sFJpMZ PvYMqE88dRdLPM5kIzrs7MqbdkXMX0v2MSAIuspZWoFl+hOhGjeNXc+Y/PpfkuKmiMBP aEt2rMSy6uavc2Ml+D/6HB12yHeWDHBc9GSqKeP7mmslSudfxk94qyYbtEo3SgNlf20Z Q9QerwWVY2dh/WAs6okEVTXhE30tGSsWzlXcGpuPGJMaVVZTqoq0ptkrLbUfe3JsmiUo lkEw== X-Forwarded-Encrypted: i=1; AJvYcCVqDxBcK3GNs0/5bShOdniGX+yf4w7gZylEvUnpIFDqwTVVB3xsrs0RoTcPzxFMvXj8wFVr0dh4yu/GuraSRMZX1OrIvJ0MDA== X-Gm-Message-State: AOJu0YygQf3oMkMDkZU+K7Lh2VZeVws3ZtXre+5lf0B+5sYO3iPvL4YV eGHt16ZpYQyqAuIXNlrwplXjvTrkjMntADEQTmxgqoRNiGv4r0GeGoOkflCYPdshkXmQP1qF9SJ iKU4yMXGQ8ebgB6vhPKomVatduNocrpSu X-Google-Smtp-Source: AGHT+IHgkVRFArYvkPL4lOP4uR0/Slj9NqmLW4EYFm1bb4/RBqS3f03a6uRfnkX7TbSSTojyfXwL1tR4bQ6N3ASrwm4= X-Received: by 2002:a05:6a21:a58d:b0:1a1:67a6:bba7 with SMTP id gd13-20020a056a21a58d00b001a167a6bba7mr21041233pzc.1.1710869119980; Tue, 19 Mar 2024 10:25:19 -0700 (PDT) MIME-Version: 1.0 References: <20240319154918.272178-1-mikael@gcc.gnu.org> <20240319154918.272178-2-mikael@gcc.gnu.org> In-Reply-To: <20240319154918.272178-2-mikael@gcc.gnu.org> From: Paul Richard Thomas Date: Tue, 19 Mar 2024 17:25:08 +0000 Message-ID: Subject: Re: [PATCH v3 1/2] testsuite: Declare fortran array bound variables To: Mikael Morin Cc: fortran@gcc.gnu.org, gcc-patches@gcc.gnu.org Content-Type: multipart/alternative; boundary="000000000000276ef5061406c2fb" X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --000000000000276ef5061406c2fb Content-Type: text/plain; charset="UTF-8" Hi Mikael, This looks completely "obvious" to me. OK for mainline and, I would suggest, 13-branch. Thanks Paul On Tue, 19 Mar 2024 at 15:49, Mikael Morin wrote: > This fixes invalid undeclared fortran array bound variables > in the testsuite. > > gcc/testsuite/ChangeLog: > > * gfortran.dg/graphite/pr107865.f90: Declare array bound > variable(s) > as dummy argument(s). > * gfortran.dg/pr101267.f90: Likewise. > * gfortran.dg/pr112404.f90: Likewise. > * gfortran.dg/pr78061.f: Likewise. > * gfortran.dg/pr79315.f90: Likewise. > * gfortran.dg/vect/pr90681.f: Likewise. > * gfortran.dg/vect/pr97761.f90: Likewise. > * gfortran.dg/vect/pr99746.f90: Likewise. > --- > gcc/testsuite/gfortran.dg/graphite/pr107865.f90 | 2 +- > gcc/testsuite/gfortran.dg/pr101267.f90 | 2 +- > gcc/testsuite/gfortran.dg/pr112404.f90 | 2 +- > gcc/testsuite/gfortran.dg/pr78061.f | 2 +- > gcc/testsuite/gfortran.dg/pr79315.f90 | 6 +++++- > gcc/testsuite/gfortran.dg/vect/pr90681.f | 2 +- > gcc/testsuite/gfortran.dg/vect/pr97761.f90 | 2 +- > gcc/testsuite/gfortran.dg/vect/pr99746.f90 | 2 +- > 8 files changed, 12 insertions(+), 8 deletions(-) > > diff --git a/gcc/testsuite/gfortran.dg/graphite/pr107865.f90 > b/gcc/testsuite/gfortran.dg/graphite/pr107865.f90 > index 6bddb17a1be..323d8092ad2 100644 > --- a/gcc/testsuite/gfortran.dg/graphite/pr107865.f90 > +++ b/gcc/testsuite/gfortran.dg/graphite/pr107865.f90 > @@ -1,7 +1,7 @@ > ! { dg-do compile } > ! { dg-options "-O1 -floop-parallelize-all -ftree-parallelize-loops=2" } > > - SUBROUTINE FNC (F) > + SUBROUTINE FNC (F,N) > > IMPLICIT REAL (A-H) > DIMENSION F(N) > diff --git a/gcc/testsuite/gfortran.dg/pr101267.f90 > b/gcc/testsuite/gfortran.dg/pr101267.f90 > index 12723cf9c22..99a6dcfa342 100644 > --- a/gcc/testsuite/gfortran.dg/pr101267.f90 > +++ b/gcc/testsuite/gfortran.dg/pr101267.f90 > @@ -1,7 +1,7 @@ > ! { dg-do compile } > ! { dg-options "-Ofast" } > ! { dg-additional-options "-march=znver2" { target x86_64-*-* i?86-*-* } } > - SUBROUTINE sfddagd( regime, znt,ite ,jte ) > + SUBROUTINE sfddagd( regime, znt,ite ,jte, ime, IN ) > REAL, DIMENSION( ime, IN) :: regime, znt > REAL, DIMENSION( ite, jte) :: wndcor_u > LOGICAL wrf_dm_on_monitor > diff --git a/gcc/testsuite/gfortran.dg/pr112404.f90 > b/gcc/testsuite/gfortran.dg/pr112404.f90 > index 573fa28164a..4508bbc8738 100644 > --- a/gcc/testsuite/gfortran.dg/pr112404.f90 > +++ b/gcc/testsuite/gfortran.dg/pr112404.f90 > @@ -1,7 +1,7 @@ > ! { dg-do compile } > ! { dg-options "-Ofast" } > ! { dg-additional-options "-mavx2" { target avx2 } } > - SUBROUTINE sfddagd( regime, znt, ite, jte ) > + SUBROUTINE sfddagd( regime, znt, ite, jte, ime, IN ) > REAL, DIMENSION( ime, IN) :: regime, znt > REAL, DIMENSION( ite, jte) :: wndcor_u > LOGICAL wrf_dm_on_monitor > diff --git a/gcc/testsuite/gfortran.dg/pr78061.f > b/gcc/testsuite/gfortran.dg/pr78061.f > index 7e4dd3de8b5..9061dea74da 100644 > --- a/gcc/testsuite/gfortran.dg/pr78061.f > +++ b/gcc/testsuite/gfortran.dg/pr78061.f > @@ -1,6 +1,6 @@ > ! { dg-do compile } > ! { dg-options "-O3 -fsplit-loops" } > - SUBROUTINE SSYMM(C) > + SUBROUTINE SSYMM(C,LDC) > REAL C(LDC,*) > LOGICAL LSAME > LOGICAL UPPER > diff --git a/gcc/testsuite/gfortran.dg/pr79315.f90 > b/gcc/testsuite/gfortran.dg/pr79315.f90 > index 8cd89691ce9..b754a2b3274 100644 > --- a/gcc/testsuite/gfortran.dg/pr79315.f90 > +++ b/gcc/testsuite/gfortran.dg/pr79315.f90 > @@ -10,7 +10,11 @@ SUBROUTINE wsm32D(t, & > its,& > ite, & > kts, & > - kte & > + kte, & > + ims, & > + ime, & > + kms, & > + kme & > ) > REAL, DIMENSION( its:ite , kts:kte ), & > INTENT(INOUT) :: & > diff --git a/gcc/testsuite/gfortran.dg/vect/pr90681.f > b/gcc/testsuite/gfortran.dg/vect/pr90681.f > index 03d3987b146..49f1d50ab8f 100644 > --- a/gcc/testsuite/gfortran.dg/vect/pr90681.f > +++ b/gcc/testsuite/gfortran.dg/vect/pr90681.f > @@ -1,6 +1,6 @@ > C { dg-do compile } > C { dg-additional-options "-march=armv8.2-a+sve" { target { aarch64*-*-* > } } } > - SUBROUTINE HMU (H1) > + SUBROUTINE HMU (H1,NORBS) > COMMON DD(107) > DIMENSION H1(NORBS,*) > DO 70 J1 = IA,I1 > diff --git a/gcc/testsuite/gfortran.dg/vect/pr97761.f90 > b/gcc/testsuite/gfortran.dg/vect/pr97761.f90 > index 250e2bf016e..401ef06e422 100644 > --- a/gcc/testsuite/gfortran.dg/vect/pr97761.f90 > +++ b/gcc/testsuite/gfortran.dg/vect/pr97761.f90 > @@ -1,7 +1,7 @@ > ! { dg-do compile } > ! { dg-additional-options "-O1" } > > -subroutine ni (ps) > +subroutine ni (ps, inout) > type vector > real x, y > end type > diff --git a/gcc/testsuite/gfortran.dg/vect/pr99746.f90 > b/gcc/testsuite/gfortran.dg/vect/pr99746.f90 > index fe947ae7ccf..121d67d564d 100644 > --- a/gcc/testsuite/gfortran.dg/vect/pr99746.f90 > +++ b/gcc/testsuite/gfortran.dg/vect/pr99746.f90 > @@ -1,6 +1,6 @@ > ! { dg-do compile } > ! { dg-additional-options "-march=armv8.3-a" { target aarch64-*-* } } > -SUBROUTINE CLAREF(A, WANTZ, Z, ICOL1, ITMP1, ITMP2, T1, T2, V2) > +SUBROUTINE CLAREF(A, WANTZ, Z, ICOL1, ITMP1, ITMP2, T1, T2, V2, LDA) > LOGICAL BLOCK, WANTZ > COMPLEX T1, T2, V2 > COMPLEX A(LDA, *), VECS, Z(LDA, *) > -- > 2.43.0 > > --000000000000276ef5061406c2fb--