From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2676 invoked by alias); 21 Jul 2016 10:54:34 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 2656 invoked by uid 89); 21 Jul 2016 10:54:33 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=genius, H*i:sk:1ec267d, H*f:sk:1ec267d X-Spam-User: qpsmtpd, 2 recipients X-HELO: mail-yw0-f178.google.com Received: from mail-yw0-f178.google.com (HELO mail-yw0-f178.google.com) (209.85.161.178) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Thu, 21 Jul 2016 10:54:23 +0000 Received: by mail-yw0-f178.google.com with SMTP id u134so70184616ywg.3; Thu, 21 Jul 2016 03:54:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=eD0lz1cdBRVWtAVMiy8zovHro6DyqIejOIuapv5+0UY=; b=ivLOJPW1SEUycwEnBsqUT1YVlw7eFr5eUEnSrwGQHJJJLRlukao5ilXkeakC/mxkMP I57IfLugOoEXHSGMGdL9lYWhSonYnI+/yy6weFahhvBjbJfXvDzCxuz3Z/XvaRLy5BvL iTTkmYbztB/VLgql0lo1sf0JF8emc4i3J1zkAgqUGlbthhpt5TiX+dChZ9OJkSZQTv8s IwxjGYF1+lYeUgbmpzJbjlWQlcVY6Bq4PjDF3Rvj0XBLxXHAqYUL9870r7oDAKQL2yQU hFJJjLTViNCMCBYyTA2U0srdUbzrcfhAJTDLaXe9P9yyU2r3zUujlsN9x7LG1TNugylU 8vIA== X-Gm-Message-State: ALyK8tL9cQaLkiTTT/O++r7HSlY5oKk/tVs+I9D6XaFBRaR9RHALQ7i5WeiyaBwmQAuMN4GKTmHxIpLBB2Gs1g== X-Received: by 10.13.205.1 with SMTP id p1mr15150568ywd.230.1469098461260; Thu, 21 Jul 2016 03:54:21 -0700 (PDT) MIME-Version: 1.0 Received: by 10.13.252.134 with HTTP; Thu, 21 Jul 2016 03:54:20 -0700 (PDT) In-Reply-To: <1ec267d3-4e9e-e56a-e7a4-3bbdca9412cd@codesourcery.com> References: <2b4f59d5-be38-2814-27bb-73aa7ffb4b8f@codesourcery.com> <7db676cf-e30d-f37c-d173-169b2d9eebf4@codesourcery.com> <57862B95.7080002@codesourcery.com> <1ec267d3-4e9e-e56a-e7a4-3bbdca9412cd@codesourcery.com> From: Paul Richard Thomas Date: Thu, 21 Jul 2016 10:54:00 -0000 Message-ID: Subject: Re: [PATCH, Fortran, OpenACC] Fix PR70598, Fortran host_data ICE (ping x4) To: Chung-Lin Tang Cc: Bernhard Reutner-Fischer , "fortran@gcc.gnu.org" , gcc-patches , Thomas Schwinge , Jakub Jelinek Content-Type: text/plain; charset=UTF-8 X-SW-Source: 2016-07/txt/msg01363.txt.bz2 Hi Chung-Lin, I was ignoring your patch on the grounds that one of the omp gurus should deal with it. That says, it looks OK for trunk to me. I presume that fortran/host_data-1.f90 should have the XFAIL removed? Cheers Paul On 21 July 2016 at 11:28, Chung-Lin Tang wrote: > Ping x4 > > On 2016/7/13 7:52 PM, Chung-Lin Tang wrote: >> Ping x3 >> >> On 06/21/2016 02:18 PM, Chung-Lin Tang wrote: >>> Ping x2 >>> >>> On 2016/6/7 08:03 PM, Chung-Lin Tang wrote: >>>> Ping. >>>> >>>> On 2016/5/11 02:57 AM, Bernhard Reutner-Fischer wrote: >>>>> On May 9, 2016 4:26:50 PM GMT+02:00, Chung-Lin Tang wrote: >>>>>> Hi, this patch resolves an ICE for Fortran when using the OpenACC >>>>>> host_data directive. Actually, rather than say resolve, it's more like >>>>>> adjusting the front-end to same middle-end restrictions as C/C++, >>>>>> namely that we only support pointers or arrays for host_data right now. >>>>>> >>>>>> This patch contains a little bit of adjustments in >>>>>> fortran/openmp.c:resolve_omp_clauses(), >>>>>> and some testcase adjustments. This has been tested without regressions >>>>>> for Fortran. >>>>>> >>>>>> Is this okay for trunk? >>>>>> >>>>>> Thanks, >>>>>> Chung-Lin >>>>>> >>>>>> 2015-05-09 Chung-Lin Tang >>>>>> >>>>>> gcc/ >>>>>> * fortran/openmp.c (resolve_omp_clauses): Adjust use_device clause >>>>>> handling to only allow pointers and arrays. >>>>> >>>>> Fortran has it's own ChangeLog. The patch itself looks somewhat plausible to me, fwiw, but Jakub or a FE maintainer has the >>>>> say. >>>>> >>>> >>> > -- The difference between genius and stupidity is; genius has its limits. Albert Einstein