public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Paul Richard Thomas <paul.richard.thomas@gmail.com>
To: Steve Kargl <sgk@troutmask.apl.washington.edu>
Cc: Thomas Koenig <tkoenig@netcologne.de>,
	Andrew Benson <abenson@carnegiescience.edu>,
		"fortran@gcc.gnu.org" <fortran@gcc.gnu.org>,
	gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [patch, fortran] PR93486 - ICE on valid with nested submodules and long submodule names
Date: Mon, 02 Mar 2020 06:42:00 -0000	[thread overview]
Message-ID: <CAGkQGiLe14QhLG4xwSc=cx9HoWP-UR1rzf5Y9ManELQv7-q0eA@mail.gmail.com> (raw)
In-Reply-To: <20200302021003.GA65843@troutmask.apl.washington.edu>

Andrew,

I agree with Steve. That said, I took a look at your patch and it's
just fine. OK to commit.

Cheers

Paul

On Mon, 2 Mar 2020 at 02:10, Steve Kargl
<sgk@troutmask.apl.washington.edu> wrote:
>
> On Sun, Mar 01, 2020 at 11:43:23PM +0100, Thomas Koenig wrote:
> > Am 01.03.20 um 23:42 schrieb Steve Kargl:
> > > PS: in general, after multiple
> > > pings, just commit the patch.
> >
> > ... well, maybe after a "If there is no reply within a
> > couple of days, I will commit this" :-)
> >
>
> Andrew submitted the patch and pinged it twice.  gfortran
> development is running on fumes.  Beating one's head
> against a wall seems counter productive.  I'm operating
> on a principle that if one has commit access for gfortran,
> one is committing a patch with the best attentions.  Could
> this lead to a regression?  Sure.  The alternative of
> constantly pinging patches is to simply stop submitting
> patches.
>
>
> --
> Steve



-- 
"If you can't explain it simply, you don't understand it well enough"
- Albert Einstein

  reply	other threads:[~2020-03-02  6:42 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-29  2:18 Andrew Benson
2020-02-11  0:22 ` Andrew Benson
2020-02-18 23:30 ` Andrew Benson
2020-02-25  0:45 ` Andrew Benson
2020-03-01 19:33 ` Andrew Benson
2020-03-01 22:42   ` Steve Kargl
2020-03-01 22:43     ` Andrew Benson
2020-03-01 22:43     ` Thomas Koenig
2020-03-02  2:10       ` Steve Kargl
2020-03-02  6:42         ` Paul Richard Thomas [this message]
2020-03-02 17:33           ` Andrew Benson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAGkQGiLe14QhLG4xwSc=cx9HoWP-UR1rzf5Y9ManELQv7-q0eA@mail.gmail.com' \
    --to=paul.richard.thomas@gmail.com \
    --cc=abenson@carnegiescience.edu \
    --cc=fortran@gcc.gnu.org \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=sgk@troutmask.apl.washington.edu \
    --cc=tkoenig@netcologne.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).