From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yb1-xb32.google.com (mail-yb1-xb32.google.com [IPv6:2607:f8b0:4864:20::b32]) by sourceware.org (Postfix) with ESMTPS id B09463858D34; Sat, 28 Aug 2021 07:41:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B09463858D34 Received: by mail-yb1-xb32.google.com with SMTP id e129so17133383yba.5; Sat, 28 Aug 2021 00:41:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=vTndoiqDgCq62g3GmhJmhSrEKwn8uBmXtFzPoZN8+EU=; b=Yo5SyFm9yvahuyeLKVAx/KY9X/bTbm1595IFRqsIG6tRxeafoeZ6b9KnJH8q9hpKYT /ypoTRhlV3FTsSC7kZVldS8GIubd4UK7ibaL4KVD9FhSXzJQ9KYUr58nAD2UKKa3SI2D yFT0Npj9taJrzmMMaDvWOsoqMPzS/7ZA2RK/PwzT9fz9r3RnNqtX1fEzbrui4ngenFrV HYzj5pl4wUvXQ9XL58LWfkoLUj1kl2malBpFpmIq537SqJ+sC4yN5/wHwgsdTTHqktp3 OzZxHF7TyCh1uBGjPoCJq9NuI9O3rjha/LevUdi6R4nSABkH7d2VJdnhqQULJoK/R4au tPnQ== X-Gm-Message-State: AOAM532D0Bt1DchHdoNcux1Wi/kF00mr65MNQhGs3/qW7QiSCrLPsUGv purDaSoOhzNz//qagX1LWQI53EDb/tSSkJrITug= X-Google-Smtp-Source: ABdhPJyUwJzm+XdvlMA/zOL2rOmxcEhlwsyfdvYukyM9n1Qk8P746ohUX8FLKcwGMVYREJ/GvC0tKsFzCwJmpHsoMfo= X-Received: by 2002:a05:6902:513:: with SMTP id x19mr10069056ybs.90.1630136492372; Sat, 28 Aug 2021 00:41:32 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Paul Richard Thomas Date: Sat, 28 Aug 2021 08:41:21 +0100 Message-ID: Subject: Re: [PATCH] PR fortran/87737 - ICE tree check: expected ssa_name, have addr_expr in remap_gimple_op_r, at tree-inline.c:923 To: Harald Anlauf Cc: fortran , gcc-patches X-Spam-Status: No, score=-0.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, HTML_MESSAGE, KAM_NUMSUBJECT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 28 Aug 2021 07:41:34 -0000 Hi Harald, It looks good to me. OK for mainline. You might even consider backporting to 11-branch. Best regards Paul On Fri, 27 Aug 2021 at 21:15, Harald Anlauf via Fortran wrote: > Dear all, > > the ICE in the original testcase does no longer occur but leads to an > error in a later stage of compilation, and we accepted invalid code. > (Cross-checked with other compilers, such as Intel and NAG). > > F2018 states: > > 15.6.2.6 ENTRY statement > > (3) ... If the characteristics of the result of the function named in the > ENTRY statement are the same as the characteristics of the result of the > function named in the FUNCTION statement, their result names identify the > same > entity, although their names need not be the same. Otherwise, they are > storage > associated and shall all be nonpointer, nonallocatable scalar variables > that > are default integer, default real, double precision real, default complex, > or > default logical. > > We thus better reject the testcase example during resolution with an > appropriate error message. (I hope the chosen one is fine enough.) > > Regtested on x86_64-pc-linux-gnu. OK for mainline? > > Thanks, > Harald > > > Fortran - reject function entries with mismatched characteristics > > gcc/fortran/ChangeLog: > > PR fortran/87737 > * resolve.c (resolve_entries): For functions of type CHARACTER > tighten the checks for matching characteristics. > > gcc/testsuite/ChangeLog: > > PR fortran/87737 > * gfortran.dg/entry_24.f90: New test. > > -- "If you can't explain it simply, you don't understand it well enough" - Albert Einstein