From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id A51C33857C56 for ; Wed, 29 Sep 2021 16:30:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A51C33857C56 Received: from mail-lf1-f71.google.com (mail-lf1-f71.google.com [209.85.167.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-258-C4Fc2XxcNISd1fXUfh_wRw-1; Wed, 29 Sep 2021 12:30:41 -0400 X-MC-Unique: C4Fc2XxcNISd1fXUfh_wRw-1 Received: by mail-lf1-f71.google.com with SMTP id o4-20020a056512230400b003fc39bb96c7so2914343lfu.8 for ; Wed, 29 Sep 2021 09:30:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=XA/QAxqUlnbqOlohSKbPLve64qncMgvU1YKKenG472g=; b=UzbEq7oQ5c+U/H1bao2KQZaTrk7eaZ2OYXYJBTIS0qjrsHLifryd7xee3ROPnZOlKh BzLPXc3AAmvduWwwaHgfYrWBtpzGUOn8xhyg/hmI6q3GGDJ6EcpvD5zb85uU2BOm2SAX y0emvuoLvMjpnm84MYBdS4MNuy1Z8mcWf+/N/Z7eOlcX+wA9LvK/WJA7eFk8fTZoGJWO 2FzrXAAjSUBKWK5fh2t9nvlumLgQsTjVmD0gI8SE9OKFadPk0r5H6pv1OrVRw2gU2qHP 02Hkwe+pbKc/VVI60/fgP+HUnNPY8Woj4Oh/tcdajnxnBjv28Q1zeOYgoaZUsEXxFNsr j4xw== X-Gm-Message-State: AOAM530dTouNkwmsqdG054RqqyFM+azEbpS7e6Wl0XGB2lp+n5w9+kVf OL0bwC+iX7E5F8Y2NbVDZHE5e3nU/o+uDxrIpineAnlZvKqUg9/JszlPkdr39ZCKks+FlMovJxK qkhYWazjTqO+DrMmkMCdWrg3nxAgailFUCw== X-Received: by 2002:a05:651c:88a:: with SMTP id d10mr845828ljq.439.1632933040173; Wed, 29 Sep 2021 09:30:40 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw0oZwKQdJYe+94airt7L89kfNzeePjTvouDl+lqitiFo3BS3sOxuBn05qofNz88s0FQSsQGs6D5KJHbShq3H0= X-Received: by 2002:a05:651c:88a:: with SMTP id d10mr845798ljq.439.1632933039926; Wed, 29 Sep 2021 09:30:39 -0700 (PDT) MIME-Version: 1.0 References: <20210929152607.1270206-1-aldyh@redhat.com> <5846635e-bf99-317e-4ae8-abc87d02ba96@gmail.com> In-Reply-To: <5846635e-bf99-317e-4ae8-abc87d02ba96@gmail.com> From: Aldy Hernandez Date: Wed, 29 Sep 2021 18:30:29 +0200 Message-ID: Subject: Re: [PATCH] Use a separate TV_* timer for the VRP threader. To: Jeff Law Cc: Andrew MacLeod , GCC patches X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-6.2 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, KAM_SHORT, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Sep 2021 16:30:47 -0000 On Wed, Sep 29, 2021 at 5:31 PM Jeff Law wrote: > > > > On 9/29/2021 9:26 AM, Aldy Hernandez wrote: > > There seems to be a memory consumption issue on 32 bit hosts after the > > hybrid threader patchset. I'm having a hard time reproducing, and in > > the process I've noticed that the threader is using the TV_TREE_VRP > > timer. Having a distinct one could help diagnose this and other > > issues going forward. > > > > Jeff, if you think this could help, I'd like to push this to trunk, but > > if not, I'm perfectly happy attaching it to the 2 PRs for now. :) > > > > gcc/ChangeLog: > > > > * timevar.def (TV_TREE_VRP_THREADER): New. > > * tree-vrp.c: Use TV_TREE_VRP_THREADER for VRP threader pass. > OK. > > And just to be clear, I'm talking about slowing down on refactoring and > the like. Bugfixes, dumping improvements and the like can and should go > forward. ACK. In that case, is it ok to push the changes to the testsuite fixing PPC64 and others? https://gcc.gnu.org/pipermail/gcc-patches/2021-September/580411.html Thanks. Aldy