From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id BD4513858D33 for ; Wed, 1 Mar 2023 10:08:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BD4513858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1677665324; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6B7xnQ/om62m5Fhz3+0o1hGtFQiBsJw8wJ10R7d7Kyw=; b=J0nTcJMf5IL/kK+sgXzdevHyCswk3ci97Y4trK8SHpe47nNbMdYWat97hWbYuxq98zl3dn oO0QFTi3d7sprA3hksZz7qVBXASycrNERJ8KsJZ4lyXvnkHD2peEj/VOY7ZXzRLAhLyrgN OoqULaWc63CDqBE94E58LCxZIqgO59I= Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-634-5Oa1Dy_cPuGd-FW6I6mtPA-1; Wed, 01 Mar 2023 05:08:43 -0500 X-MC-Unique: 5Oa1Dy_cPuGd-FW6I6mtPA-1 Received: by mail-ed1-f72.google.com with SMTP id w11-20020a05640234cb00b004b3247589b3so15824085edc.23 for ; Wed, 01 Mar 2023 02:08:43 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677665322; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6B7xnQ/om62m5Fhz3+0o1hGtFQiBsJw8wJ10R7d7Kyw=; b=U+2OwwnJiBEds+EIe5t8HdKcqG2/g9dM+h2z8lQhoCNsXJNXupksxnauTKirsXwqcz xLf8RmBC0KpgnIB6MF3EBO6o1U/5qH7ualpBM9ncZVrk+YqPLye7heIkSODawKYjGdaB FoZ6L7S6hdrIscCP153z4b9Ik+3k5DM/qwwFT06NVzgCGGEWlw0Oev9FaSNO4yssSf/+ j2dLhblkSp3zu9/zsa5HMp1369l0HP6bLnHmSt8p27iLChj1XZNaHBaaX5fHeCdGipbC jPYo49pRhKmb3oTfdIJppmP9mByvupi6Lbxky4eCqtsG16IpIYd4oTrddApYcXelTdVL LmuQ== X-Gm-Message-State: AO0yUKVA2sHHUFzsuMI+WWXALehe8epTGxaYCAP89W0xAq51VQGUmka2 MOhUwtCcD6kNx+mU8na2YsJS43r5+JG+zzF3Hi7hrU5fhKo7bZ/rNfxDrcF/JcneMgEd+2aNXEv 78q409PpaR+789SIIDs6/hLw7462oJ4mygQ== X-Received: by 2002:a17:906:271a:b0:877:7480:c561 with SMTP id z26-20020a170906271a00b008777480c561mr2937890ejc.1.1677665322352; Wed, 01 Mar 2023 02:08:42 -0800 (PST) X-Google-Smtp-Source: AK7set9CQfwFfl+Z9fh5jbeQFPcpU1NtDiGLToLTq0ShQFfEQ1PycJS9a1yXGMUpoEpooQiMZRKR7jQexmbUZgTgCmQ= X-Received: by 2002:a17:906:271a:b0:877:7480:c561 with SMTP id z26-20020a170906271a00b008777480c561mr2937879ejc.1.1677665322084; Wed, 01 Mar 2023 02:08:42 -0800 (PST) MIME-Version: 1.0 References: <20230228134718.2C43413440@imap2.suse-dmz.suse.de> In-Reply-To: <20230228134718.2C43413440@imap2.suse-dmz.suse.de> From: Aldy Hernandez Date: Wed, 1 Mar 2023 11:08:31 +0100 Message-ID: Subject: Re: [PATCH 1/5] fix anti-range dumping To: Richard Biener Cc: gcc-patches@gcc.gnu.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-11.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Ughh, you're touching everything I'm nuking next release ;-). But yes, that's an oversight. OK. On Tue, Feb 28, 2023 at 2:48=E2=80=AFPM Richard Biener via Gcc-patches wrote: > > when vrange_printer::visit gets a VR_ANTI_RANGE it should print it > as such, not just print the first element as range. When > irange::num_pairs and upper/lower_bound are fixed that would no > longer print a canonicalized anti-range. > > * value-range-pretty-print.cc (vrange_printer::visit): > Handle all VR_ANTI_RANGE specially. > --- > gcc/value-range-pretty-print.cc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gcc/value-range-pretty-print.cc b/gcc/value-range-pretty-pri= nt.cc > index d20e2562431..23817f48a3d 100644 > --- a/gcc/value-range-pretty-print.cc > +++ b/gcc/value-range-pretty-print.cc > @@ -64,7 +64,7 @@ vrange_printer::visit (const irange &r) const > return; > } > // Handle legacy symbolics. > - if (!r.constant_p ()) > + if (!r.constant_p () || r.kind () =3D=3D VR_ANTI_RANGE) > { > if (r.kind () =3D=3D VR_ANTI_RANGE) > pp_character (pp, '~'); > -- > 2.35.3 >