From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id CE93E3858408 for ; Fri, 29 Oct 2021 14:36:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org CE93E3858408 Received: from mail-lf1-f71.google.com (mail-lf1-f71.google.com [209.85.167.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-137-xG2Hoxr-OzqBDYDBDZx_LA-1; Fri, 29 Oct 2021 10:36:24 -0400 X-MC-Unique: xG2Hoxr-OzqBDYDBDZx_LA-1 Received: by mail-lf1-f71.google.com with SMTP id b12-20020a0565120b8c00b003ffa7050931so4174233lfv.13 for ; Fri, 29 Oct 2021 07:36:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Cd05Es2vcU8KRU41bp1XY/3LQVv9/WpHnojvjiHxao0=; b=hRrf2SJHg4g/+DcHoel8jBloYZxAHeClvEM9Y01LBnfk23iGB+HKv7UhKUXCwBcoFN KUMhq8KhKQxEm7ta6p6FMbhFRAzBZo63cbwPKLN4UVFuL7AAid3q7T+dNb5WhfuoOwLl 0mQCMYKAWTnrf7XIfrVwCfqKD0AlGDEMw+AK54cXmSRCUHCRDalIvrzGZVdvdhCW0p9S F2z/3X2Ol5AkqEkijQAD9Po37j1TdqdNVm47EjG0KSzwvd3M3QaIVGZt8kEDeFpJFMTX WCrfXeBuG8H/IVgjZdaky63sTdAMqzNxrx5eWiVgUV8aCeo1XzysDJ+NypkUAA3EA3nW aEIg== X-Gm-Message-State: AOAM531rDkQDp5rGE4+RzLmvPoTY4gNM7gD6I9yUJ7KJiW0pX5hJH2qJ ahueDQpAARYTplbx8BYQPzSTryJhl9XaTLhQmREW3yumQTHUo2O22qhC6DnYg7NUDH5+2ktLjMU fZmF8kDVVpNaz6iE2gpub80CySrOajrZc7Q== X-Received: by 2002:a2e:6a13:: with SMTP id f19mr11768771ljc.360.1635518182307; Fri, 29 Oct 2021 07:36:22 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzDnuXAaPTAoOxVSifC5iPxvzdQ8W4snRnlvBRyu3kc9LSiRkD1N1yDicFMXyHkEzMnkMx+DuPwpykB8P7vTxg= X-Received: by 2002:a2e:6a13:: with SMTP id f19mr11768737ljc.360.1635518182044; Fri, 29 Oct 2021 07:36:22 -0700 (PDT) MIME-Version: 1.0 References: <20211028152446.522454-1-aldyh@redhat.com> In-Reply-To: From: Aldy Hernandez Date: Fri, 29 Oct 2021 16:36:10 +0200 Message-ID: Subject: Re: [PATCH] Remove VRP threader passes in exchange for better threading pre-VRP. To: Richard Biener Cc: Jeff Law , GCC patches X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-5.8 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Oct 2021 14:36:29 -0000 On Fri, Oct 29, 2021 at 10:10 AM Richard Biener wrote: > > On Fri, Oct 29, 2021 at 10:06 AM Aldy Hernandez wrote: > > > > On Fri, Oct 29, 2021 at 9:30 AM Richard Biener > > wrote: > > > > > Btw, in case the "fully resolving" mode is slower than not fully resolving > > > please consider gating it on -fexpensive-optimizations (aka -O2+), thus > > > run the passes in not fully resolving modes at-O1. > > > > Sorry for the awkward naming. I couldn't find a better name :-/. > > Suggestions welcome. > > > > The fast mode assumes any unknown ranges on entry to a path to be > > VARYING, whereas the fully resolving mode will ask the ranger, so the > > fully resolving mode will indeed be slower. Though, I haven't > > measured how much. However, we are gaining some time in total > > compilation speed (1.32%) by replacing two threaders with one. > > OK. Just again, -O1 is to favor compile-speed and should crunch through > those incredibly stupi^Wlarge machine-generated sources without problems. > But from your comment it doesn't sound like something completely unreasonable > or slow. Oh, I just noticed...we already key off of -fexpensive-optimizations. Duh. The only backward threader that runs at -O1 is ethread, which does not fully resolve. So I think we're good. But your comment still applies when we kill the DOM threader and replace it with a pre-DOM fully resolving threader, since DOM does run at -O1. Ughhh.. I really hate that DOM is an evrp pass in disguise but at -O1. Aldy