From: Aldy Hernandez <aldyh@redhat.com>
To: Mikael Morin <morin-mikael@orange.fr>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [COMMITTED] Replace finite_operands_p with maybe_isnan.
Date: Thu, 20 Oct 2022 21:17:52 +0200 [thread overview]
Message-ID: <CAGm3qMUDQcHbDbjrjaoZUJ1YSoPa9w1CPpuMP-F25Ee_91mY2Q@mail.gmail.com> (raw)
In-Reply-To: <455087f8-5728-6eaa-9196-fc694d7d88db@orange.fr>
On Thu, Oct 20, 2022 at 8:59 PM Mikael Morin <morin-mikael@orange.fr> wrote:
>
> Le 20/10/2022 à 20:56, Mikael Morin a écrit :
> >
> > Doesn't this miss a check of flag_finite_math_only to be strictly
> > equivalent? You keep that check for the two-arguments case, so I guess
> > it's not redundant?
>
> Well, the check is removed in the follow-up patch, so maybe is is after all.
Good catch. I should indeed have added a check there, but as you
noted it was about to be removed ;-).
Thanks.
Aldy
prev parent reply other threads:[~2022-10-20 19:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-20 14:13 Aldy Hernandez
2022-10-20 14:13 ` [COMMITTED] Do not set NAN flags for VARYING ranges when !HONOR_NANS Aldy Hernandez
2022-10-20 18:56 ` [COMMITTED] Replace finite_operands_p with maybe_isnan Mikael Morin
2022-10-20 18:58 ` Mikael Morin
2022-10-20 19:17 ` Aldy Hernandez [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGm3qMUDQcHbDbjrjaoZUJ1YSoPa9w1CPpuMP-F25Ee_91mY2Q@mail.gmail.com \
--to=aldyh@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=morin-mikael@orange.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).