From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id EEBCA3858C20 for ; Tue, 16 Aug 2022 08:21:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org EEBCA3858C20 Received: from mail-oi1-f199.google.com (mail-oi1-f199.google.com [209.85.167.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-630-o_Qu_KL-MKGZql6Iv01kLA-1; Tue, 16 Aug 2022 04:21:57 -0400 X-MC-Unique: o_Qu_KL-MKGZql6Iv01kLA-1 Received: by mail-oi1-f199.google.com with SMTP id bc7-20020a056808170700b003351d0ad859so2434095oib.12 for ; Tue, 16 Aug 2022 01:21:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=5STAv3/AMJRBqTHBRQQxjgsvc2ELEMYFGdYLduCjyRA=; b=iFcoBjzZrWRZtUm8jFU4neWCb260+Tkfyuqw4f8V45SXpyv5i+NydKvcu4QYbtn8uD MjD94AQg2fvr7pIvoB75N66eTxzGD/UmsyBJ97Dt8z80dn4943WwyS69tsy6YZkVkbjl VPGl7rcPyY3I4XaFpJbKS/XHgH8bb03otFP2UgSNNQzS7uKKaIQIETiMBWVDm8jzulHX /t+2ldyrQwGdIkebZbKz9bNw833S1hFjstQBi4NNzFZJwl/eASSYa/MNm5oSQsyF/Xlf 1tndzhVU9IlL0iTBliqza/Rt6bmKgCzn7ZuLdMmr8qenLpIV5bJEv43lpiQ+lNrkdJfg K+iw== X-Gm-Message-State: ACgBeo3FODrrNx/8MRbLfdX9MEalBrADjr1htkIDR9vXwn99prMHNISA 0gi6vLgB8SWJCbltg4Xrs3lWrXCDf6XyJ/BuhgJ9rwLiDqzpuhsYEcsYae+bLBME3mWceOS1BmX /CsgqsNpof8V1qEA+JJy3RabGWx+Ul1WzvQ== X-Received: by 2002:a05:6830:3905:b0:636:b917:731 with SMTP id br5-20020a056830390500b00636b9170731mr7423946otb.276.1660638116923; Tue, 16 Aug 2022 01:21:56 -0700 (PDT) X-Google-Smtp-Source: AA6agR4FWkoSsR9R0jE2hKLcD6bzjpM10xBGQG5ZZFhjtu39oYkcYYL8o4vS4/qtDz5NU6LJsto+blxNn1sNdtVn5G0= X-Received: by 2002:a05:6830:3905:b0:636:b917:731 with SMTP id br5-20020a056830390500b00636b9170731mr7423939otb.276.1660638116734; Tue, 16 Aug 2022 01:21:56 -0700 (PDT) MIME-Version: 1.0 References: <73820.122081107421800679@us-mta-533.us.mimecast.lan> In-Reply-To: <73820.122081107421800679@us-mta-533.us.mimecast.lan> From: Aldy Hernandez Date: Tue, 16 Aug 2022 10:21:45 +0200 Message-ID: Subject: Re: [PATCH] Tame path_range_query::compute_imports To: Richard Biener Cc: gcc-patches , "MacLeod, Andrew" X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Aug 2022 08:22:02 -0000 On Thu, Aug 11, 2022 at 1:42 PM Richard Biener wrote: > @@ -599,6 +592,30 @@ path_range_query::compute_imports (bitmap imports, const vec &path) > worklist.safe_push (arg); > } > } > + else if (gassign *ass = dyn_cast (def_stmt)) > + { > + tree ssa[3]; > + if (range_op_handler (ass)) > + { > + ssa[0] = gimple_range_ssa_p (gimple_range_operand1 (ass)); > + ssa[1] = gimple_range_ssa_p (gimple_range_operand2 (ass)); > + ssa[2] = NULL_TREE; > + } > + else if (gimple_assign_rhs_code (ass) == COND_EXPR) > + { > + ssa[0] = gimple_range_ssa_p (gimple_assign_rhs1 (ass)); > + ssa[1] = gimple_range_ssa_p (gimple_assign_rhs2 (ass)); > + ssa[2] = gimple_range_ssa_p (gimple_assign_rhs3 (ass)); > + } > + else > + continue; > + for (unsigned j = 0; j < 3; ++j) > + { > + tree rhs = ssa[j]; > + if (rhs && add_to_imports (rhs, imports)) > + worklist.safe_push (rhs); > + } > + } We seem to have 3 copies of this copy now: this one, the threadbackward one, and the original one. Could we abstract this somehow? Aldy