From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 7248C3858D20 for ; Mon, 26 Jun 2023 09:22:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7248C3858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1687771338; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=m33rBoBUzPBXRSTp8PM3g7XXMTitpf3zTf2GBoUXnG8=; b=iyjX/3cESzlz7lo/mD524PaQbJsAAAOMZcl/2Z3Xz3lUKl9DSsqsXoJqmPQoTzT/yORulE zdPKtzOQxjuhHNMae11P+Ek0zDvBIPMT2twydsdmoY8A3fL2kbrRf0zZBz45sqWk6jnwR8 Rpfbk+QSqcYOQvA7NWcISdQL5ladNLQ= Received: from mail-lf1-f69.google.com (mail-lf1-f69.google.com [209.85.167.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-426-XMxQ5JnnPaSi5Qnet7Y72w-1; Mon, 26 Jun 2023 05:22:14 -0400 X-MC-Unique: XMxQ5JnnPaSi5Qnet7Y72w-1 Received: by mail-lf1-f69.google.com with SMTP id 2adb3069b0e04-4fb76659d37so478052e87.2 for ; Mon, 26 Jun 2023 02:22:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687771332; x=1690363332; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=m33rBoBUzPBXRSTp8PM3g7XXMTitpf3zTf2GBoUXnG8=; b=fMEmCU+k6yPN09jG8PEKNTRHCPxe/evWb2sPBUVdCC6A3vry+8FNHTkbNzcpqx55is ch5SOWZcHbTqf4D7/TGkdW57uQZLgidcAucyh1yxUpxNlNYJwbt6q4YTQvCFUqMBGmen tiAKs87zYybttegiidRmWGT+dL9TXknWGL8XvTIOHCgqFyjJWGgrnXvyc2MuFU5cJKhT 96KcbT27qvd+evGOQJxbcwgOsLM24YKi8dg5oCizhRlMZda2wPOk3rCLlBjwwI+sqvfr CQsUJsMMQBKi5wN+vgVq/XXnOYuBX+R5pX/JxS1M0BE6PkHG7EjkLNH1PnTU6jz/c34k VHCw== X-Gm-Message-State: AC+VfDyElbG7GjCvGC21RoW9hY49Qe8OZtNXQehdQIs6OMVmt5xEp1UA y2zl2MZ5dEPvoyuiCfue32uTyPhFef6N2eIPzXygYIkCNQxDXBXMI3A6rNahwbAhBHmP0uh0gs/ A0mBhKOsPi78lWOP+bMZNbSRHhfu8te8kNA== X-Received: by 2002:a19:4f52:0:b0:4f8:66e1:14e3 with SMTP id a18-20020a194f52000000b004f866e114e3mr12997428lfk.17.1687771332587; Mon, 26 Jun 2023 02:22:12 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4vnq3gLe6ReXtTYE1O56gXsYboVQQK4nT2HmeIEys0KyIDrCooRhq136TjWAzFlwK8YOFPjOtfiPhBSlFykFI= X-Received: by 2002:a19:4f52:0:b0:4f8:66e1:14e3 with SMTP id a18-20020a194f52000000b004f866e114e3mr12997420lfk.17.1687771332242; Mon, 26 Jun 2023 02:22:12 -0700 (PDT) MIME-Version: 1.0 References: <20230522185622.537454-1-aldyh@redhat.com> <20230522185622.537454-2-aldyh@redhat.com> <3feb043e-bae6-513d-247b-ed0c23d0d21a@redhat.com> In-Reply-To: From: Aldy Hernandez Date: Mon, 26 Jun 2023 11:22:01 +0200 Message-ID: Subject: Re: [PATCH] Implement ipa_vr hashing. To: Martin Jambor , GCC patches Cc: Andrew MacLeod X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: PING*3 On Thu, Jun 22, 2023 at 7:49=E2=80=AFAM Aldy Hernandez w= rote: > > Ping*2 > > On Wed, Jun 14, 2023, 14:11 Aldy Hernandez wrote: >> >> PING >> >> On Sat, Jun 10, 2023 at 10:30=E2=80=AFPM Aldy Hernandez wrote: >> > >> > >> > >> > On 5/29/23 16:51, Martin Jambor wrote: >> > > Hi, >> > > >> > > On Mon, May 22 2023, Aldy Hernandez via Gcc-patches wrote: >> > >> Implement hashing for ipa_vr. When all is said and done, all these >> > >> patches incurr a 7.64% slowdown for ipa-cp, with is entirely covere= d by >> > >> the similar 7% increase in this area last week. So we get type agn= ostic >> > >> ranges with "infinite" range precision close to free. >> > > >> > > Do you know why/where this slow-down happens? Do we perhaps want to >> > > limit the "infiniteness" a little somehow? >> > >> > I addressed the slow down in another mail. >> > >> > > >> > > Also, jump functions live for a long time, have you looked at how me= mory >> > > hungry they become? I hope that the hashing would be good at preven= ting >> > > any issues. >> > >> > On a side-note, the caching does help. On a (mistaken) hunch, I had >> > played around with removing caching for everything but UNDEFINED/VARYI= NG >> > and zero/nonzero to simplify things, but the cache hit ratio was still >> > surprisingly high (+80%). So good job there :-). >> > >> > > >> > > Generally, I think I OK with the patches if the impact on memory is = not >> > > too bad, though I guess they depend on the one I looked at last week= , so >> > > we may focus on that one first. >> > >> > I'm not sure whether this was an OK for the other patches, given you >> > approved the first patch, so I'll hold off until you give the go-ahead= . >> > >> > Thanks. >> > Aldy