From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id C80D73858C66 for ; Fri, 28 Oct 2022 06:22:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C80D73858C66 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1666938149; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=emLtSQ2HpbD0X996Pl9dxZPrtfQ61nnyzPOKKxjcqAE=; b=DLuqkVC5MWZWK1bmFp0UlLoYUL6ImGsfG5VbnvtFSCfqTMrG5RPEnahkKG3iI1coeAA9oW WB7ltPBSalhVHWkw9vT+R4lxsbFs4mnPDObkONRPk5en8VsOZtd5YY2JMJKlRi0ouWg/1Q 72oCThOxp4AFJu5dpNaGEqt07ot2Vw0= Received: from mail-yw1-f200.google.com (mail-yw1-f200.google.com [209.85.128.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-643-STeZqJ_8MQer9OhRwvYs_A-1; Fri, 28 Oct 2022 02:22:24 -0400 X-MC-Unique: STeZqJ_8MQer9OhRwvYs_A-1 Received: by mail-yw1-f200.google.com with SMTP id 00721157ae682-37010fefe48so18428467b3.19 for ; Thu, 27 Oct 2022 23:22:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=emLtSQ2HpbD0X996Pl9dxZPrtfQ61nnyzPOKKxjcqAE=; b=b8oPErgPTrAVcRphEKCijXoHxl/JpIRB9g6LNluZxaPba7amz+LN9/tBWdU2t6A5KS 4nA3H/YZ27b7e/GM4OV/P+u+oXRvwQ6+SaeJD7lkhSqt7qaiNFlrExsrnfimRQ8ZWFzo 58V64waRpn9OtnHEWGAd1t72nalFXX5PfFK4ylvjpXRYfcNnJ4sco9ZliEGTuw/JFjuu v53BZaBZzuVuqBghsVsUHlE4AGu6D9gQPVHSGZZoy3wdSEFamBf3vIkjH6+bGUh5yP+s u2/3lBnyHG/9XNWRIOacSoCICesQey07i8dzykXEw2T2bLFyRw0M7/iIrkqEgRfHv2Gs pE7Q== X-Gm-Message-State: ACrzQf2HRSz4isrAWD31lVKROe+LUOJVRd5t4RnosjjKEVye8/2cqgVs RjJTMpUYyQM3KcDlKpZGnhRVoheLcuaSdIaYJK8MIKUYqbfZo/ruyhV7F8wf5gDSX99LVshxJ7q LAqqn2Yg5SL3sjZX/ZEUny8YGuBODx26p8w== X-Received: by 2002:a25:bb86:0:b0:6cb:ed03:186a with SMTP id y6-20020a25bb86000000b006cbed03186amr4147176ybg.109.1666938144227; Thu, 27 Oct 2022 23:22:24 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5WTIb+ue1Cm9faI23XiN5splT33Um193olq0V18/zYfjrWzCRushYzGhIX77kSo43azLc2mfSMrgQUPrPzs/o= X-Received: by 2002:a25:bb86:0:b0:6cb:ed03:186a with SMTP id y6-20020a25bb86000000b006cbed03186amr4147165ybg.109.1666938144024; Thu, 27 Oct 2022 23:22:24 -0700 (PDT) MIME-Version: 1.0 References: <20221025205901.125058-1-aldyh@redhat.com> In-Reply-To: From: Aldy Hernandez Date: Fri, 28 Oct 2022 08:22:12 +0200 Message-ID: Subject: Re: [PATCH] Convert flag_finite_math_only uses in frange to HONOR_*. To: Jeff Law Cc: GCC patches X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/mixed; boundary="000000000000f048da05ec124785" X-Spam-Status: No, score=-12.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --000000000000f048da05ec124785 Content-Type: text/plain; charset="UTF-8" On Fri, Oct 28, 2022 at 1:00 AM Jeff Law wrote: > > > On 10/25/22 14:59, Aldy Hernandez via Gcc-patches wrote: > > [As Richi, and probably Jakub, have mentioned in the past...] > > > > As mentioned earlier, we should be using HONOR_* on types rather than > > flag_finite_math_only. > > > > Will commit pending tests. > > > > gcc/ChangeLog: > > > > * value-range.cc (frange::set): Use HONOR_*. > > (frange::verify_range): Same. > > * value-range.h (frange_val_min): Same. > > (frange_val_max): Same. > > I haven't verified it's this patch, but our friend the vax regression is > back: Bah. I suck. There was one remaining use of flag_finite_math_only in the self tests. Fixed and finally done: $ grep flag_finite *range* value-range.cc: int save_finite_math_only = flag_finite_math_only; value-range.cc: flag_finite_math_only = 1; value-range.cc: flag_finite_math_only = 0; value-range.cc: flag_finite_math_only = save_finite_math_only; Aldy --000000000000f048da05ec124785 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Change-remaining-flag_finite_math_only-use-in-value-.patch" Content-Disposition: attachment; filename="0001-Change-remaining-flag_finite_math_only-use-in-value-.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_l9s3vecj0 RnJvbSBkYzU1ODQxZDlhNDVhMmQ5M2VhZWRkNjg4NDFmNzUxNDcyMzkzOWQxIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbGR5IEhlcm5hbmRleiA8YWxkeWhAcmVkaGF0LmNvbT4KRGF0 ZTogRnJpLCAyOCBPY3QgMjAyMiAwODoxMzozOCArMDIwMApTdWJqZWN0OiBbUEFUQ0hdIENoYW5n ZSByZW1haW5pbmcgZmxhZ19maW5pdGVfbWF0aF9vbmx5IHVzZSBpbiB2YWx1ZS1yYW5nZS5jYy4K CmdjYy9DaGFuZ2VMb2c6CgoJKiB2YWx1ZS1yYW5nZS5jYyAocmFuZ2VfdGVzdHNfZmxvYXRzKTog VXNlIEhPTk9SX0lORklOSVRJRVMuCi0tLQogZ2NjL3ZhbHVlLXJhbmdlLmNjIHwgMiArLQogMSBm aWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAxIGRlbGV0aW9uKC0pCgpkaWZmIC0tZ2l0IGEv Z2NjL3ZhbHVlLXJhbmdlLmNjIGIvZ2NjL3ZhbHVlLXJhbmdlLmNjCmluZGV4IDc3ZTVhMmNjMjk5 Li4wM2IzYzRiNGE2NSAxMDA2NDQKLS0tIGEvZ2NjL3ZhbHVlLXJhbmdlLmNjCisrKyBiL2djYy92 YWx1ZS1yYW5nZS5jYwpAQCAtNDAzMSw3ICs0MDMxLDcgQEAgcmFuZ2VfdGVzdHNfZmxvYXRzICgp CiAgIHIwLmludGVyc2VjdCAocjEpOwogICBBU1NFUlRfVFJVRSAocjAudW5kZWZpbmVkX3AgKCkp OwogCi0gIGlmICghZmxhZ19maW5pdGVfbWF0aF9vbmx5KQorICBpZiAoSE9OT1JfSU5GSU5JVElF UyAoZmxvYXRfdHlwZV9ub2RlKSkKICAgICB7CiAgICAgICAvLyBNYWtlIHN1cmUgWy1JbmYsIC1J bmZdIGRvZXNuJ3QgZ2V0IG5vcm1hbGl6ZWQuCiAgICAgICByMCA9IGZyYW5nZV9mbG9hdCAoIi1J bmYiLCAiLUluZiIpOwotLSAKMi4zNy4zCgo= --000000000000f048da05ec124785--