From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id B47B23858283 for ; Tue, 8 Nov 2022 12:48:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B47B23858283 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1667911691; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ht0o+xG6J1PwYu/tt025wyyVnrrDg5Glvm9e96iD5vA=; b=D2XwuIoh85uWFahAASVaD+Ii+4CEeQx7X5THdwSP63EkrJ0K06/Tg08Vcwcuo2d3XZfBPE nijsB9rTD0mEhTU4e8LHXbpcFWxUbsqYzjCcjQCiNdIbIP86t18bDKd+1vRTMAFMEr9L3c EWfJef8KsUHI2bTrZoV7jh//1e1ZfYA= Received: from mail-yw1-f200.google.com (mail-yw1-f200.google.com [209.85.128.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-588-C48x58b5OZech2agNQhO4g-1; Tue, 08 Nov 2022 07:48:10 -0500 X-MC-Unique: C48x58b5OZech2agNQhO4g-1 Received: by mail-yw1-f200.google.com with SMTP id 00721157ae682-349423f04dbso136244857b3.13 for ; Tue, 08 Nov 2022 04:48:10 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ht0o+xG6J1PwYu/tt025wyyVnrrDg5Glvm9e96iD5vA=; b=t6W48rgPE0x1EfZYpJlXP7nh7PaTNuKiihwymG8UdD/8nby9varnOX37em4bnnheUp iAgHORnSJwShLRRuW1PqJR2qRF+ezlULihLWT96d8WxODs6o8EJXgfKpH5icPMsWw9bL I1DAS9L1BqpJCLBizpXfvEvfijwJIo3xQ+TbQRN6jFgVtkmm253hDMNL01cCtrSgg4cT Uj6ny9fliFjJ5L5ahkQvw4FIyj9olZOrwyb+7bYdwgEuXT3ZgRValy/LAPYENV7gJ8fX ija1VyNL+JjpdK4llp9R9lwv/PbApz6Q6WdxOqiTpEBFtKT7hIHmCaNDPwsbl4rriKgs FCEw== X-Gm-Message-State: ACrzQf2EcUhllAfatjmRCTeK7XnFIjbHnU/fqtbeh40A/pPSJH4fzD71 8E5ZAbTmx8mjmPby3eT1VlPKqOvm3H4Ueot0f2Sr+8GsEXmW9a2rGN7xu0KCd6Scr3hNvl1Gwyp lSOpJNLQCZrJ8JqQClt9j1n3VOm57L/BYpA== X-Received: by 2002:a05:6902:13c8:b0:6af:f2b8:e164 with SMTP id y8-20020a05690213c800b006aff2b8e164mr53371233ybu.466.1667911689802; Tue, 08 Nov 2022 04:48:09 -0800 (PST) X-Google-Smtp-Source: AMsMyM4fdBHCgBeMwakwWY5CpWJZISw+2fCJCFit31wTWFucg7azSNZlBXSZ8Eq7bJxUW3kaPBcVqFAhEFFBTfddOZU= X-Received: by 2002:a05:6902:13c8:b0:6af:f2b8:e164 with SMTP id y8-20020a05690213c800b006aff2b8e164mr53371213ybu.466.1667911689501; Tue, 08 Nov 2022 04:48:09 -0800 (PST) MIME-Version: 1.0 References: <20221013123649.474497-1-aldyh@redhat.com> In-Reply-To: From: Aldy Hernandez Date: Tue, 8 Nov 2022 13:47:58 +0100 Message-ID: Subject: Re: [PATCH] [PR24021] Implement PLUS_EXPR range-op entry for floats. To: Jakub Jelinek Cc: "MacLeod, Andrew" , GCC patches X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/mixed; boundary="000000000000c5315805ecf4f32b" X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --000000000000c5315805ecf4f32b Content-Type: text/plain; charset="UTF-8" On Tue, Nov 8, 2022 at 12:07 PM Jakub Jelinek wrote: > > On Mon, Nov 07, 2022 at 04:38:29PM +0100, Aldy Hernandez wrote: > > From d214bcdff2cb90ad1eb808d29bda6fb98d510b4c Mon Sep 17 00:00:00 2001 > > From: Aldy Hernandez > > Date: Mon, 7 Nov 2022 14:18:57 +0100 > > Subject: [PATCH] Provide normalized and denormal format version of > > real_isdenormal. > > > > Implement real_isdenormal_target() to be used within real.cc where the > > argument is known to be in denormal format. Rewrite real_isdenormal() > > for use outside of real.cc where the argument is known to be > > normalized. > > > > gcc/ChangeLog: > > > > * real.cc (real_isdenormal_target): New. > > (encode_ieee_single): Use real_isdenormal_target. > > (encode_ieee_double): Same. > > (encode_ieee_extended): Same. > > (encode_ieee_quad): Same. > > (encode_ieee_half): Same. > > (encode_arm_bfloat_half): Same. > > * value-range.cc (frange::flush_denormals_to_zero): Same. > > * real.h (real_isdenormal): Rewrite to look at mode. > > I'd make real_isdenormal_target static inline bool > rather than inline bool, it is only defined in real.cc, so there is > no point exporting it. Huh. I thought inline alone would inhibit the exporting. Thanks. > Though, as you've added the mode argument, the real.cc inline > could very well also be called real_isdenormal too, it wouldn't be > a redeclaration or ODR violation. Great, even better. OK pending tests? Aldy --000000000000c5315805ecf4f32b Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Provide-normalized-and-denormal-format-version-of-re.patch" Content-Disposition: attachment; filename="0001-Provide-normalized-and-denormal-format-version-of-re.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_la87jj8r0 RnJvbSBjM2NhMWQ2MDZiZmIyMmJmNGY4YmM3YWMwY2U1NjFiZDZhZmMzMzY4IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbGR5IEhlcm5hbmRleiA8YWxkeWhAcmVkaGF0LmNvbT4KRGF0 ZTogTW9uLCA3IE5vdiAyMDIyIDE0OjE4OjU3ICswMTAwClN1YmplY3Q6IFtQQVRDSF0gUHJvdmlk ZSBub3JtYWxpemVkIGFuZCBkZW5vcm1hbCBmb3JtYXQgdmVyc2lvbiBvZgogcmVhbF9pc2Rlbm9y bWFsLgoKSW1wbGVtZW50IGEgdmFyaWFudCBvZiByZWFsX2lzZGVub3JtYWwoKSB0byBiZSB1c2Vk IHdpdGhpbiByZWFsLmNjCndoZXJlIHRoZSBhcmd1bWVudCBpcyBrbm93biB0byBiZSBpbiBkZW5v cm1hbCBmb3JtYXQuICBSZXdyaXRlCnJlYWxfaXNkZW5vcm1hbCgpIGZvciB1c2Ugb3V0c2lkZSBv ZiByZWFsLmNjIHdoZXJlIHRoZSBhcmd1bWVudCBpcwprbm93biB0byBiZSBub3JtYWxpemVkLgoK Z2NjL0NoYW5nZUxvZzoKCgkqIHJlYWwuY2MgKHJlYWxfaXNkZW5vcm1hbCk6IE5ldy4KCSogcmVh bC5oIChyZWFsX2lzZGVub3JtYWwpOiBBZGQgbW9kZSBhcmd1bWVudC4gIFJld3JpdGUgZm9yCglu b3JtYWxpemVkIHZhbHVlcy4KCSogdmFsdWUtcmFuZ2UuY2MgKGZyYW5nZTo6Zmx1c2hfZGVub3Jt YWxzX3RvX3plcm8pOiBQYXNzIG1vZGUgdG8KCXJlYWxfaXNkZW5vcm1hbC4KLS0tCiBnY2MvcmVh bC5jYyAgICAgICAgfCAxMCArKysrKysrKysrCiBnY2MvcmVhbC5oICAgICAgICAgfCAgNyArKysr LS0tCiBnY2MvdmFsdWUtcmFuZ2UuY2MgfCAgNSArKystLQogMyBmaWxlcyBjaGFuZ2VkLCAxNyBp bnNlcnRpb25zKCspLCA1IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2djYy9yZWFsLmNjIGIv Z2NjL3JlYWwuY2MKaW5kZXggYWFlN2MzMzVkNTkuLjAyOGFhZDk1ZWM0IDEwMDY0NAotLS0gYS9n Y2MvcmVhbC5jYworKysgYi9nY2MvcmVhbC5jYwpAQCAtMTExLDYgKzExMSwxNiBAQCBzdGF0aWMg Y29uc3QgUkVBTF9WQUxVRV9UWVBFICogcmVhbF9kaWdpdCAoaW50KTsKIHN0YXRpYyB2b2lkIHRp bWVzX3B0ZW4gKFJFQUxfVkFMVUVfVFlQRSAqLCBpbnQpOwogCiBzdGF0aWMgdm9pZCByb3VuZF9m b3JfZm9ybWF0IChjb25zdCBzdHJ1Y3QgcmVhbF9mb3JtYXQgKiwgUkVBTF9WQUxVRV9UWVBFICop OworCisvKiBEZXRlcm1pbmUgd2hldGhlciBhIGZsb2F0aW5nLXBvaW50IHZhbHVlIFggaXMgYSBk ZW5vcm1hbC4gIFIgaXMKKyAgIGV4cGVjdGVkIHRvIGJlIGluIGRlbm9ybWFsIGZvcm0sIHNvIHRo aXMgZnVuY3Rpb24gaXMgb25seQorICAgbWVhbmluZ2Z1bCBhZnRlciBhIGNhbGwgdG8gcm91bmRf Zm9yX2Zvcm1hdC4gICovCisKK3N0YXRpYyBpbmxpbmUgYm9vbAorcmVhbF9pc2Rlbm9ybWFsIChj b25zdCBSRUFMX1ZBTFVFX1RZUEUgKnIpCit7CisgIHJldHVybiAoci0+c2lnW1NJR1NaLTFdICYg U0lHX01TQikgPT0gMDsKK30KIAwKIC8qIEluaXRpYWxpemUgUiB3aXRoIGEgcG9zaXRpdmUgemVy by4gICovCiAKZGlmZiAtLWdpdCBhL2djYy9yZWFsLmggYi9nY2MvcmVhbC5oCmluZGV4IDMwNmU5 NTkzODY2Li5iMTRiY2RkM2ZkZSAxMDA2NDQKLS0tIGEvZ2NjL3JlYWwuaAorKysgYi9nY2MvcmVh bC5oCkBAIC0yODYsMTEgKzI4NiwxMiBAQCBleHRlcm4gYm9vbCByZWFsX2lzbmFuIChjb25zdCBS RUFMX1ZBTFVFX1RZUEUgKik7CiAvKiBEZXRlcm1pbmUgd2hldGhlciBhIGZsb2F0aW5nLXBvaW50 IHZhbHVlIFggaXMgYSBzaWduYWxpbmcgTmFOLiAgKi8KIGV4dGVybiBib29sIHJlYWxfaXNzaWdu YWxpbmdfbmFuIChjb25zdCBSRUFMX1ZBTFVFX1RZUEUgKik7CiAKLS8qIERldGVybWluZSB3aGV0 aGVyIGEgZmxvYXRpbmctcG9pbnQgdmFsdWUgWCBpcyBhIGRlbm9ybWFsLiAgKi8KKy8qIERldGVy bWluZSB3aGV0aGVyIGZsb2F0aW5nLXBvaW50IHZhbHVlIFIgaXMgYSBkZW5vcm1hbC4gIFRoaXMK KyAgIGZ1bmN0aW9uIGlzIG9ubHkgdmFsaWQgZm9yIG5vcm1hbGl6ZWQgdmFsdWVzLiAgKi8KIGlu bGluZSBib29sCi1yZWFsX2lzZGVub3JtYWwgKGNvbnN0IFJFQUxfVkFMVUVfVFlQRSAqcikKK3Jl YWxfaXNkZW5vcm1hbCAoY29uc3QgUkVBTF9WQUxVRV9UWVBFICpyLCBtYWNoaW5lX21vZGUgbW9k ZSkKIHsKLSAgcmV0dXJuIHItPmNsID09IHJ2Y19ub3JtYWwgJiYgKHItPnNpZ1tTSUdTWi0xXSAm IFNJR19NU0IpID09IDA7CisgIHJldHVybiByLT5jbCA9PSBydmNfbm9ybWFsICYmIFJFQUxfRVhQ IChyKSA8IFJFQUxfTU9ERV9GT1JNQVQgKG1vZGUpLT5lbWluOwogfQogCiAvKiBEZXRlcm1pbmUg d2hldGhlciBhIGZsb2F0aW5nLXBvaW50IHZhbHVlIFggaXMgZmluaXRlLiAgKi8KZGlmZiAtLWdp dCBhL2djYy92YWx1ZS1yYW5nZS5jYyBiL2djYy92YWx1ZS1yYW5nZS5jYwppbmRleCBhODU1YWFm NjI2Yy4uODU5YzdmYjRhZjkgMTAwNjQ0Ci0tLSBhL2djYy92YWx1ZS1yYW5nZS5jYworKysgYi9n Y2MvdmFsdWUtcmFuZ2UuY2MKQEAgLTI2NiwxNSArMjY2LDE2IEBAIGZyYW5nZTo6Zmx1c2hfZGVu b3JtYWxzX3RvX3plcm8gKCkKICAgaWYgKHVuZGVmaW5lZF9wICgpIHx8IGtub3duX2lzbmFuICgp KQogICAgIHJldHVybjsKIAorICBtYWNoaW5lX21vZGUgbW9kZSA9IFRZUEVfTU9ERSAodHlwZSAo KSk7CiAgIC8vIEZsdXNoIFt4LCAtREVOT1JNQUxdIHRvIFt4LCAtMC4wXS4KLSAgaWYgKHJlYWxf aXNkZW5vcm1hbCAoJm1fbWF4KSAmJiByZWFsX2lzbmVnICgmbV9tYXgpKQorICBpZiAocmVhbF9p c2Rlbm9ybWFsICgmbV9tYXgsIG1vZGUpICYmIHJlYWxfaXNuZWcgKCZtX21heCkpCiAgICAgewog ICAgICAgbV9tYXggPSBkY29uc3QwOwogICAgICAgaWYgKEhPTk9SX1NJR05FRF9aRVJPUyAobV90 eXBlKSkKIAltX21heC5zaWduID0gMTsKICAgICB9CiAgIC8vIEZsdXNoIFsrREVOT1JNQUwsIHhd IHRvIFsrMC4wLCB4XS4KLSAgaWYgKHJlYWxfaXNkZW5vcm1hbCAoJm1fbWluKSAmJiAhcmVhbF9p c25lZyAoJm1fbWluKSkKKyAgaWYgKHJlYWxfaXNkZW5vcm1hbCAoJm1fbWluLCBtb2RlKSAmJiAh cmVhbF9pc25lZyAoJm1fbWluKSkKICAgICBtX21pbiA9IGRjb25zdDA7CiB9CiAKLS0gCjIuMzgu MQoK --000000000000c5315805ecf4f32b--