From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 868923856DF3 for ; Tue, 2 Aug 2022 12:03:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 868923856DF3 Received: from mail-oa1-f71.google.com (mail-oa1-f71.google.com [209.85.160.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-542-9je9eNG4PXa3TDAV7Z8p-A-1; Tue, 02 Aug 2022 08:03:15 -0400 X-MC-Unique: 9je9eNG4PXa3TDAV7Z8p-A-1 Received: by mail-oa1-f71.google.com with SMTP id 586e51a60fabf-101be2b197dso4811762fac.4 for ; Tue, 02 Aug 2022 05:03:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=Obc2pY0pWieYrfyEXLSnjsnZXUEFq43U5hlUz9yKtvk=; b=5xNgMCx4WYaQrbmYurgmtvbYI8XEMgN8oBHN/FICRy47k3NV4RRtyZjfH5Cnmc7lyM Ao+omXW1hSP4FZE/PezFI+/n2Y3hPowqDBJN8RjAXHc8EZfCnyb0ank4eYDK9gsp2ZMc neM9WIafgQGyqjQsuyi6WvlodZEooSMwXHgYGESu8+mhMyedCY4bUehuuMr7R4N79a3G XCLW9CrRkmyIYeHJY0cHqkm5c5V8pLiVEkHHR4iCJbSztiMIICvA1dxuWGDmpgKB82Dv Y6s5e9zEIiHtRgHJkE2DH9LhX+poHoO1zyJew7ekzVBFLegwbYYJjiZgNn39pHA9KN7e +CmA== X-Gm-Message-State: ACgBeo0yEwm9CYKX/t8Wz5Xv/PoDNXdRaAt144BKAoQiaT3WuSDR5c0M se0JKw/9uR2YXG6ChWJwIarIRJvsWj4Aq7/GuY3Tq04Q7aqN/07KhS8lloj2NW9p51WLKauyjk8 /Efkhr+K2z7XcQoY36kKd3FmMUix7HenBkg== X-Received: by 2002:a4a:894e:0:b0:440:b743:c7d with SMTP id g14-20020a4a894e000000b00440b7430c7dmr484005ooi.86.1659441794565; Tue, 02 Aug 2022 05:03:14 -0700 (PDT) X-Google-Smtp-Source: AA6agR7EymS1JDTu+yLyylM4g7opn+nxP2bzifClx4HmpYp4Kp4pvydsyXImE373zwueMjqR55/qJWlh5ih+jhaLbAc= X-Received: by 2002:a4a:894e:0:b0:440:b743:c7d with SMTP id g14-20020a4a894e000000b00440b7430c7dmr483985ooi.86.1659441794262; Tue, 02 Aug 2022 05:03:14 -0700 (PDT) MIME-Version: 1.0 References: <04261.122080204410800126@us-mta-529.us.mimecast.lan> In-Reply-To: From: Aldy Hernandez Date: Tue, 2 Aug 2022 14:03:03 +0200 Message-ID: Subject: Re: [PATCH] Properly honor param_max_fsm_thread_path_insns in backwards threader To: Richard Biener Cc: gcc-patches , "MacLeod, Andrew" , Jeff Law , Jan Hubicka X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-5.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Aug 2022 12:03:29 -0000 On Tue, Aug 2, 2022 at 1:59 PM Richard Biener wrote: > > On Tue, 2 Aug 2022, Aldy Hernandez wrote: > > > On Tue, Aug 2, 2022 at 1:45 PM Richard Biener wrote: > > > > > > On Tue, 2 Aug 2022, Aldy Hernandez wrote: > > > > > > > Unfortunately, this was before my time, so I don't know. > > > > > > > > That being said, thanks for tackling these issues that my work > > > > triggered last release. Much appreciated. > > > > > > Ah. But it was your r12-324-g69e5544210e3c0 that did > > > > > > - else if (n_insns > 1) > > > + else if (!m_speed_p && n_insns > 1) > > > > > > causing the breakage on the 12 branch. That leads to a simpler > > > fix I guess. Will re-test and also backport to GCC 12 if successful. > > > > Huh. It's been a while, but that looks like a typo. That patch was > > supposed to be non-behavior changing. > > Exactly my thinking so reverting it shouldn't be a reason for > detailed questions. Now, the contains_hot_bb computation is, Sorry for the pain. Thanks for taking care of this. Aldy > that one was introduced by Honza in r7-6476-g0f0c2cc3a17efa > together with the comment and a testcase. > > So - Honza, what was the reasoning to look at raw BB counts here > rather than for example the path entry edge count? > > Richard. >