From: Aldy Hernandez <aldyh@redhat.com>
To: Aldy Hernandez <aldyh@redhat.com>,
GCC patches <gcc-patches@gcc.gnu.org>,
Richard Sandiford <richard.sandiford@arm.com>
Subject: Re: [PATCH] Replace evrp use in loop versioning with ranger.
Date: Mon, 26 Jul 2021 18:08:42 +0200 [thread overview]
Message-ID: <CAGm3qMV5NQWpJ8TRW59gBfZw4+fC1cV3gUcmqDk5swoFve3N7g@mail.gmail.com> (raw)
In-Reply-To: <CAGm3qMWsng=xMDHyLS6_exk_EOYYx9Z++s0ZPFqmQjB_buug0w@mail.gmail.com>
> > How expensive is the check? If the result is worth caching, perhaps
> > we should have two bitmaps: the existing one, and one that records
> > whether we've checked a particular SSA name.
> >
> > If the check is relatively cheap then that won't be worth it though.
>
> If you're asking about the range_of_expr check, that's all cached, so
> it should be pretty cheap. Besides, we're no longer calculating
> ranges for each statement in the IL, as we were doing in lv_dom_walker
> with evrp's record_ranges_from_stmt. Only statements of interest are
> queried.
You know, we already have infrastructure to test performance of small
changes with callgrind. If you want I can compare numbers for:
1. mainline right now
2. my proposed patch
3. my proposed patch without a dom walk
Aldy
next prev parent reply other threads:[~2021-07-26 16:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-24 14:19 Aldy Hernandez
2021-07-26 14:18 ` Richard Sandiford
2021-07-26 15:16 ` Aldy Hernandez
2021-07-26 16:08 ` Aldy Hernandez [this message]
2021-07-26 17:28 ` Richard Sandiford
2021-07-27 9:52 ` Aldy Hernandez
2021-07-30 8:39 ` Richard Sandiford
2021-07-30 9:34 ` Aldy Hernandez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGm3qMV5NQWpJ8TRW59gBfZw4+fC1cV3gUcmqDk5swoFve3N7g@mail.gmail.com \
--to=aldyh@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=richard.sandiford@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).