From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id A72E73858D34 for ; Mon, 26 Jul 2021 16:15:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A72E73858D34 Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-591-RYK0NgilMOujpi4Mg-cwow-1; Mon, 26 Jul 2021 12:15:05 -0400 X-MC-Unique: RYK0NgilMOujpi4Mg-cwow-1 Received: by mail-ed1-f69.google.com with SMTP id c20-20020a0564021014b029039994f9cab9so4953660edu.22 for ; Mon, 26 Jul 2021 09:15:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=dKX+794qZUK33ebck+P2pTaa+u1Gh93yhOpz/5tjyZw=; b=HO52bCd7C4ydWB7xRC1JDQXFSLCBzH4jAXddQ394XVio3vaGjPdto+avYlWs/zHmty y8bK0UAJk4RpmqdW04TqRrry5gu2wS6N3cKufpD+EP1FFlm6kWpM1cm3J78xkPag7z/+ yACNY8XcPi5+CHkFu2Ic6moArpdFNH3GbCWHPiWL7C+V19AQP/ZPpB/6uOvlmgmdhPdJ U8qCgCe8oCjuZF0FoQBj5ANIfLmc4gPo+tGf7TfRN+F73sOQGXyHS3DLRgYT/sk4V/I/ cJt2Pd/L7vhdXf+C11OguPO9WmyT/ty5nzjWiFx1h3uJwcKfrLjyXqJCRPttLMCCYjrG j/fA== X-Gm-Message-State: AOAM531T0XN9LIXP9nQdqYS/wC4cN8G30eaEbUC/ZLC8ppTJyUPmhgMk EzKu1hMSYM5R6YABs1KME4xh+F0tZK9SOnYGEFTlHxLebcya/bTgDQeqVvn2Dvszx4hyJzgvMcx bED1b+bFwJ/UeavvDkgW56vHeM86Di6dLRQ== X-Received: by 2002:a17:906:7716:: with SMTP id q22mr17904621ejm.457.1627316103680; Mon, 26 Jul 2021 09:15:03 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwXjz2FZ2vqxzpM/j5NIdCjkkqFxs9znr1pqGj0LnX823lSG0AXWgYUKM7MopHHIB3CptMx2Vbs5Esu6+Dmu2Y= X-Received: by 2002:ac2:5049:: with SMTP id a9mr13108360lfm.177.1627315733669; Mon, 26 Jul 2021 09:08:53 -0700 (PDT) MIME-Version: 1.0 References: <20210724141937.2325339-1-aldyh@redhat.com> In-Reply-To: From: Aldy Hernandez Date: Mon, 26 Jul 2021 18:08:42 +0200 Message-ID: Subject: Re: [PATCH] Replace evrp use in loop versioning with ranger. To: Aldy Hernandez , GCC patches , Richard Sandiford X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-7.3 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Jul 2021 16:15:08 -0000 > > How expensive is the check? If the result is worth caching, perhaps > > we should have two bitmaps: the existing one, and one that records > > whether we've checked a particular SSA name. > > > > If the check is relatively cheap then that won't be worth it though. > > If you're asking about the range_of_expr check, that's all cached, so > it should be pretty cheap. Besides, we're no longer calculating > ranges for each statement in the IL, as we were doing in lv_dom_walker > with evrp's record_ranges_from_stmt. Only statements of interest are > queried. You know, we already have infrastructure to test performance of small changes with callgrind. If you want I can compare numbers for: 1. mainline right now 2. my proposed patch 3. my proposed patch without a dom walk Aldy